From a2f320beec03265b1c6bbe854d2eec4116cdbf16 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 00:18:27 -0700 Subject: [PATCH 01/11] test(agent): cover media tray preview flow --- .../agent/agentComposerAssetDrop.spec.ts | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 26cf330b2a2..8c41d5f0140 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -71,6 +71,51 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { }) } + test( + 'previews a video from the keyboard and cleans it up with its attachment', + { tag: '@ui' }, + async ({ page }) => { + const agentPanel = new AgentPanel(page) + await agentPanel.open() + + const assets = new AssetsSidebarTab(page) + await assets.open() + await assets.assetCards.first().dragTo(agentPanel.root) + + const chip = agentPanel.attachmentChip(ASSET_NAME) + const trigger = chip.getByRole('button', { + name: `Preview ${ASSET_NAME}` + }) + const poster = trigger.getByRole('img', { name: ASSET_NAME }) + await expect(poster).toBeVisible() + await expect(poster).toHaveAttribute('src', /^blob:/) + + await trigger.focus() + await page.keyboard.press('Enter') + + const player = page + .getByLabel(ASSET_NAME, { exact: true }) + .and(page.locator('video')) + await expect(player).toBeVisible() + await expect(player).toHaveAttribute('controls', '') + await expect(player).toHaveAttribute('poster', /^blob:/) + await expect(player).toBeFocused() + + await page.keyboard.press('Escape') + await expect(player).toHaveCount(0) + await expect(trigger).toHaveAttribute('aria-expanded', 'false') + await expect(trigger).toBeFocused() + + await page.keyboard.press('Enter') + await expect(player).toBeVisible() + await chip.hover() + await chip.getByRole('button', { name: 'Remove' }).click() + + await expect(chip).toHaveCount(0) + await expect(player).toHaveCount(0) + } + ) + // A filename is user data and may contain a quote or a backslash, which would // break the attribute selector the chip is matched by. Exercised end to end // rather than unit-tested, so a regression in the escaping shows up as the From 9229a44c6344cb658e0e61b2682e769b83cc7915 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:11:07 -0700 Subject: [PATCH 02/11] test(agent): narrow media preview claim Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045426 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 8c41d5f0140..bfb25d67f67 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -72,7 +72,7 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { } test( - 'previews a video from the keyboard and cleans it up with its attachment', + 'previews a video from the keyboard and restores focus on Escape', { tag: '@ui' }, async ({ page }) => { const agentPanel = new AgentPanel(page) From d47e90bf9cb75cd742f5a372510c80d05da6f3e5 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:11:29 -0700 Subject: [PATCH 03/11] test(agent): query preview trigger semantically Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045459 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index bfb25d67f67..5141868a522 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -83,9 +83,7 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { await assets.assetCards.first().dragTo(agentPanel.root) const chip = agentPanel.attachmentChip(ASSET_NAME) - const trigger = chip.getByRole('button', { - name: `Preview ${ASSET_NAME}` - }) + const trigger = chip.getByRole('button', { name: ASSET_NAME }) const poster = trigger.getByRole('img', { name: ASSET_NAME }) await expect(poster).toBeVisible() await expect(poster).toHaveAttribute('src', /^blob:/) From 2dff9d97179244a8911639a1889ceb2549b5a661 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:11:41 -0700 Subject: [PATCH 04/11] test(agent): prove generated poster decodes Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045468 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 5141868a522..d44b7d7b578 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -87,6 +87,11 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { const poster = trigger.getByRole('img', { name: ASSET_NAME }) await expect(poster).toBeVisible() await expect(poster).toHaveAttribute('src', /^blob:/) + await expect + .poll(() => + poster.evaluate((image: HTMLImageElement) => image.naturalWidth) + ) + .toBeGreaterThan(0) await trigger.focus() await page.keyboard.press('Enter') From 1973e2a9b8af285cba8fe473361de12f422842e8 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:11:55 -0700 Subject: [PATCH 05/11] test(agent): open preview through trigger Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045489 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index d44b7d7b578..890196a9904 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -93,8 +93,7 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { ) .toBeGreaterThan(0) - await trigger.focus() - await page.keyboard.press('Enter') + await trigger.press('Enter') const player = page .getByLabel(ASSET_NAME, { exact: true }) From e82b395dada25d00f7319089b78598f9341b52fa Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:12:11 -0700 Subject: [PATCH 06/11] test(agent): centralize preview player locator Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045509 --- browser_tests/fixtures/components/AgentPanel.ts | 6 ++++++ browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/browser_tests/fixtures/components/AgentPanel.ts b/browser_tests/fixtures/components/AgentPanel.ts index 2cf1ba647a1..9b2388473f6 100644 --- a/browser_tests/fixtures/components/AgentPanel.ts +++ b/browser_tests/fixtures/components/AgentPanel.ts @@ -139,6 +139,12 @@ export class AgentPanel { ) } + attachmentPreviewPlayer(name: string): Locator { + return this.page + .getByLabel(name, { exact: true }) + .and(this.page.locator('video, audio')) + } + async open(timeout?: number): Promise { if (await this.root.isVisible()) return this.root diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 890196a9904..76c065a4ce8 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -95,9 +95,7 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { await trigger.press('Enter') - const player = page - .getByLabel(ASSET_NAME, { exact: true }) - .and(page.locator('video')) + const player = agentPanel.attachmentPreviewPlayer(ASSET_NAME) await expect(player).toBeVisible() await expect(player).toHaveAttribute('controls', '') await expect(player).toHaveAttribute('poster', /^blob:/) From df8d66ac7a7d37e0dde59cbb1dc0e84fbe63ed10 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:12:22 -0700 Subject: [PATCH 07/11] test(agent): keep browser-only preview assertions Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045520 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 76c065a4ce8..965c8b2db77 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -97,8 +97,6 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { const player = agentPanel.attachmentPreviewPlayer(ASSET_NAME) await expect(player).toBeVisible() - await expect(player).toHaveAttribute('controls', '') - await expect(player).toHaveAttribute('poster', /^blob:/) await expect(player).toBeFocused() await page.keyboard.press('Escape') From afd513dde8b72ca247f1e221df16fae9f1539f4d Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:12:36 -0700 Subject: [PATCH 08/11] test(agent): pin closed preview aria state at component level Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045533 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 1 - .../agent/components/agent/composer/AttachmentChip.test.ts | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 965c8b2db77..bad5c4fac96 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -101,7 +101,6 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { await page.keyboard.press('Escape') await expect(player).toHaveCount(0) - await expect(trigger).toHaveAttribute('aria-expanded', 'false') await expect(trigger).toBeFocused() await page.keyboard.press('Enter') diff --git a/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts b/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts index 749e2cbd623..f9d1503895b 100644 --- a/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts +++ b/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts @@ -63,6 +63,7 @@ describe('AttachmentChip', () => { await user.keyboard('{Escape}') await waitFor(() => expect(player).not.toBeInTheDocument()) await waitFor(() => expect(trigger).toHaveFocus()) + expect(trigger).toHaveAttribute('aria-expanded', 'false') expect(pause).toHaveBeenCalledOnce() await user.keyboard(key) expect(await screen.findByLabelText(name, { selector })).toHaveAttribute( From c69255a96cb26afcbd737b24602e4bec7299a321 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:13:09 -0700 Subject: [PATCH 09/11] test(agent): drop vacuous removal cleanup phase Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4210045541 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index bad5c4fac96..095953bcad9 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -102,14 +102,6 @@ test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { await page.keyboard.press('Escape') await expect(player).toHaveCount(0) await expect(trigger).toBeFocused() - - await page.keyboard.press('Enter') - await expect(player).toBeVisible() - await chip.hover() - await chip.getByRole('button', { name: 'Remove' }).click() - - await expect(chip).toHaveCount(0) - await expect(player).toHaveCount(0) } ) From 27a1d3a5255b241aef0d147c53b7d66c39559d7d Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:13:26 -0700 Subject: [PATCH 10/11] docs(agent): include media preview coverage in spec header Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#pullrequestreview-5446079866 --- browser_tests/tests/agent/agentComposerAssetDrop.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts index 095953bcad9..19cf59fd8e7 100644 --- a/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts +++ b/browser_tests/tests/agent/agentComposerAssetDrop.spec.ts @@ -18,7 +18,8 @@ import { assetPath } from '@e2e/fixtures/utils/paths' // The drop side accepts a drop purely on `dataTransfer.types` containing // `application/x-comfy-asset-info` (`AgentPanelRoot` `isAssetDrag`), so it is // view-agnostic by construction; what these cases pin is that every view mode -// actually publishes that payload, and that the chip names the asset dragged. +// actually publishes that payload, that the chip names the asset dragged, and +// that a dropped MP4's chip previews it with a generated poster. const ASSET_NAME = AGENT_VIDEO_ASSET.name test.describe('Agent composer asset drop', { tag: '@cloud' }, () => { From 15035b2862797a17fc1636916bb459564f03e6c4 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Wed, 7 Oct 2026 13:39:35 -0700 Subject: [PATCH 11/11] test(agent): prove preview expanded state Addresses https://github.com/Comfy-Org/ComfyUI_frontend/pull/20404#discussion_r4211579888 --- .../agent/components/agent/composer/AttachmentChip.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts b/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts index f9d1503895b..083721062f2 100644 --- a/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts +++ b/src/workbench/extensions/agent/components/agent/composer/AttachmentChip.test.ts @@ -54,6 +54,9 @@ describe('AttachmentChip', () => { expect(trigger).toHaveFocus() await user.keyboard(key) expect(await screen.findByRole('dialog', { name })).toBeVisible() + await waitFor(() => + expect(trigger).toHaveAttribute('aria-expanded', 'true') + ) const player = screen.getByLabelText(name, { selector }) assert.instanceOf(player, HTMLMediaElement) await waitFor(() => expect(player).toHaveFocus())