From ffb7f47a72220b61406370b74e90267892b0c0f0 Mon Sep 17 00:00:00 2001 From: glary-bot Date: Mon, 5 Oct 2026 01:12:37 +0000 Subject: [PATCH] test(agent): pin that capped attachment chips stay reachable The bulk-attachment cap from #20110 keeps Send on screen, but nothing pinned that the chips it hides remain reachable. Substituting overflow-hidden for overflow-y-auto strands 32 of the 36 chips and still passes every assertion in this spec, so scroll to the last chip instead of trusting the cap alone. --- .../agent/agentBulkAttachmentComposer.spec.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/browser_tests/tests/agent/agentBulkAttachmentComposer.spec.ts b/browser_tests/tests/agent/agentBulkAttachmentComposer.spec.ts index 75b5cef06f3..8e18cb97743 100644 --- a/browser_tests/tests/agent/agentBulkAttachmentComposer.spec.ts +++ b/browser_tests/tests/agent/agentBulkAttachmentComposer.spec.ts @@ -8,7 +8,7 @@ const ATTACHMENT_COUNT = 36 // Regression: https://linear.app/comfyorg/issue/FE-3202 test.describe('Agent composer bulk attachments', { tag: '@cloud' }, () => { - test('keeps a visible send path after attaching dozens of images', async ({ + test('keeps a visible send path and a reachable chip list after attaching dozens of images', async ({ agentPanel, comfyPage, postedMessages @@ -46,6 +46,20 @@ test.describe('Agent composer bulk attachments', { tag: '@cloud' }, () => { // a sliver is the FE-3202 symptom, and it satisfies ratio: 0. await expect(agentPanel.sendButton).toBeInViewport({ ratio: 1 }) + // The cap is only a fix if what it hides stays reachable: `overflow-hidden` + // in its place strands 32 of the 36 chips yet satisfies every other + // assertion here, so this scrolls to the last chip rather than asserting a + // class. The baseline keeps the wheel the only thing that can move the list. + const scrollTop = () => + agentPanel.composerAssetSection.evaluate((element) => element.scrollTop) + await expect.poll(scrollTop).toBe(0) + await agentPanel.composerAssetSection.hover() + await page.mouse.wheel(0, 2000) + await expect.poll(scrollTop).toBeGreaterThan(0) + await expect( + agentPanel.attachmentChip(`reference-${ATTACHMENT_COUNT}.png`) + ).toBeInViewport({ ratio: 1 }) + // Click, not Enter: the keyboard path posts even when the button has been // pushed out of reach, so only a real click proves Send is usable. await agentPanel.sendButton.click()