From 0c9b997cba16e5d39fb6baea55ac0eae63640bfb Mon Sep 17 00:00:00 2001 From: bymyself Date: Fri, 2 Oct 2026 02:47:20 +0000 Subject: [PATCH 1/2] test(agent): keep invalid placement fixture type-safe --- .../agent/experiments/freeUsePlacement.test.ts | 17 +++++++++++++---- .../agent/experiments/freeUsePlacement.ts | 2 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts b/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts index 9f9f481de84..8035e9b698e 100644 --- a/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts +++ b/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts @@ -5,11 +5,15 @@ import { remoteConfig, remoteConfigRevision } from '@/platform/remoteConfig/remoteConfig' +import type { RemoteConfig } from '@/platform/remoteConfig/types' import { useTelemetry } from '@/platform/telemetry' import { getDevOverride } from '@/utils/devFeatureFlagOverride' import { getSessionOverride } from '@/utils/sessionFeatureFlagOverride' -import { useFreeUsePlacement } from './freeUsePlacement' +import { + FREE_USE_PLACEMENT_FLAG, + useFreeUsePlacement +} from './freeUsePlacement' vi.mock(import('@/platform/remoteConfig/remoteConfig')) vi.mock(import('@/platform/telemetry')) @@ -39,15 +43,20 @@ describe('useFreeUsePlacement', () => { }) }) - it.for([undefined, 'unknown'])('keeps control for %s', async (value) => { - Reflect.set(remoteConfig.value, 'agent-free-use-message-placement', value) + it.for([undefined, 'unknown'])('keeps control for %s', (value) => { + const config: RemoteConfig = {} + Object.defineProperty(config, FREE_USE_PLACEMENT_FLAG, { + enumerable: true, + value + }) + remoteConfig.value = config authenticatedRemoteConfigState.value = 'authenticated' const { variant } = useFreeUsePlacement() expect(variant.value).toBe('control') expect(useTelemetry()?.trackAgentFreeUseExposure).toHaveBeenCalledWith({ placement: 'control', - '$feature/agent-free-use-message-placement': 'control' + [`$feature/${FREE_USE_PLACEMENT_FLAG}`]: 'control' }) }) diff --git a/src/workbench/extensions/agent/experiments/freeUsePlacement.ts b/src/workbench/extensions/agent/experiments/freeUsePlacement.ts index 84e4ec988a2..4460acc7913 100644 --- a/src/workbench/extensions/agent/experiments/freeUsePlacement.ts +++ b/src/workbench/extensions/agent/experiments/freeUsePlacement.ts @@ -10,7 +10,7 @@ import type { AgentFreeUsePlacement } from '@/platform/telemetry/types' import { getDevOverride } from '@/utils/devFeatureFlagOverride' import { getSessionOverride } from '@/utils/sessionFeatureFlagOverride' -const FREE_USE_PLACEMENT_FLAG = 'agent-free-use-message-placement' +export const FREE_USE_PLACEMENT_FLAG = 'agent-free-use-message-placement' export const FREE_USE_PLACEMENTS = [ 'control', From dc0c398d39b9a578182de2f757f2259a17ac3db7 Mon Sep 17 00:00:00 2001 From: bymyself Date: Fri, 2 Oct 2026 03:00:19 +0000 Subject: [PATCH 2/2] test(agent): distinguish absent placement flag --- .../agent/experiments/freeUsePlacement.test.ts | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts b/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts index 8035e9b698e..72efeca3a91 100644 --- a/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts +++ b/src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts @@ -43,11 +43,23 @@ describe('useFreeUsePlacement', () => { }) }) - it.for([undefined, 'unknown'])('keeps control for %s', (value) => { + it('keeps control when the flag is absent', () => { + remoteConfig.value = {} + authenticatedRemoteConfigState.value = 'authenticated' + const { variant } = useFreeUsePlacement() + + expect(variant.value).toBe('control') + expect(useTelemetry()?.trackAgentFreeUseExposure).toHaveBeenCalledWith({ + placement: 'control', + [`$feature/${FREE_USE_PLACEMENT_FLAG}`]: 'control' + }) + }) + + it('keeps control for an unknown flag value', () => { const config: RemoteConfig = {} Object.defineProperty(config, FREE_USE_PLACEMENT_FLAG, { enumerable: true, - value + value: 'unknown' }) remoteConfig.value = config authenticatedRemoteConfigState.value = 'authenticated'