From 18f510ccb025c42b3b0c7fe4128cdddb4e0d92cd Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 30 Sep 2026 23:11:48 +0000 Subject: [PATCH 1/7] refactor: remove workflow_sharing_enabled flag gate (FE-3094) --- .../tests/dialogs/shareWorkflowDialog.spec.ts | 17 ----------------- src/components/TopMenuSection.vue | 6 ++---- src/composables/__mocks__/useFeatureFlags.ts | 1 - src/composables/useFeatureFlags.test.ts | 4 ++-- src/composables/useFeatureFlags.ts | 12 ------------ src/composables/useWorkflowActionsMenu.ts | 2 +- src/platform/remoteConfig/types.ts | 1 - src/storybook/mocks/useFeatureFlags.ts | 1 - 8 files changed, 5 insertions(+), 39 deletions(-) diff --git a/browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts b/browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts index cbff04b30c0..dd54e9691d8 100644 --- a/browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts +++ b/browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts @@ -31,22 +31,6 @@ const PRIVATE_ASSET: AssetInfo = { const test = comfyPageFixture -/** - * Enable the workflow_sharing_enabled server feature flag at runtime. - * FeatureFlagHelper.mockServerFeatures() intercepts `/api/features` but the - * flags are already loaded by the time tests run, so direct mutation of the - * reactive ref is the only reliable approach for server-side flags. - */ -async function enableWorkflowSharing(page: Page): Promise { - await page.evaluate(() => { - const api = window.app!.api - api.serverFeatureFlags.value = { - ...api.serverFeatureFlags.value, - workflow_sharing_enabled: true - } - }) -} - async function mockPublishStatus( page: Page, record: PublishRecord | null @@ -150,7 +134,6 @@ async function saveAndWait( } async function openShareDialog(page: Page): Promise { - await enableWorkflowSharing(page) await dismissOverlays(page) const shareButton = page.getByRole('button', { name: 'Share workflow' }) await shareButton.click() diff --git a/src/components/TopMenuSection.vue b/src/components/TopMenuSection.vue index 197c025df34..2fd5658b007 100644 --- a/src/components/TopMenuSection.vue +++ b/src/components/TopMenuSection.vue @@ -86,7 +86,7 @@ />