From 272811eb2c8027894260b6f91efbef715723bd47 Mon Sep 17 00:00:00 2001 From: Mariana Martinho Date: Mon, 28 Sep 2026 23:39:38 +0000 Subject: [PATCH 01/36] fix(website): a running take says its own name, without a bar that cannot move "Rendering take A" reads as an instruction in English rather than as the name of a take. The frame that is running now answers to what the buttons under the stage already call it, from the one label both share. The strip under the frame was not progress: a third of its width pulsing in place, because no model reports how far along a take is. The spinner and the clock beside the name say the same thing without implying the run had stalled. --- .../cinematic-studio/CinematicSequence.vue | 2 +- .../CinematicTakeProgress.test.ts | 29 +++++++++++++++++++ .../CinematicTakeProgress.vue | 15 ++++------ .../workshop/cinematic-studio/copy.test.ts | 6 ++-- .../src/lib/workshop/cinematic-studio/copy.ts | 6 +--- 5 files changed, 40 insertions(+), 18 deletions(-) create mode 100644 apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.test.ts diff --git a/apps/website/src/components/workshop/cinematic-studio/CinematicSequence.vue b/apps/website/src/components/workshop/cinematic-studio/CinematicSequence.vue index 6d652a276a5..86c7ebce97d 100644 --- a/apps/website/src/components/workshop/cinematic-studio/CinematicSequence.vue +++ b/apps/website/src/components/workshop/cinematic-studio/CinematicSequence.vue @@ -72,7 +72,7 @@ const thumbs = computed(() => take, look, current, - label: tc('cinematic.stage.thumb', locale, { + label: tc('cinematic.stage.takeName', locale, { shot: take.shot, take: take.letter }), diff --git a/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.test.ts b/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.test.ts new file mode 100644 index 00000000000..6ff45fab336 --- /dev/null +++ b/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.test.ts @@ -0,0 +1,29 @@ +import { render, screen } from '@testing-library/vue' +import { describe, expect, it } from 'vitest' + +import type { Take } from '../../../lib/workshop/cinematic-studio/reel' +import CinematicTakeProgress from './CinematicTakeProgress.vue' + +const take: Take = { + id: 'take-1', + shot: 1, + letter: 'A', + prompt: 'a courtyard at dusk', + modelSlug: 'bfl--flux-2-max--generate-images', + aspect: '16:9', + startedAt: Date.now(), + status: 'rendering' +} + +describe('CinematicTakeProgress', () => { + // The buttons under the stage call this frame "Shot 1, take A". The frame + // that is running has to answer to the same name, and "Rendering take A" + // read as an instruction rather than as the name of a take. + it('calls the running take what the take buttons call it', () => { + render(CinematicTakeProgress, { props: { take } }) + + const caption = screen.getByRole('status') + expect(caption).toHaveTextContent('Shot 1, take A') + expect(caption).toHaveTextContent('0:00') + }) +}) diff --git a/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.vue b/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.vue index be459e9a17e..5ba3d6555b5 100644 --- a/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.vue +++ b/apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.vue @@ -40,17 +40,14 @@ const elapsed = computed(() => Math.max(0, now.value - take.startedAt)) class="size-4 text-primary-comfy-yellow motion-safe:animate-spin" aria-hidden="true" /> - {{ tc('cinematic.stage.renderingTake', locale, { take: take.letter }) }} + {{ + tc('cinematic.stage.takeName', locale, { + shot: take.shot, + take: take.letter + }) + }} {{ formatElapsed(elapsed) }} -