diff --git a/browser_tests/fixtures/agentPanelFixture.ts b/browser_tests/fixtures/agentPanelFixture.ts index 746b20d127d..db686ddab1c 100644 --- a/browser_tests/fixtures/agentPanelFixture.ts +++ b/browser_tests/fixtures/agentPanelFixture.ts @@ -23,13 +23,9 @@ const APP_URL = process.env.PLAYWRIGHT_TEST_URL || 'http://localhost:8188' function agentFeatures(agentFlag: boolean): RemoteConfig { return { + 'agent-in-app-experience': agentFlag, posthog_project_token: 'phc_e2e_agent_panel', - posthog_config: { - advanced_disable_flags: true, - bootstrap: { - featureFlags: { 'agent-in-app-experience': agentFlag } - } - } + posthog_config: { advanced_disable_flags: true } } } diff --git a/browser_tests/tests/agent/agentPanelMocks.ts b/browser_tests/tests/agent/agentPanelMocks.ts index c6611788907..ad79893a35b 100644 --- a/browser_tests/tests/agent/agentPanelMocks.ts +++ b/browser_tests/tests/agent/agentPanelMocks.ts @@ -143,13 +143,9 @@ export const MESSAGE_DONE_EVENT: AgentWsEvent = { function agentFeatures(agentFlag: boolean): RemoteConfig { return { + 'agent-in-app-experience': agentFlag, posthog_project_token: 'phc_e2e_agent_panel', - posthog_config: { - advanced_disable_flags: true, - bootstrap: { - featureFlags: { 'agent-in-app-experience': agentFlag } - } - } + posthog_config: { advanced_disable_flags: true } } } diff --git a/browser_tests/tests/agent/agentPaywallSubscribe.spec.ts b/browser_tests/tests/agent/agentPaywallSubscribe.spec.ts index 1f620a59c24..11127971ce0 100644 --- a/browser_tests/tests/agent/agentPaywallSubscribe.spec.ts +++ b/browser_tests/tests/agent/agentPaywallSubscribe.spec.ts @@ -43,11 +43,9 @@ async function reconfigureBilling( { subscriptionRequired }: { subscriptionRequired: boolean } ): Promise { const features: RemoteConfig = { + 'agent-in-app-experience': true, posthog_project_token: 'phc_e2e_agent_panel', - posthog_config: { - advanced_disable_flags: true, - bootstrap: { featureFlags: { 'agent-in-app-experience': true } } - }, + posthog_config: { advanced_disable_flags: true }, subscription_required: subscriptionRequired } await page.route('**/api/features', (route) => diff --git a/docs/FEATURE_FLAGS.md b/docs/FEATURE_FLAGS.md index d5934c455c1..35219f0dfa4 100644 --- a/docs/FEATURE_FLAGS.md +++ b/docs/FEATURE_FLAGS.md @@ -129,10 +129,8 @@ classDiagram } class useFeatureFlags { - +serverSupports(name) boolean - +getServerFeature(name, default) T - +createServerFeatureFlag(name) ComputedRef - +extension: ExtensionFlags + +flags: Readonly~ReactiveFlags~ + +featureFlag(path, default) ComputedRef } class VueComponent { @@ -209,8 +207,8 @@ SERVER_FEATURE_FLAGS = { **Frontend Usage:** ```typescript -const { getServerFeature } = useFeatureFlags() -const maxUploadSize = getServerFeature('max_upload_size', 100 * 1024 * 1024) // Default 100MB +const { flags } = useFeatureFlags() +const maxUploadSize = flags.maxUploadSize ``` ## Using Feature Flags @@ -231,25 +229,42 @@ const maxSize = api.getServerFeature('max_upload_size', 100 * 1024 * 1024) 2. **Using the composable (recommended for reactive components):** +`useFeatureFlags()` returns `{ flags, featureFlag }`. + +`flags` is a readonly reactive object of named, camelCase properties. Most +correspond to an entry in the `ServerFeatureFlag` enum; a few resolve a bare +string path instead (`assetsEnabled` reads `'assets'`). Each is a getter, so +reading it always reflects the current value and tracks reactively: + ```typescript -const { serverSupports, getServerFeature, extension } = useFeatureFlags() +const { flags } = useFeatureFlags() // Check feature support -if (serverSupports('supports_preview_metadata')) { +if (flags.supportsPreviewMetadata) { // Use enhanced previews } -// Use reactive convenience properties (automatically update if flags change) -if (extension.manager.supportsV4.value) { +// Nested extension flags are exposed as named properties too +if (flags.supportsManagerV4) { // Use V4 manager API } ``` +`featureFlag(path, defaultValue)` returns a `ComputedRef` for a flag that has no +named property yet. It accepts dot-separated paths for nested flags: + +```typescript +const { featureFlag } = useFeatureFlags() + +const customFlag = featureFlag('extension.custom.nested.feature', false) +console.log(customFlag.value) +``` + 3. **Reactive usage in templates:** ```vue