From 24f14634d4943126d5e32ddd3daa876b021d74fa Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Tue, 22 Sep 2026 17:08:29 -0700 Subject: [PATCH 1/3] test(agent): separate absent subscription sequence fixture --- .../agent/crdt/docFrameClient.numeric.test.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts index 721b1d9afcc..b4a2069b9c9 100644 --- a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts +++ b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts @@ -24,7 +24,7 @@ const awarenessFrame = (expiresAt: unknown) => ({ const sequencedFrame = ( type: 'doc_subscribed' | 'doc_reset', - seq?: unknown + seq: unknown ) => ({ type, data: { @@ -35,6 +35,11 @@ const sequencedFrame = ( } }) +const unsequencedSubscribedFrame = () => ({ + type: 'doc_subscribed', + data: { v: 1, workflow_id: 'wf-1', ok: true } +}) + const docOpsResultFrame = (seq?: unknown) => ({ type: 'doc_ops_result', data: { @@ -90,10 +95,12 @@ describe('doc frame numeric domains', () => { ) it('accepts doc_subscribed without seq', () => { - expect(parseServerDocFrame(sequencedFrame('doc_subscribed'))).toEqual({ + const frame = parseServerDocFrame(unsequencedSubscribedFrame()) + expect(frame).toEqual({ type: 'doc_subscribed', data: { workflowId: 'wf-1', ok: true } }) + expect(frame?.data).not.toHaveProperty('seq') }) it.for([-1, 1.5, Number.POSITIVE_INFINITY, Number.NaN, '1'])( From dbe5b3ca346533a0c37b10b2c88a8a22d55d4893 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 25 Sep 2026 22:12:43 -0700 Subject: [PATCH 2/3] test(agent): drop the now-dead seq conditional spread `seq` became a required parameter of `sequencedFrame`, so the `seq !== undefined` branch can no longer be taken: every caller passes a defined value. Leaving it in implies a caller that omits it, which is exactly the implicit-omission coupling this PR removes. Addresses review feedback on PR #18486 (review 5324690344). --- .../extensions/agent/crdt/docFrameClient.numeric.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts index b4a2069b9c9..f731e6c5b9f 100644 --- a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts +++ b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts @@ -30,7 +30,7 @@ const sequencedFrame = ( data: { v: 1, workflow_id: 'wf-1', - ...(seq !== undefined && { seq }), + seq, ...(type === 'doc_subscribed' && { ok: true }) } }) From 781e7a4bb1f2cf14f34815d8536a693cc3bcffe9 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 25 Sep 2026 22:16:22 -0700 Subject: [PATCH 3/3] test(agent): declare the unsequenced fixture as a function Repository guidance prefers a function declaration where a helper captures no state and needs no expression semantics. Addresses DrJKL's P3 nit on PR #18486 (discussion r4109490223). --- .../agent/crdt/docFrameClient.numeric.test.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts index f731e6c5b9f..609a7ae648a 100644 --- a/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts +++ b/src/workbench/extensions/agent/crdt/docFrameClient.numeric.test.ts @@ -35,10 +35,12 @@ const sequencedFrame = ( } }) -const unsequencedSubscribedFrame = () => ({ - type: 'doc_subscribed', - data: { v: 1, workflow_id: 'wf-1', ok: true } -}) +function unsequencedSubscribedFrame() { + return { + type: 'doc_subscribed', + data: { v: 1, workflow_id: 'wf-1', ok: true } + } +} const docOpsResultFrame = (seq?: unknown) => ({ type: 'doc_ops_result',