From 2870d8a8d746cbfdbbee85ec5fc7a173038cd563 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Wed, 16 Sep 2026 16:57:55 +0000 Subject: [PATCH 1/2] FE-2218 ci: self-test the billing-web unit workflow and give its flag a status MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two follow-ups from the #17827 review. `app_billing_web` did not list `ci-billing-web-unit.yaml`, so a PR that only touches the workflow left `billing-web-unit` skipped and `billing-web-unit-gate` passing through its skip branch. #17827 itself merged that way: run 35103654481 never executed the job it added. Listing the workflow in its own filter makes it self-testing on pull requests. The merge queue already ran it unconditionally, because every filter output defaults to 'true' off `pull_request`. `coverage.status` had no `project.billing-web` or `patch.billing-web`, so the upload arrived with no dedicated status while the website flag has both. Both now mirror the website entries: scoped to `apps/billing-web/src/**`, informational, and `flag_coverage_not_uploaded_behavior: pass`. The third review point — renaming the flag to `billing-web-unit` to match `website-unit` — is left out. It has to change `flags:` in the workflow and both new status entries in one commit, or the upload and the config disagree, and the token available here cannot push `.github/workflows/`. --- .github/actions/changes-filter/action.yaml | 3 ++- codecov.yml | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/.github/actions/changes-filter/action.yaml b/.github/actions/changes-filter/action.yaml index b14ee5da62f..710626934c2 100644 --- a/.github/actions/changes-filter/action.yaml +++ b/.github/actions/changes-filter/action.yaml @@ -44,7 +44,7 @@ outputs: description: 'Shared deps, `apps/website/**`, or website e2e workflow support changed.' value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.app_website == 'true' }} app-billing-web-changes: - description: 'Shared deps or `apps/billing-web/**` changed.' + description: 'Shared deps, `apps/billing-web/**`, or the billing-web unit workflow changed.' value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.app_billing_web == 'true' }} app-frontend-changes: description: 'Shared deps or `src/**` changed.' @@ -78,6 +78,7 @@ runs: - 'scripts/cicd/check-website-e2e-result.sh' app_billing_web: - 'apps/billing-web/**' + - '.github/workflows/ci-billing-web-unit.yaml' app_frontend: - 'src/**' packages: diff --git a/codecov.yml b/codecov.yml index 28b743d5a61..12ed900d30b 100644 --- a/codecov.yml +++ b/codecov.yml @@ -16,6 +16,16 @@ coverage: - apps/website/src/** flag_coverage_not_uploaded_behavior: pass + billing-web: + target: auto + threshold: '1%' + informational: true + flags: + - billing-web + paths: + - apps/billing-web/src/** + flag_coverage_not_uploaded_behavior: pass + patch: default: informational: true @@ -31,6 +41,17 @@ coverage: - apps/website/src/** flag_coverage_not_uploaded_behavior: pass + # Likewise for billing-web. + billing-web: + target: '80%' + threshold: '0%' + informational: true + flags: + - billing-web + paths: + - apps/billing-web/src/** + flag_coverage_not_uploaded_behavior: pass + # Coverage is instrumented over src/** only (see `coverage.include` in # vite.config.mts), so build and developer tooling has no coverage data to # report. Without this, changing a file under tools/ counts every one of its @@ -61,6 +82,7 @@ flags: paths: - apps/website/src/** carryforward: false + # Likewise for billing-web. billing-web: paths: - apps/billing-web/src/** From 089a852bfc35f0c40e0cadfa2a60957791e6f1d6 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Wed, 16 Sep 2026 14:14:14 -0400 Subject: [PATCH 2/2] ci: rename the billing-web codecov flag to billing-web-unit (FE-2218) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The third review point on #17827: the flag was `billing-web` while the website's is `website-unit`, so the two apps named the same kind of upload differently. Renaming now, before more history accrues under the old name — a later rename discards the flag's coverage history. One commit on purpose. The name lives in three places: `flags:` on the codecov upload step in `ci-billing-web-unit.yaml`, `flags.billing-web-unit` in `codecov.yml`, and the `flags:` list inside each of the two statuses this PR added. Split across commits, the upload would carry one name while the config expected the other, and the statuses would silently receive no data for every commit in between. The two status keys move to `billing-web-unit` as well, so the check names match the flag they report on. --- .github/workflows/ci-billing-web-unit.yaml | 2 +- codecov.yml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-billing-web-unit.yaml b/.github/workflows/ci-billing-web-unit.yaml index bcebf93838d..fa7c8c7dbf0 100644 --- a/.github/workflows/ci-billing-web-unit.yaml +++ b/.github/workflows/ci-billing-web-unit.yaml @@ -48,7 +48,7 @@ jobs: working-directory: ./apps/billing-web files: ./coverage/lcov.info disable_search: true - flags: billing-web + flags: billing-web-unit # Re-root LCOV paths to prevent collisions with root-app coverage. network_prefix: apps/billing-web/ token: ${{ secrets.CODECOV_TOKEN }} diff --git a/codecov.yml b/codecov.yml index 12ed900d30b..1215ded430e 100644 --- a/codecov.yml +++ b/codecov.yml @@ -21,7 +21,7 @@ coverage: threshold: '1%' informational: true flags: - - billing-web + - billing-web-unit paths: - apps/billing-web/src/** flag_coverage_not_uploaded_behavior: pass @@ -47,7 +47,7 @@ coverage: threshold: '0%' informational: true flags: - - billing-web + - billing-web-unit paths: - apps/billing-web/src/** flag_coverage_not_uploaded_behavior: pass @@ -83,7 +83,7 @@ flags: - apps/website/src/** carryforward: false # Likewise for billing-web. - billing-web: + billing-web-unit: paths: - apps/billing-web/src/** carryforward: false