From 9df88742c6415ec528800b73e28b56e7442316f0 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Sat, 12 Sep 2026 20:39:46 -0700 Subject: [PATCH 1/2] Report insertWorkflow abort via reportError telemetry When insertWorkflow detects that the canvas or graph was replaced while the workflow loaded, it silently returned. Emit a soft-assert warning through reportError (error_type=workflow_insert_aborted_canvas_changed, operation=insert, outcome=degraded) so the abort is observable in Sentry, with replacement_kind=canvas|graph as context. --- .../core/services/workflowService.test.ts | 42 ++++++++++++------- .../workflow/core/services/workflowService.ts | 19 ++++++++- 2 files changed, 45 insertions(+), 16 deletions(-) diff --git a/src/platform/workflow/core/services/workflowService.test.ts b/src/platform/workflow/core/services/workflowService.test.ts index d4ea904baec..79883fc3e4e 100644 --- a/src/platform/workflow/core/services/workflowService.test.ts +++ b/src/platform/workflow/core/services/workflowService.test.ts @@ -1662,7 +1662,7 @@ describe('useWorkflowService', () => { ) } as unknown as ComfyWorkflow - const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {}) + reportErrorMock.mockClear() try { const pending = useWorkflowService().insertWorkflow(workflow) @@ -1675,13 +1675,20 @@ describe('useWorkflowService', () => { expect(deserialize).not.toHaveBeenCalled() expect(app.canvas._deserializeItems).not.toHaveBeenCalled() - expect(warnSpy).toHaveBeenCalledWith( - expect.stringContaining( - 'insertWorkflow aborted: canvas or graph was replaced' - ) - ) + expect(reportErrorMock).toHaveBeenCalledTimes(1) + expect(reportErrorMock).toHaveBeenCalledWith(expect.any(Error), { + errorType: 'workflow_insert_aborted_canvas_changed', + level: 'warning', + tags: { + failure_kind: 'degraded', + feature_area: 'workflow', + operation: 'insert', + outcome: 'degraded', + assert_mode: 'soft' + }, + context: { replacement_kind: 'canvas' } + }) } finally { - warnSpy.mockRestore() Reflect.set(app, 'canvas', originalCanvas) Reflect.set(originalCanvas, 'graph', priorGraph) Reflect.set(originalCanvas, '_deserializeItems', priorDeserialize) @@ -1706,7 +1713,7 @@ describe('useWorkflowService', () => { ) } as unknown as ComfyWorkflow - const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {}) + reportErrorMock.mockClear() try { const pending = useWorkflowService().insertWorkflow(workflow) @@ -1715,13 +1722,20 @@ describe('useWorkflowService', () => { await pending expect(deserialize).not.toHaveBeenCalled() - expect(warnSpy).toHaveBeenCalledWith( - expect.stringContaining( - 'insertWorkflow aborted: canvas or graph was replaced' - ) - ) + expect(reportErrorMock).toHaveBeenCalledTimes(1) + expect(reportErrorMock).toHaveBeenCalledWith(expect.any(Error), { + errorType: 'workflow_insert_aborted_canvas_changed', + level: 'warning', + tags: { + failure_kind: 'degraded', + feature_area: 'workflow', + operation: 'insert', + outcome: 'degraded', + assert_mode: 'soft' + }, + context: { replacement_kind: 'graph' } + }) } finally { - warnSpy.mockRestore() Reflect.set(canvas, 'graph', priorGraph) Reflect.set(canvas, '_deserializeItems', priorDeserialize) } diff --git a/src/platform/workflow/core/services/workflowService.ts b/src/platform/workflow/core/services/workflowService.ts index a72a91289cd..5c3db85b0d2 100644 --- a/src/platform/workflow/core/services/workflowService.ts +++ b/src/platform/workflow/core/services/workflowService.ts @@ -782,8 +782,23 @@ export const useWorkflowService = () => { const graph = canvas.graph const loadedWorkflow = await workflow.load() if (app.canvas !== canvas || canvas.graph !== graph) { - console.warn( - '[workflowService] insertWorkflow aborted: canvas or graph was replaced while the workflow loaded' + const replacementKind = app.canvas !== canvas ? 'canvas' : 'graph' + reportError( + new Error( + 'insertWorkflow aborted: canvas or graph was replaced while the workflow loaded' + ), + { + errorType: 'workflow_insert_aborted_canvas_changed', + level: 'warning', + tags: { + failure_kind: 'degraded', + feature_area: 'workflow', + operation: 'insert', + outcome: 'degraded', + assert_mode: 'soft' + }, + context: { replacement_kind: replacementKind } + } ) return } From 9c726748971c5bffaacf5713942639f53d4aa7a6 Mon Sep 17 00:00:00 2001 From: relaunch-lin-PM-985-c17 Date: Sun, 13 Sep 2026 07:59:00 +0000 Subject: [PATCH 2/2] test: use typed insert workflow fixtures --- .../core/services/workflowService.test.ts | 42 +++++++++---------- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/src/platform/workflow/core/services/workflowService.test.ts b/src/platform/workflow/core/services/workflowService.test.ts index 79883fc3e4e..c9bf7098a09 100644 --- a/src/platform/workflow/core/services/workflowService.test.ts +++ b/src/platform/workflow/core/services/workflowService.test.ts @@ -1625,9 +1625,7 @@ describe('useWorkflowService', () => { const deserialize = vi.fn() Reflect.set(canvas, 'graph', originalGraph) Reflect.set(canvas, '_deserializeItems', deserialize) - const workflow = { - load: vi.fn(async () => ({ initialState: { nodes: [], links: [] } })) - } as unknown as ComfyWorkflow + const workflow = createModeTestWorkflow() try { const options = { position: [120, 240] as [number, number] } @@ -1652,15 +1650,14 @@ describe('useWorkflowService', () => { const deserialize = vi.fn() Reflect.set(originalCanvas, 'graph', originalGraph) Reflect.set(originalCanvas, '_deserializeItems', deserialize) - let finishLoad: (value: unknown) => void = () => {} - const workflow = { - load: vi.fn( - () => - new Promise((resolve) => { - finishLoad = resolve - }) - ) - } as unknown as ComfyWorkflow + const workflow = createModeTestWorkflow() + let finishLoad: (value: LoadedComfyWorkflow) => void = () => {} + vi.spyOn(workflow, 'load').mockImplementation( + () => + new Promise((resolve) => { + finishLoad = resolve + }) + ) reportErrorMock.mockClear() @@ -1670,7 +1667,7 @@ describe('useWorkflowService', () => { graph: originalGraph, _deserializeItems: vi.fn() }) - finishLoad({ initialState: { nodes: [], links: [] } }) + finishLoad(workflow) await pending expect(deserialize).not.toHaveBeenCalled() @@ -1703,22 +1700,21 @@ describe('useWorkflowService', () => { const deserialize = vi.fn() Reflect.set(canvas, 'graph', originalGraph) Reflect.set(canvas, '_deserializeItems', deserialize) - let finishLoad: (value: unknown) => void = () => {} - const workflow = { - load: vi.fn( - () => - new Promise((resolve) => { - finishLoad = resolve - }) - ) - } as unknown as ComfyWorkflow + const workflow = createModeTestWorkflow() + let finishLoad: (value: LoadedComfyWorkflow) => void = () => {} + vi.spyOn(workflow, 'load').mockImplementation( + () => + new Promise((resolve) => { + finishLoad = resolve + }) + ) reportErrorMock.mockClear() try { const pending = useWorkflowService().insertWorkflow(workflow) Reflect.set(canvas, 'graph', {}) - finishLoad({ initialState: { nodes: [], links: [] } }) + finishLoad(workflow) await pending expect(deserialize).not.toHaveBeenCalled()