From 57517a6b4a022bc8a92e35f277daf5829feaa30f Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 22:01:01 -0700 Subject: [PATCH 1/2] test(widgets): an emptied promoted text widget stays empty across a round-trip MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Clearing a promoted text widget and reloading is an ECS 1.53 plan row with no automated coverage. The nearest existing spec clears a plain widget and reopens the tab; the promoted path serializes through the subgraph host instead, where an empty string is the value most likely to be dropped as falsy. The fixture ships this widget empty on the host AND on the interior node, so asserting "empty after a round-trip" on its own is vacuous — a reset to the interior default satisfies it too. The test round-trips a non-empty value first. That serves as a control (promoted text is recorded at all) and gives the second round-trip a distinguishable wrong answer to come back as. Uses the getExportedWorkflow + loadGraphData round-trip that comboWidget.spec.ts and floatWidget.spec.ts already use for this question. --- .../widgets/widgetValuePersistence.spec.ts | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts b/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts index f975f9257fa..d39bbc6b9c7 100644 --- a/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts +++ b/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts @@ -44,5 +44,42 @@ test.describe( ) ).toHaveValue('') }) + + test('an emptied promoted text widget stays empty across a round-trip', async ({ + comfyPage + }) => { + await comfyPage.workflow.loadWorkflow( + 'subgraphs/subgraph-with-promoted-text-widget' + ) + + const promotedTextbox = () => + comfyPage.vueNodes + .getNodeLocator('11') + .getByRole('textbox', { name: 'text' }) + + async function roundTrip() { + const serialized = await comfyPage.workflow.getExportedWorkflow() + await comfyPage.workflow.loadGraphData(serialized) + await comfyPage.vueNodes.waitForNodes() + } + + // The fixture ships this widget empty on the host AND on the interior + // CLIPTextEncode, so "empty after a round-trip" is also satisfied by a + // reset to that default. Round-tripping a non-empty value first is what + // lets the second one tell the two apart: if the clear is dropped as + // falsy, the reload brings this string back instead of an empty one. + const baseline = 'promoted value that must be cleared' + await promotedTextbox().fill(baseline) + await expect(promotedTextbox()).toHaveValue(baseline) + + await roundTrip() + await expect(promotedTextbox()).toHaveValue(baseline) + + await promotedTextbox().fill('') + await expect(promotedTextbox()).toHaveValue('') + + await roundTrip() + await expect(promotedTextbox()).toHaveValue('') + }) } ) From e552e80fb00f162588f69aabf9ae77b0358f1ec2 Mon Sep 17 00:00:00 2001 From: Alexander Brown Date: Fri, 11 Sep 2026 23:00:15 -0700 Subject: [PATCH 2/2] Apply suggestion from @DrJKL --- .../tests/vueNodes/widgets/widgetValuePersistence.spec.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts b/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts index d39bbc6b9c7..d4bdba9e16c 100644 --- a/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts +++ b/browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts @@ -63,11 +63,6 @@ test.describe( await comfyPage.vueNodes.waitForNodes() } - // The fixture ships this widget empty on the host AND on the interior - // CLIPTextEncode, so "empty after a round-trip" is also satisfied by a - // reset to that default. Round-tripping a non-empty value first is what - // lets the second one tell the two apart: if the clear is dropped as - // falsy, the reload brings this string back instead of an empty one. const baseline = 'promoted value that must be cleared' await promotedTextbox().fill(baseline) await expect(promotedTextbox()).toHaveValue(baseline)