From e0ee9ea50d86bc6c12730e696ae75d8b3a86c8ef Mon Sep 17 00:00:00 2001 From: lane-materialization-kind-dropdown Date: Sat, 12 Sep 2026 04:20:15 +0000 Subject: [PATCH 1/3] fix(agent): add materialization event to dev-panel kind filter agent_node_adapters_materialized is a valid DevEventKind and is emitted by useAgentCrdtFollower.ts, but was missing from CrdtDevPanel.vue's EVENT_KINDS kind-dropdown entry set, so it could not be selected in the filter (it remained visible only in the unfiltered log). Add it to the list and cover it with a focused test. Found by the dev-panel parity audit (reports/audit/2026-09-11-dev-panel-fit-view-571.md in christian-byrne/in-app-agent-program). --- .../agent/crdt/CrdtDevPanel.test.ts | 29 ++++++++++++++++++- .../extensions/agent/crdt/CrdtDevPanel.vue | 3 +- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts index 014978abef7..768e0ee4958 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts @@ -1,5 +1,5 @@ import userEvent from '@testing-library/user-event' -import { render, screen } from '@testing-library/vue' +import { render, screen, within } from '@testing-library/vue' import { beforeEach, describe, expect, it, vi } from 'vitest' import { nextTick } from 'vue' @@ -198,6 +198,33 @@ describe('CrdtDevPanel', () => { expect(log).not.toContain('ws_out') }) + it('lists the materialization event in the kind filter and filters by it', async () => { + const user = userEvent.setup() + recordDevEvent('doc_update', { seq: 1 }, { scope: 'doc' }) + recordDevEvent( + 'agent_node_adapters_materialized', + { nodeCount: 2 }, + { scope: 'doc' } + ) + renderPanel() + + await user.click(chip()!) + await user.click(screen.getByTestId('crdt-dev-panel-tab-log')) + + const kindFilter = screen.getByTestId('crdt-dev-panel-filter') + expect( + within(kindFilter) + .getAllByRole('option') + .map((option) => option.value) + ).toContain('agent_node_adapters_materialized') + + await user.selectOptions(kindFilter, 'agent_node_adapters_materialized') + + const log = screen.getByTestId('crdt-dev-panel-log').textContent + expect(log).toContain('agent_node_adapters_materialized') + expect(log).not.toContain('doc_update') + }) + it('shows the sensitive-source opt-ins as off, and lets them be turned on', async () => { const user = userEvent.setup() renderPanel() diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue index 54a90f3392e..ed11e28f6da 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue @@ -169,7 +169,8 @@ const EVENT_KINDS: readonly DevEventKind[] = [ 'rebind', 'doc_gap', 'doc_stale', - 'frame_send_failed' + 'frame_send_failed', + 'agent_node_adapters_materialized' ] const VERDICT_TONE: Record = { From 6c93c89bd9da01215ce762f6bbdbddf013c7170b Mon Sep 17 00:00:00 2001 From: bymyself Date: Sat, 12 Sep 2026 10:35:52 +0000 Subject: [PATCH 2/3] test: query visible filtered log entries Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/17519#discussion_r3995086743 --- src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts index 768e0ee4958..825d4002b13 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts @@ -220,9 +220,11 @@ describe('CrdtDevPanel', () => { await user.selectOptions(kindFilter, 'agent_node_adapters_materialized') - const log = screen.getByTestId('crdt-dev-panel-log').textContent - expect(log).toContain('agent_node_adapters_materialized') - expect(log).not.toContain('doc_update') + const log = screen.getByTestId('crdt-dev-panel-log') + expect( + within(log).getByText('agent_node_adapters_materialized') + ).toBeInTheDocument() + expect(within(log).queryByText('doc_update')).not.toBeInTheDocument() }) it('shows the sensitive-source opt-ins as off, and lets them be turned on', async () => { From a04dc5875767d444600c8502595e70f18995ee8a Mon Sep 17 00:00:00 2001 From: Terry Jia Date: Thu, 17 Sep 2026 23:15:47 -0400 Subject: [PATCH 3/3] refactor(agent): derive DevEventKind from the dev-panel kind list --- .../extensions/agent/crdt/CrdtDevPanel.vue | 28 ++++---------- .../extensions/agent/crdt/devPanelLog.ts | 37 ++++++++++--------- 2 files changed, 27 insertions(+), 38 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue index 16a91e78217..c057dfb555b 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue @@ -37,7 +37,12 @@ import { collectCrdtDebugReport } from './crdtDebugReport' import type { CrdtLogScope, DevEvent, DevEventKind } from './devPanelLog' -import { clearDevEvents, devEvents, stringifyDevEvents } from './devPanelLog' +import { + DEV_EVENT_KINDS, + clearDevEvents, + devEvents, + stringifyDevEvents +} from './devPanelLog' import type { MergeScenario, MergeSimulation } from './mergeScenarios' import { getMergeScenarios, runScenario } from './mergeScenarios' import type { MergeTraceEntry, NodeLifecycleRow } from './mergeTrace' @@ -160,25 +165,6 @@ const STATUS_ROWS = [ const SCOPES: readonly CrdtLogScope[] = ['wire', 'doc'] -const EVENT_KINDS: readonly DevEventKind[] = [ - 'ws_out', - 'doc_subscribed', - 'doc_update', - 'doc_ops_result', - 'human_ops_settled', - 'doc_reset', - 'doc_nodes_changed', - 'schema_error', - 'reconnected', - 'subscribe_retry', - 'stale_probe', - 'rebind', - 'doc_gap', - 'doc_stale', - 'frame_send_failed', - 'agent_node_adapters_materialized' -] - const VERDICT_TONE: Record = { applied: 'text-success-background border-success-background', 'lww-dropped': 'text-muted-foreground border-border-default', @@ -837,7 +823,7 @@ function fmtTime(at: number): string { data-testid="crdt-dev-panel-filter" > - diff --git a/src/workbench/extensions/agent/crdt/devPanelLog.ts b/src/workbench/extensions/agent/crdt/devPanelLog.ts index 5b919fcaef2..04316733c1b 100644 --- a/src/workbench/extensions/agent/crdt/devPanelLog.ts +++ b/src/workbench/extensions/agent/crdt/devPanelLog.ts @@ -21,23 +21,26 @@ import type { CrdtLogLevel } from './crdtDebugGate' */ export type CrdtLogScope = 'wire' | 'doc' -export type DevEventKind = - | 'ws_out' - | 'doc_subscribed' - | 'doc_update' - | 'doc_ops_result' - | 'human_ops_settled' - | 'doc_reset' - | 'schema_error' - | 'reconnected' - | 'subscribe_retry' - | 'doc_nodes_changed' - | 'rebind' - | 'stale_probe' - | 'doc_gap' - | 'doc_stale' - | 'frame_send_failed' - | 'agent_node_adapters_materialized' +export const DEV_EVENT_KINDS = [ + 'ws_out', + 'doc_subscribed', + 'doc_update', + 'doc_ops_result', + 'human_ops_settled', + 'doc_reset', + 'doc_nodes_changed', + 'schema_error', + 'reconnected', + 'subscribe_retry', + 'stale_probe', + 'rebind', + 'doc_gap', + 'doc_stale', + 'frame_send_failed', + 'agent_node_adapters_materialized' +] as const + +export type DevEventKind = (typeof DEV_EVENT_KINDS)[number] export interface DevEvent { seq: number