From a63c200a0ae745d6d5c6410411a1ca062e5991d4 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 19:05:13 -0700 Subject: [PATCH 1/6] ci: fix CI video job for new tests --- .github/workflows/ci-tests-e2e.yaml | 154 ++++++++++++------ .../tests/agent/videoRecordingDemo.spec.ts | 11 ++ 2 files changed, 116 insertions(+), 49 deletions(-) create mode 100644 browser_tests/tests/agent/videoRecordingDemo.spec.ts diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index bd3808f4046..683d66aa4fd 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -261,7 +261,7 @@ jobs: with: source_sha: ${{ github.event.pull_request.head.sha || github.sha }} - # Records video only for spec files newly added in this PR, to keep cost bounded. + # Records video only for tests newly added in this PR, to keep cost bounded. playwright-video-new-tests: needs: setup if: ${{ github.event_name == 'pull_request' }} @@ -275,6 +275,7 @@ jobs: permissions: contents: read packages: read + pull-requests: write outputs: has-new-tests: ${{ steps.detect.outputs.has-new-tests }} steps: @@ -283,39 +284,65 @@ jobs: with: fetch-depth: 0 - - name: Detect newly-added test spec files + - name: Detect newly-added tests id: detect + env: + BASE_REF: ${{ github.base_ref }} + IS_FORK: ${{ github.event.pull_request.head.repo.fork }} run: | git config --global --add safe.directory "$GITHUB_WORKSPACE" - # HEAD is refs/pull/N/merge, so its first parent is the base tip the PR was merged - # onto. pull_request.base.sha is recorded when the PR opens and does not follow the - # base branch, so diffing against it attributes every spec the base gained since - # then to this PR. - if [ "$(git rev-parse --verify --quiet HEAD^2)" = "${{ github.event.pull_request.head.sha }}" ]; then - DIFF_RANGE="$(git rev-parse HEAD^1)..HEAD" - else - DIFF_RANGE="${{ github.event.pull_request.base.sha }}...${{ github.event.pull_request.head.sha }}" + if [ "$IS_FORK" = "true" ]; then + echo '::notice::Skipping video recording for a fork pull request.' + echo 'has-new-tests=false' >> "$GITHUB_OUTPUT" + exit 0 fi - # git diff and grep are separate statements (not piped) so a git diff failure - # (e.g. the fallback sha isn't in the local object store) surfaces as a build - # error instead of silently reading as "no new specs" and no-oping the video job. - ADDED_FILES=$(git diff --name-only --diff-filter=A "$DIFF_RANGE" -- browser_tests/tests) - NEW_FILES=$(printf '%s\n' "$ADDED_FILES" | grep '\.spec\.ts$' || true) - - if [ -z "$NEW_FILES" ]; then - echo "has-new-tests=false" >> "$GITHUB_OUTPUT" + + git fetch --no-tags origin "$BASE_REF" + DIFF_RANGE="origin/${BASE_REF}...HEAD" + NEW_FILES=$(git diff --name-only --diff-filter=AM "$DIFF_RANGE" -- 'browser_tests/**/*.spec.ts') + : > /tmp/new-test-titles.txt + : > /tmp/fallback-specs.txt + + while IFS= read -r file; do + [ -z "$file" ] && continue + ADDED_TEST_LINES=$(git diff --unified=0 "$DIFF_RANGE" -- "$file" | grep -E '^\+[[:space:]]*test(\.only|\.skip)?\(|^\+[[:space:]]*test\.describe' || true) + [ -z "$ADDED_TEST_LINES" ] && continue + + TITLES=$(printf '%s\n' "$ADDED_TEST_LINES" | sed -nE "s/^\+[[:space:]]*test(\.(only|skip))?(\.describe)?\([[:space:]]*(['\"])([^'\"]+)\4.*/\5/p") + if [ -n "$TITLES" ]; then + printf '%s\n' "$TITLES" >> /tmp/new-test-titles.txt + else + printf '%s\n' "$file" >> /tmp/fallback-specs.txt + fi + done <<< "$NEW_FILES" + + sort -u -o /tmp/new-test-titles.txt /tmp/new-test-titles.txt + sort -u -o /tmp/fallback-specs.txt /tmp/fallback-specs.txt + if [ ! -s /tmp/new-test-titles.txt ] && [ ! -s /tmp/fallback-specs.txt ]; then + echo '::notice::No newly-added Playwright tests found.' + echo 'has-new-tests=false' >> "$GITHUB_OUTPUT" else - echo "has-new-tests=true" >> "$GITHUB_OUTPUT" + echo 'has-new-tests=true' >> "$GITHUB_OUTPUT" fi { - echo "files<> "$GITHUB_OUTPUT" - echo "Newly-added spec files:" + echo 'Changed spec files:' echo "${NEW_FILES:-}" + echo 'New test titles:' + cat /tmp/new-test-titles.txt + echo 'Whole-file fallbacks:' + cat /tmp/fallback-specs.txt - name: Download built frontend if: steps.detect.outputs.has-new-tests == 'true' @@ -339,10 +366,17 @@ jobs: id: recordable env: NEW_SPEC_FILES: ${{ steps.detect.outputs.files }} + NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} + FALLBACK_SPEC_FILES: ${{ steps.detect.outputs.fallback-files }} run: | - FILES=$(echo "$NEW_SPEC_FILES" | tr '\n' ' ') + mapfile -t FILES < <(printf '%s\n%s\n' "$NEW_SPEC_FILES" "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) + GREP_ARGS=() + if [ -n "$NEW_TEST_TITLES" ]; then + GREP_PATTERN=$(printf '%s\n' "$NEW_TEST_TITLES" | sed 's/[][\\.^$*+?(){}|]/\\&/g' | paste -sd '|' -) + GREP_ARGS=("--grep=$GREP_PATTERN") + fi AUDIT_EXIT=0 - AUDIT_OUTPUT=$(pnpm exec playwright test --project=audit --list --pass-with-no-tests $FILES 2>&1) || AUDIT_EXIT=$? + AUDIT_OUTPUT=$(pnpm exec playwright test --project=audit --list --pass-with-no-tests "${GREP_ARGS[@]}" "${FILES[@]}" 2>&1) || AUDIT_EXIT=$? echo "$AUDIT_OUTPUT" if [ "$AUDIT_EXIT" -ne 0 ]; then @@ -350,29 +384,13 @@ jobs: fi if ! echo "$AUDIT_OUTPUT" | grep -Fxq 'Total: 0 tests in 0 files'; then - { - echo '## New-test video walkthrough' - echo - echo '### Cannot skip safely: audit tests have no regular CI coverage' - echo - echo 'At least one newly added test is routed to the `audit` project. Unlike the other projects excluded by Chromium, no regular CI job executes audit tests.' - echo 'This video job only records the `chromium` project, so it fails rather than allowing the PR to pass without executing the new audit test.' - echo - echo 'Detected files:' - echo '```text' - echo "$NEW_SPEC_FILES" - echo '```' - echo - echo 'Audit discovery output:' - echo '```text' - echo "$AUDIT_OUTPUT" - echo '```' - } >> "$GITHUB_STEP_SUMMARY" - exit 1 + echo '::notice::New tests are audit-routed; video recording is skipped successfully.' + echo 'has-tests=false' >> "$GITHUB_OUTPUT" + exit 0 fi LIST_EXIT=0 - LIST_OUTPUT=$(pnpm exec playwright test --project=chromium --list --pass-with-no-tests $FILES 2>&1) || LIST_EXIT=$? + LIST_OUTPUT=$(pnpm exec playwright test --project=chromium --list --pass-with-no-tests "${GREP_ARGS[@]}" "${FILES[@]}" 2>&1) || LIST_EXIT=$? echo "$LIST_OUTPUT" if [ "$LIST_EXIT" -ne 0 ]; then @@ -390,8 +408,8 @@ jobs: echo echo '### Skipped safely: no Chromium-eligible tests' echo - echo 'The workflow detected newly added Playwright spec files, but none of their tests are eligible for the `chromium` project used to record walkthroughs.' - echo 'This commonly happens when every test uses a project-routing tag excluded by Chromium: `@perf`, `@cloud`, or `@mobile`.' + echo 'The workflow detected newly added Playwright spec files, but none of their tests are eligible for the Chromium project used to record walkthroughs.' + echo 'This commonly happens when every test uses a project-routing tag excluded by Chromium: @perf, @cloud, or @mobile.' echo 'The regular project-specific E2E jobs still run these tests. This video job succeeds without creating an empty report or video artifact.' echo echo 'Detected files:' @@ -411,19 +429,57 @@ jobs: RECORD_VIDEO: 'true' SLOW_MO: '1000' NEW_SPEC_FILES: ${{ steps.detect.outputs.files }} + NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} + FALLBACK_SPEC_FILES: ${{ steps.detect.outputs.fallback-files }} run: | - FILES=$(echo "$NEW_SPEC_FILES" | tr '\n' ' ') - pnpm exec playwright test --project=chromium --timeout=60000 $FILES + mapfile -t FILES < <(printf '%s\n%s\n' "$NEW_SPEC_FILES" "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) + if [ -n "$NEW_TEST_TITLES" ]; then + GREP_PATTERN=$(printf '%s\n' "$NEW_TEST_TITLES" | sed 's/[][\\.^$*+?(){}|]/\\&/g' | paste -sd '|' -) + pnpm exec playwright test --project=chromium --timeout=60000 --grep="$GREP_PATTERN" "${FILES[@]}" + else + pnpm exec playwright test --project=chromium --timeout=60000 "${FILES[@]}" + fi - name: Upload new-test report (with embedded video) if: ${{ !cancelled() && steps.recordable.outputs.has-tests == 'true' }} uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: playwright-report-new-tests - path: ./playwright-report/ + path: | + ./playwright-report/ + ./test-results/**/*.webm retention-days: 30 if-no-files-found: warn + - name: Write video comment + if: ${{ !cancelled() && steps.recordable.outputs.has-tests == 'true' }} + env: + NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} + FALLBACK_SPEC_FILES: ${{ steps.detect.outputs.fallback-files }} + run: | + { + echo '## Playwright videos for new tests' + echo + echo "[Download the recorded videos and HTML report](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})" + echo + echo 'Recorded test titles:' + if [ -n "$NEW_TEST_TITLES" ]; then + printf '%s\n' "$NEW_TEST_TITLES" | sed 's/^/- `/' | sed 's/$/`/' + else + printf '%s\n' "$FALLBACK_SPEC_FILES" | sed 's/^/- all tests in `/' | sed 's/$/`/' + fi + } > /tmp/playwright-video-comment.md + + - name: Upsert video comment + if: ${{ !cancelled() && steps.recordable.outputs.has-tests == 'true' }} + uses: ./.github/actions/upsert-comment-section + with: + pr-number: ${{ github.event.pull_request.number }} + section-name: new-test-videos + section-content-file: /tmp/playwright-video-comment.md + comment-marker: '' + token: ${{ github.token }} + #### BEGIN Deployment and commenting (PRs with direct secret access) # when using pull_request event, we have permission to comment directly # otherwise, we use workflow_run in ci-tests-e2e-forks.yaml diff --git a/browser_tests/tests/agent/videoRecordingDemo.spec.ts b/browser_tests/tests/agent/videoRecordingDemo.spec.ts new file mode 100644 index 00000000000..b9f0ff3a6bc --- /dev/null +++ b/browser_tests/tests/agent/videoRecordingDemo.spec.ts @@ -0,0 +1,11 @@ +import { + comfyPageFixture as test, + comfyExpect as expect +} from '@e2e/fixtures/ComfyPage' + +test('opens the settings menu for the video recording demo', async ({ + comfyPage +}) => { + await comfyPage.settingDialog.open() + await expect(comfyPage.settingDialog.root).toBeVisible() +}) From e3c82d3bccb6e0d570f2616a56be4c2ad46d54f0 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 19:16:11 -0700 Subject: [PATCH 2/6] ci: run video scripts with bash --- .github/workflows/ci-tests-e2e.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 683d66aa4fd..61674516f54 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -286,6 +286,7 @@ jobs: - name: Detect newly-added tests id: detect + shell: bash env: BASE_REF: ${{ github.base_ref }} IS_FORK: ${{ github.event.pull_request.head.repo.fork }} @@ -364,6 +365,7 @@ jobs: - name: Find safely recordable new tests if: steps.detect.outputs.has-new-tests == 'true' id: recordable + shell: bash env: NEW_SPEC_FILES: ${{ steps.detect.outputs.files }} NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} @@ -425,6 +427,7 @@ jobs: - name: Run new test(s) with video recording if: steps.recordable.outputs.has-tests == 'true' + shell: bash env: RECORD_VIDEO: 'true' SLOW_MO: '1000' From 135219d42a8a4e36c828a75d24f88f55e20b8688 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 19:36:26 -0700 Subject: [PATCH 3/6] fix(ci): harden diff-based video workflow Addresses reviewer findings: https://github.com/Comfy-Org/ComfyUI_frontend/pull/17504#discussion_r3994738642 https://github.com/Comfy-Org/ComfyUI_frontend/pull/17504#discussion_r3994738647 --- .github/workflows/ci-tests-e2e-forks.yaml | 19 +++++++ .github/workflows/ci-tests-e2e.yaml | 63 +++++++---------------- 2 files changed, 38 insertions(+), 44 deletions(-) diff --git a/.github/workflows/ci-tests-e2e-forks.yaml b/.github/workflows/ci-tests-e2e-forks.yaml index ab76c583580..dc90117bd7f 100644 --- a/.github/workflows/ci-tests-e2e-forks.yaml +++ b/.github/workflows/ci-tests-e2e-forks.yaml @@ -51,6 +51,25 @@ jobs: fi echo "PR author: $PR_AUTHOR" + - name: Download new-test video comment + if: github.event.action == 'completed' + uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12 + with: + run_id: ${{ github.event.workflow_run.id }} + name: playwright-video-comment + path: video-comment + if_no_artifact_found: warn + + - name: Upsert new-test video comment + if: github.event.action == 'completed' && hashFiles('video-comment/playwright-video-comment.md') != '' + uses: ./.github/actions/upsert-comment-section + with: + pr-number: ${{ steps.pr.outputs.number }} + section-name: new-test-videos + section-content-file: video-comment/playwright-video-comment.md + comment-marker: '' + token: ${{ github.token }} + - name: Handle Test Start — upsert playwright starting section if: steps.route.outputs.handle == 'true' && github.event.action == 'requested' uses: ./.github/actions/upsert-comment-section diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 61674516f54..930bab10f25 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -275,7 +275,6 @@ jobs: permissions: contents: read packages: read - pull-requests: write outputs: has-new-tests: ${{ steps.detect.outputs.has-new-tests }} steps: @@ -300,26 +299,23 @@ jobs: git fetch --no-tags origin "$BASE_REF" DIFF_RANGE="origin/${BASE_REF}...HEAD" - NEW_FILES=$(git diff --name-only --diff-filter=AM "$DIFF_RANGE" -- 'browser_tests/**/*.spec.ts') - : > /tmp/new-test-titles.txt + NEW_FILES=$(git diff --name-only --diff-filter=AMR "$DIFF_RANGE" -- 'browser_tests/**/*.spec.ts') : > /tmp/fallback-specs.txt while IFS= read -r file; do [ -z "$file" ] && continue - ADDED_TEST_LINES=$(git diff --unified=0 "$DIFF_RANGE" -- "$file" | grep -E '^\+[[:space:]]*test(\.only|\.skip)?\(|^\+[[:space:]]*test\.describe' || true) + ADDED_TEST_LINES=$(git diff --unified=0 "$DIFF_RANGE" -- "$file" | grep -E '^\+[[:space:]]*test(\.only|\.skip|\.fail)?\(|^\+[[:space:]]*test\.describe' || true) [ -z "$ADDED_TEST_LINES" ] && continue - TITLES=$(printf '%s\n' "$ADDED_TEST_LINES" | sed -nE "s/^\+[[:space:]]*test(\.(only|skip))?(\.describe)?\([[:space:]]*(['\"])([^'\"]+)\4.*/\5/p") - if [ -n "$TITLES" ]; then - printf '%s\n' "$TITLES" >> /tmp/new-test-titles.txt - else - printf '%s\n' "$file" >> /tmp/fallback-specs.txt - fi + # A leaf title is not a stable Playwright identity: duplicate or + # short titles can select unrelated tests through --grep. Run the + # changed spec as a whole instead, which is the safe fallback for + # both parsed and unparsed added declarations. + printf '%s\n' "$file" >> /tmp/fallback-specs.txt done <<< "$NEW_FILES" - sort -u -o /tmp/new-test-titles.txt /tmp/new-test-titles.txt sort -u -o /tmp/fallback-specs.txt /tmp/fallback-specs.txt - if [ ! -s /tmp/new-test-titles.txt ] && [ ! -s /tmp/fallback-specs.txt ]; then + if [ ! -s /tmp/fallback-specs.txt ]; then echo '::notice::No newly-added Playwright tests found.' echo 'has-new-tests=false' >> "$GITHUB_OUTPUT" else @@ -331,7 +327,6 @@ jobs: echo "$NEW_FILES" echo 'EOF_NEW_SPEC_FILES' echo 'titles<}" - echo 'New test titles:' - cat /tmp/new-test-titles.txt echo 'Whole-file fallbacks:' cat /tmp/fallback-specs.txt @@ -367,18 +360,11 @@ jobs: id: recordable shell: bash env: - NEW_SPEC_FILES: ${{ steps.detect.outputs.files }} - NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} FALLBACK_SPEC_FILES: ${{ steps.detect.outputs.fallback-files }} run: | - mapfile -t FILES < <(printf '%s\n%s\n' "$NEW_SPEC_FILES" "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) - GREP_ARGS=() - if [ -n "$NEW_TEST_TITLES" ]; then - GREP_PATTERN=$(printf '%s\n' "$NEW_TEST_TITLES" | sed 's/[][\\.^$*+?(){}|]/\\&/g' | paste -sd '|' -) - GREP_ARGS=("--grep=$GREP_PATTERN") - fi + mapfile -t FILES < <(printf '%s\n' "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) AUDIT_EXIT=0 - AUDIT_OUTPUT=$(pnpm exec playwright test --project=audit --list --pass-with-no-tests "${GREP_ARGS[@]}" "${FILES[@]}" 2>&1) || AUDIT_EXIT=$? + AUDIT_OUTPUT=$(pnpm exec playwright test --project=audit --list --pass-with-no-tests "${FILES[@]}" 2>&1) || AUDIT_EXIT=$? echo "$AUDIT_OUTPUT" if [ "$AUDIT_EXIT" -ne 0 ]; then @@ -386,13 +372,11 @@ jobs: fi if ! echo "$AUDIT_OUTPUT" | grep -Fxq 'Total: 0 tests in 0 files'; then - echo '::notice::New tests are audit-routed; video recording is skipped successfully.' - echo 'has-tests=false' >> "$GITHUB_OUTPUT" - exit 0 + echo '::notice::Some new tests are audit-routed; continuing Chromium discovery.' fi LIST_EXIT=0 - LIST_OUTPUT=$(pnpm exec playwright test --project=chromium --list --pass-with-no-tests "${GREP_ARGS[@]}" "${FILES[@]}" 2>&1) || LIST_EXIT=$? + LIST_OUTPUT=$(pnpm exec playwright test --project=chromium --list --pass-with-no-tests "${FILES[@]}" 2>&1) || LIST_EXIT=$? echo "$LIST_OUTPUT" if [ "$LIST_EXIT" -ne 0 ]; then @@ -431,17 +415,10 @@ jobs: env: RECORD_VIDEO: 'true' SLOW_MO: '1000' - NEW_SPEC_FILES: ${{ steps.detect.outputs.files }} - NEW_TEST_TITLES: ${{ steps.detect.outputs.titles }} FALLBACK_SPEC_FILES: ${{ steps.detect.outputs.fallback-files }} run: | - mapfile -t FILES < <(printf '%s\n%s\n' "$NEW_SPEC_FILES" "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) - if [ -n "$NEW_TEST_TITLES" ]; then - GREP_PATTERN=$(printf '%s\n' "$NEW_TEST_TITLES" | sed 's/[][\\.^$*+?(){}|]/\\&/g' | paste -sd '|' -) - pnpm exec playwright test --project=chromium --timeout=60000 --grep="$GREP_PATTERN" "${FILES[@]}" - else - pnpm exec playwright test --project=chromium --timeout=60000 "${FILES[@]}" - fi + mapfile -t FILES < <(printf '%s\n' "$FALLBACK_SPEC_FILES" | sed '/^$/d' | sort -u) + pnpm exec playwright test --project=chromium --timeout=60000 "${FILES[@]}" - name: Upload new-test report (with embedded video) if: ${{ !cancelled() && steps.recordable.outputs.has-tests == 'true' }} @@ -473,15 +450,13 @@ jobs: fi } > /tmp/playwright-video-comment.md - - name: Upsert video comment + - name: Upload video comment if: ${{ !cancelled() && steps.recordable.outputs.has-tests == 'true' }} - uses: ./.github/actions/upsert-comment-section + uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: - pr-number: ${{ github.event.pull_request.number }} - section-name: new-test-videos - section-content-file: /tmp/playwright-video-comment.md - comment-marker: '' - token: ${{ github.token }} + name: playwright-video-comment + path: /tmp/playwright-video-comment.md + retention-days: 1 #### BEGIN Deployment and commenting (PRs with direct secret access) # when using pull_request event, we have permission to comment directly From c06c436ac497c6dbe76bdec90f1dee5ac03548a3 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 19:37:35 -0700 Subject: [PATCH 4/6] fix(ci): use fallback files in skip summary --- .github/workflows/ci-tests-e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 930bab10f25..6812aadf63d 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -400,7 +400,7 @@ jobs: echo echo 'Detected files:' echo '```text' - echo "$NEW_SPEC_FILES" + echo "$FALLBACK_SPEC_FILES" echo '```' echo echo 'Playwright discovery output:' From 36b3110c248444934ba578529432b9566b1a1f05 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 20:09:40 -0700 Subject: [PATCH 5/6] fix(ci): record assertion-only spec changes --- .github/workflows/ci-tests-e2e.yaml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci-tests-e2e.yaml b/.github/workflows/ci-tests-e2e.yaml index 6812aadf63d..828a120acbb 100644 --- a/.github/workflows/ci-tests-e2e.yaml +++ b/.github/workflows/ci-tests-e2e.yaml @@ -304,19 +304,16 @@ jobs: while IFS= read -r file; do [ -z "$file" ] && continue - ADDED_TEST_LINES=$(git diff --unified=0 "$DIFF_RANGE" -- "$file" | grep -E '^\+[[:space:]]*test(\.only|\.skip|\.fail)?\(|^\+[[:space:]]*test\.describe' || true) - [ -z "$ADDED_TEST_LINES" ] && continue - # A leaf title is not a stable Playwright identity: duplicate or - # short titles can select unrelated tests through --grep. Run the - # changed spec as a whole instead, which is the safe fallback for - # both parsed and unparsed added declarations. + # short titles can select unrelated tests through --grep. Run every + # changed spec as a whole so assertion-only improvements are also + # recorded. printf '%s\n' "$file" >> /tmp/fallback-specs.txt done <<< "$NEW_FILES" sort -u -o /tmp/fallback-specs.txt /tmp/fallback-specs.txt if [ ! -s /tmp/fallback-specs.txt ]; then - echo '::notice::No newly-added Playwright tests found.' + echo '::notice::No changed Playwright specs found.' echo 'has-new-tests=false' >> "$GITHUB_OUTPUT" else echo 'has-new-tests=true' >> "$GITHUB_OUTPUT" From a662b553495e173661cf931b6e63e91131e93aae Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Fri, 11 Sep 2026 19:58:58 -0700 Subject: [PATCH 6/6] test: verify recorded settings dialog lifecycle --- browser_tests/tests/agent/videoRecordingDemo.spec.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/browser_tests/tests/agent/videoRecordingDemo.spec.ts b/browser_tests/tests/agent/videoRecordingDemo.spec.ts index b9f0ff3a6bc..bb907a5e654 100644 --- a/browser_tests/tests/agent/videoRecordingDemo.spec.ts +++ b/browser_tests/tests/agent/videoRecordingDemo.spec.ts @@ -8,4 +8,7 @@ test('opens the settings menu for the video recording demo', async ({ }) => { await comfyPage.settingDialog.open() await expect(comfyPage.settingDialog.root).toBeVisible() + + await comfyPage.settingDialog.close() + await expect(comfyPage.settingDialog.root).toBeHidden() })