From 0f177034118d9da9a0248a53940ae9ec0eb730d4 Mon Sep 17 00:00:00 2001 From: bymyself Date: Fri, 11 Sep 2026 23:38:04 +0000 Subject: [PATCH] fix(agent): restore CRDT diagnostic detail and layer logging --- .../agent/crdt/CrdtDevPanel.test.ts | 25 ++++++++ .../extensions/agent/crdt/CrdtDevPanel.vue | 2 + .../extensions/agent/crdt/crdtLog.test.ts | 28 ++++++++- .../extensions/agent/crdt/crdtLog.ts | 5 +- .../agent/crdt/crossWorkflowPending.test.ts | 6 +- .../extensions/agent/crdt/devPanelLog.ts | 2 + .../agent/crdt/docFrameClient.test.ts | 45 ++++++++++++++ .../extensions/agent/crdt/docFrameClient.ts | 12 +++- .../ecsFollowerAdapter.integration.test.ts | 48 +++++++++++++++ .../agent/crdt/ecsFollowerAdapter.ts | 18 ++++++ .../extensions/agent/crdt/opSender.test.ts | 32 ++++++++++ .../extensions/agent/crdt/opSender.ts | 15 +++++ .../agent/crdt/useAgentCrdtFollower.test.ts | 3 +- .../agent/crdt/useAgentCrdtFollower.ts | 61 +++++++++++++------ 14 files changed, 274 insertions(+), 28 deletions(-) diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts index 014978abef7..3adb4133afe 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.test.ts @@ -198,6 +198,31 @@ describe('CrdtDevPanel', () => { expect(log).not.toContain('ws_out') }) + it('filters mint and projection diagnostics independently', async () => { + const user = userEvent.setup() + recordDevEvent('op_minted', { workflowId: 'mint-workflow' }) + recordDevEvent('doc_effects', { + workflowId: 'effect-workflow', + committed: false + }) + renderPanel() + await user.click(chip()!) + await user.click(screen.getByTestId('crdt-dev-panel-tab-log')) + + for (const [kind, absent] of [ + ['op_minted', 'doc_effects'], + ['doc_effects', 'op_minted'] + ]) { + await user.selectOptions( + screen.getByTestId('crdt-dev-panel-filter'), + kind + ) + const log = screen.getByTestId('crdt-dev-panel-log').textContent + expect(log).toContain(kind) + expect(log).not.toContain(absent) + } + }) + it('shows the sensitive-source opt-ins as off, and lets them be turned on', async () => { const user = userEvent.setup() renderPanel() diff --git a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue index 54a90f3392e..c1ea82ad622 100644 --- a/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue +++ b/src/workbench/extensions/agent/crdt/CrdtDevPanel.vue @@ -162,6 +162,8 @@ const EVENT_KINDS: readonly DevEventKind[] = [ 'human_ops_settled', 'doc_reset', 'doc_nodes_changed', + 'doc_effects', + 'op_minted', 'schema_error', 'reconnected', 'subscribe_retry', diff --git a/src/workbench/extensions/agent/crdt/crdtLog.test.ts b/src/workbench/extensions/agent/crdt/crdtLog.test.ts index d1e1ef22fdf..0aaf4c7a20c 100644 --- a/src/workbench/extensions/agent/crdt/crdtLog.test.ts +++ b/src/workbench/extensions/agent/crdt/crdtLog.test.ts @@ -1,7 +1,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest' -import { setCrdtDebugEnabled } from './crdtDebugGate' -import { wireLog } from './crdtLog' +import { setCrdtDebugEnabled, setCrdtLogLevel } from './crdtDebugGate' +import { docLog, wireLog } from './crdtLog' import { clearDevEvents, devEvents } from './devPanelLog' describe('crdtLog', () => { @@ -10,6 +10,30 @@ describe('crdtLog', () => { clearDevEvents() }) + it('retains document detail below console verbosity and prints it once when enabled', () => { + const debug = vi.spyOn(console, 'debug').mockImplementation(() => {}) + const logDocument = docLog.debug + setCrdtLogLevel('info') + logDocument('doc_effects', 'projection outcome', { committed: false }) + expect(debug).not.toHaveBeenCalled() + expect(devEvents.value).toHaveLength(1) + expect(devEvents.value[0]).toMatchObject({ + scope: 'doc', + level: 'debug', + detail: { committed: false } + }) + + setCrdtLogLevel('debug') + logDocument('doc_effects', 'projection outcome', { committed: true }) + expect(debug).toHaveBeenCalledExactlyOnceWith( + '%c[crdt:doc]%c doc_effects — projection outcome', + 'color:#a5b4fc', + '', + { committed: true } + ) + expect(devEvents.value).toHaveLength(2) + }) + it('keeps warnings visible when the debug instrument is opted out', () => { const warn = vi.spyOn(console, 'warn').mockImplementation(() => {}) setCrdtDebugEnabled(false) diff --git a/src/workbench/extensions/agent/crdt/crdtLog.ts b/src/workbench/extensions/agent/crdt/crdtLog.ts index 02e03ae746a..4967ddd3983 100644 --- a/src/workbench/extensions/agent/crdt/crdtLog.ts +++ b/src/workbench/extensions/agent/crdt/crdtLog.ts @@ -5,8 +5,8 @@ * Before this module the two were wired independently — a handful of * `recordDevEvent` calls that never printed, and a handful of bare * `console.warn`s the panel never saw — so the console and the copied report - * disagreed about what happened. New structured wire events use - * {@link crdtLog}; existing document events remain in the shared ring buffer. + * disagreed about what happened. Wire and document events use + * {@link crdtLog} to share the debug gate and console level selection. */ import type { CrdtLogLevel } from './crdtDebugGate' import { @@ -85,3 +85,4 @@ function scopedCrdtLog(scope: CrdtLogScope) { } export const wireLog = scopedCrdtLog('wire') +export const docLog = scopedCrdtLog('doc') diff --git a/src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts b/src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts index 623f3eb9007..50e777284af 100644 --- a/src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts +++ b/src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts @@ -232,7 +232,8 @@ describe('R-73 cross-workflow pending operation characterization', () => { { state: 'undeliverable', ops: [expect.objectContaining({ op_id: operationAId })] - } + }, + { scope: 'doc', level: 'debug' } ) enqueue([deleteNode('b-pending')]) expect(clientState.sent).toHaveLength(2) @@ -272,7 +273,8 @@ describe('R-73 cross-workflow pending operation characterization', () => { ok: true, applied: [operationAId], skipped: [] - } + }, + { scope: 'doc', level: 'debug' } ) expect(operationBId).not.toBe(operationAId) }) diff --git a/src/workbench/extensions/agent/crdt/devPanelLog.ts b/src/workbench/extensions/agent/crdt/devPanelLog.ts index 5b919fcaef2..b5cd73a3827 100644 --- a/src/workbench/extensions/agent/crdt/devPanelLog.ts +++ b/src/workbench/extensions/agent/crdt/devPanelLog.ts @@ -32,6 +32,8 @@ export type DevEventKind = | 'reconnected' | 'subscribe_retry' | 'doc_nodes_changed' + | 'doc_effects' + | 'op_minted' | 'rebind' | 'stale_probe' | 'doc_gap' diff --git a/src/workbench/extensions/agent/crdt/docFrameClient.test.ts b/src/workbench/extensions/agent/crdt/docFrameClient.test.ts index 4647c758e39..dc7c3427592 100644 --- a/src/workbench/extensions/agent/crdt/docFrameClient.test.ts +++ b/src/workbench/extensions/agent/crdt/docFrameClient.test.ts @@ -3,6 +3,8 @@ import * as Y from 'yjs' import { reportError } from '@/platform/telemetry/reportError' +import { setCrdtDebugEnabled } from './crdtDebugGate' +import { clearDevEvents, devEvents } from './devPanelLog' import type { DocFrameTransport } from './docFrameClient' import { DocFrameClient, @@ -36,6 +38,49 @@ function updateAfter(doc: Y.Doc, mutate: () => void): Uint8Array { } describe('doc frame client', () => { + it('reports false sends for every frame type without changing delivery results', () => { + setCrdtDebugEnabled(true) + clearDevEvents() + const warn = vi.spyOn(console, 'warn').mockImplementation(() => {}) + const transport = new TestTransport() + const send = vi.spyOn(transport, 'send').mockReturnValue(false) + const client = new DocFrameClient(transport) + + expect(client.subscribe('wf-private', new Uint8Array())).toBe(false) + expect(client.sendOps('wf-private', 'tab-private', [])).toBe(false) + expect(client.unsubscribe('wf-private')).toBe(false) + expect( + devEvents.value.map(({ kind, scope, detail }) => ({ + kind, + scope, + detail + })) + ).toEqual( + ['doc_subscribe', 'doc_ops', 'doc_unsubscribe'].map((frameType) => ({ + kind: 'frame_send_failed', + scope: 'wire', + detail: { + frameType, + workflowId: 'wf-private', + reason: 'transport_unavailable' + } + })) + ) + + send.mockReturnValue(true) + expect(client.subscribe('wf-private', new Uint8Array())).toBe(true) + expect(devEvents.value).toHaveLength(3) + clearDevEvents() + setCrdtDebugEnabled(false) + warn.mockClear() + send.mockReturnValue(false) + expect(client.unsubscribe('wf-private')).toBe(false) + expect(warn).toHaveBeenCalledOnce() + expect(JSON.stringify(warn.mock.calls)).not.toContain('wf-private') + expect(devEvents.value).toHaveLength(0) + client.destroy() + }) + it('decodes a base64 doc_update that converges through Y.applyUpdate', () => { const source = new Y.Doc() source.getMap('nodes').set('one', { x: 10 }) diff --git a/src/workbench/extensions/agent/crdt/docFrameClient.ts b/src/workbench/extensions/agent/crdt/docFrameClient.ts index 53d8d995e56..197e68b1ee3 100644 --- a/src/workbench/extensions/agent/crdt/docFrameClient.ts +++ b/src/workbench/extensions/agent/crdt/docFrameClient.ts @@ -2,6 +2,8 @@ import type { Op } from '@comfyorg/comfy-multi-player' import { reportError } from '@/platform/telemetry/reportError' +import { wireLog } from './crdtLog' + export const DOC_PROTOCOL_VERSION = 1 /** Keep this encoded-field cap aligned with cloud's `MaxDocFrameB64Len`. */ const MAX_DOC_UPDATE_B64_LENGTH = 8 << 20 @@ -450,6 +452,14 @@ export class DocFrameClient extends EventTarget { } private send(type: string, data: Record): boolean { - return this.transport.send(JSON.stringify({ type, data })) + const delivered = this.transport.send(JSON.stringify({ type, data })) + if (!delivered) { + wireLog.warn('frame_send_failed', 'outbound doc frame not sent', { + frameType: type, + workflowId: data.workflow_id, + reason: 'transport_unavailable' + }) + } + return delivered } } diff --git a/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts b/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts index f4f52bf7170..e5bc9fed98e 100644 --- a/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts +++ b/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts @@ -14,6 +14,8 @@ import type { NodeId } from '@/types/nodeId' import { toNodeId } from '@/types/nodeId' import { widgetId } from '@/types/widgetId' +import { setCrdtDebugEnabled } from './crdtDebugGate' +import { clearDevEvents, devEvents } from './devPanelLog' import type { DocUpdate } from './docFrameClient' import { EcsFollowerAdapter } from './ecsFollowerAdapter' import { FollowerDoc } from './followerDoc' @@ -45,6 +47,8 @@ function op(id: string, baseVersion: number, payload: object) { describe('EcsFollowerAdapter integration', () => { it('reconciles a full seeded snapshot with existing and server-ahead entities', () => { + setCrdtDebugEnabled(true) + clearDevEvents() const layouts = new Map() const createLayout = vi.fn( (_scope: typeof scope, nodeId: NodeId, layout: TestLayout) => { @@ -144,6 +148,22 @@ describe('EcsFollowerAdapter integration', () => { }) expect(deleteLayouts).not.toHaveBeenCalled() expect(createLayout).toHaveBeenCalledOnce() + expect( + devEvents.value.find(({ kind }) => kind === 'doc_effects')?.detail + ).toEqual({ + workflowId: 'wf', + seq: 1, + reconcile: true, + committed: true, + nodeActions: [ + ['1', 'add'], + ['2', 'add'] + ], + changedWidgets: [], + replacedWidgetMaps: [], + changedLinkIds: ['9'], + removedLinkIds: [] + }) adapter.destroy() follower.destroy() @@ -244,6 +264,8 @@ describe('EcsFollowerAdapter integration', () => { }) it('retries authoritative reconciliation after a rejected first batch', () => { + setCrdtDebugEnabled(true) + clearDevEvents() const deleteLayouts = vi.fn() let scopeAvailable = false const mutations = createGraphMutations({ @@ -291,6 +313,14 @@ describe('EcsFollowerAdapter integration', () => { // incremental handling. scopeAvailable = true expect(adapter.applyFrame({ workflowId: 'wf', seq: 2, update })).toBe(true) + expect( + devEvents.value + .filter(({ kind }) => kind === 'doc_effects') + .map(({ detail }) => detail) + ).toEqual([ + expect.objectContaining({ seq: 1, reconcile: true, committed: false }), + expect.objectContaining({ seq: 2, reconcile: true, committed: true }) + ]) expect(useNodeDataStore().getGraphNodesFor('root', 'root')).toEqual([]) expect(deleteLayouts).toHaveBeenCalledWith( scope, @@ -791,7 +821,9 @@ describe('EcsFollowerAdapter integration', () => { }) it('keeps the targeted update path for value changes and same-frame re-adds', () => { + setCrdtDebugEnabled(true) const { widgets, deliver, widgetValue, destroy } = bindSeededHost() + clearDevEvents() deliver(2, () => widgets.set('seed', 5)) deliver(3, () => { @@ -802,6 +834,22 @@ describe('EcsFollowerAdapter integration', () => { expect(widgetValue('seed')).toBe(5) expect(widgetValue('stale')).toBe(11) expect(useWidgetValueStore().clearNode).not.toHaveBeenCalled() + expect( + devEvents.value + .filter(({ kind }) => kind === 'doc_effects') + .map(({ detail }) => detail) + ).toEqual([ + expect.objectContaining({ + seq: 2, + reconcile: false, + changedWidgets: [['1', ['seed']]] + }), + expect.objectContaining({ + seq: 3, + reconcile: false, + changedWidgets: [['1', ['stale']]] + }) + ]) destroy() }) diff --git a/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts b/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts index 6f72c7f37fe..14278f8ff42 100644 --- a/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts +++ b/src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts @@ -13,6 +13,8 @@ import type { import type { RemoteMutationContext } from '@/types/graphMutationContext' import { toNodeId } from '@/types/nodeId' +import { isCrdtDebugEnabled } from './crdtDebugGate' +import { docLog } from './crdtLog' import type { DocUpdate } from './docFrameClient' import type { FollowerDoc } from './followerDoc' @@ -307,6 +309,22 @@ export class EcsFollowerAdapter { // cleanup instead of falling through to incremental handling with // stale local-only graph state still present. if (committed) session.reconcileNextFrame = false + if (isCrdtDebugEnabled()) { + docLog.debug('doc_effects', 'document projection batch outcome', { + workflowId: session.workflowId, + seq: update.seq, + reconcile, + committed, + nodeActions: [...nodeActions], + changedWidgets: [...changedWidgets].map(([id, names]) => [ + id, + [...names] + ]), + replacedWidgetMaps: [...replacedWidgetMaps], + changedLinkIds: [...changedLinkIds], + removedLinkIds + }) + } return committed } diff --git a/src/workbench/extensions/agent/crdt/opSender.test.ts b/src/workbench/extensions/agent/crdt/opSender.test.ts index 4e1cfaf7b23..c72cfb3fc4b 100644 --- a/src/workbench/extensions/agent/crdt/opSender.test.ts +++ b/src/workbench/extensions/agent/crdt/opSender.test.ts @@ -2,6 +2,8 @@ import type { Op } from '@comfyorg/comfy-multi-player' import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' import type { GraphOperation } from './graphOperations' +import { setCrdtDebugEnabled } from './crdtDebugGate' +import { clearDevEvents, devEvents } from './devPanelLog' import { createOpSender } from './opSender' import type { BatchOutcome, OpsResultView } from './opSender' @@ -67,6 +69,36 @@ describe('createOpSender', () => { sender.detach() }) + it('records mint metadata once even when transport retries the operation', () => { + setCrdtDebugEnabled(true) + clearDevEvents() + transportUp = false + sender.enqueue([addNode(7), addNode(9)]) + const minted = devEvents.value.filter(({ kind }) => kind === 'op_minted') + expect(minted).toHaveLength(1) + expect(minted[0].detail).toEqual({ + workflowId: WORKFLOW, + ops: [7, 9].map((nodeId) => ({ + op: 'add_node', + op_id: expect.stringMatching(/^[0-9a-f]{32}$/), + actor: ACTOR, + base_version: 41, + stamp: [41, ACTOR], + node_id: nodeId + })) + }) + transportUp = true + vi.advanceTimersByTime(500) + vi.advanceTimersByTime(10_000) + expect(sent).toHaveLength(2) + expect( + devEvents.value.filter(({ kind }) => kind === 'op_minted') + ).toHaveLength(1) + expect(JSON.stringify(minted[0].detail)).toContain(sent[0].ops[0].op_id) + expect(sent[1].ops).toEqual(sent[0].ops) + expect(JSON.stringify(minted[0].detail)).not.toContain('class_type') + }) + it('mints once and sends a doc_ops batch with the wire envelope', () => { sender.enqueue([addNode(1), addNode(2)]) diff --git a/src/workbench/extensions/agent/crdt/opSender.ts b/src/workbench/extensions/agent/crdt/opSender.ts index eb171e9be5e..d8e251a6c99 100644 --- a/src/workbench/extensions/agent/crdt/opSender.ts +++ b/src/workbench/extensions/agent/crdt/opSender.ts @@ -17,6 +17,8 @@ */ import type { Op } from '@comfyorg/comfy-multi-player' +import { isCrdtDebugEnabled } from './crdtDebugGate' +import { docLog } from './crdtLog' import type { GraphOperation } from './graphOperations' import { chunkWireOps, mintWireOps } from './opEnvelope' @@ -211,6 +213,19 @@ export function createOpSender(deps: OpSenderDeps): OpSender { baseVersion: deps.baseVersion() }) const workflowId = deps.workflowId() + if (isCrdtDebugEnabled()) { + docLog.debug('op_minted', 'human operation identities minted', { + workflowId, + ops: minted.map((op) => ({ + op: op.op, + op_id: op.op_id, + actor: op.actor, + base_version: op.base_version, + stamp: [...op.stamp], + ...('node_id' in op && { node_id: op.node_id }) + })) + }) + } if (workflowId === null) { deps.onBatchSettled({ state: 'undeliverable', ops: minted }) return diff --git a/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts b/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts index 1d366139f48..76c3fb7bffc 100644 --- a/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts +++ b/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts @@ -858,7 +858,8 @@ describe('useAgentCrdtFollower', () => { expect(materializedEvents).toEqual([ [ 'agent_node_adapters_materialized', - { workflowId: 'wf-1', nodeIds: [toNodeId(1)] } + { workflowId: 'wf-1', nodeIds: [toNodeId(1)] }, + { scope: 'doc', level: 'debug' } ] ]) unmount() diff --git a/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts b/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts index e76af459ef3..ceb9eaa1308 100644 --- a/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts +++ b/src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts @@ -11,8 +11,7 @@ import { readSubgraphDefinitionIds, readSubgraphDefinitions } from './agentSubgraphDefinitions' -import { recordDevEvent } from './devPanelLog' -import { wireLog } from './crdtLog' +import { docLog, wireLog } from './crdtLog' import type { CrdtDebugSnapshot } from './crdtSnapshot' import { readCrdtSnapshot } from './crdtSnapshot' import type { DocFrameTransport, DocUpdate } from './docFrameClient' @@ -142,7 +141,7 @@ export const STALE_AFTER_MS = 30_000 * (which counts Yjs merges, including frames this composable skips) so a * divergence between the two is visible instead of hidden behind one number. * No payload bodies or actor identifiers are recorded here — see - * `recordDevEvent` call sites for the (dev-only) frame detail surface. + * `docLog` call sites for the (dev-only) frame detail surface. */ export interface AgentCrdtOutcomeCounters { /** Every `doc_update` event the composable's listener was invoked with. */ @@ -270,7 +269,12 @@ export function useAgentCrdtFollower( tab: tabId, actor: () => `human:${userId() ?? 'anonymous'}:${tabId}`, baseVersion: () => bridge.lastSequence, - onBatchSettled: (outcome) => recordDevEvent('human_ops_settled', outcome) + onBatchSettled: (outcome) => + docLog.debug( + 'human_ops_settled', + 'human operation batch settled', + outcome + ) }) // Dev-panel tap (poc-4): track the doc's node-id set so the panel can show @@ -332,7 +336,7 @@ export function useAgentCrdtFollower( clearStaleProbe() staleProbeTimer = setTimeout(() => { staleProbeTimer = null - recordDevEvent('stale_probe', { + docLog.info('stale_probe', 'probing an idle subscription', { workflowId: subscribedWorkflowId.value }) bridge.resubscribe() @@ -359,7 +363,7 @@ export function useAgentCrdtFollower( subscribeRetryTimer = null // The desired doc changed while we waited — the watch owns that path. if (subscribedWorkflowId.value !== target) return - recordDevEvent('subscribe_retry', { + docLog.info('subscribe_retry', 'retrying subscription', { attempt: subscribeRetryAttempt, workflowId: target }) @@ -373,7 +377,7 @@ export function useAgentCrdtFollower( const ok = event.detail?.ok === true connected.value = ok lastFrameType.value = event.type - recordDevEvent('doc_subscribed', event.detail ?? null) + docLog.info('doc_subscribed', 'subscription result', event.detail ?? null) if (ok) { clearSubscribeRetry() armStaleProbe() @@ -416,7 +420,7 @@ export function useAgentCrdtFollower( ? { ...outcomes.value, applied: outcomes.value.applied + 1 } : { ...outcomes.value, skipped: outcomes.value.skipped + 1 } if (applied) reconcileLiveGraph(update.workflowId) - recordDevEvent('doc_update', { + docLog.trace('doc_update', 'document update received', { workflowId: update.workflowId, seq: update.seq, actor: update.actor, @@ -426,7 +430,10 @@ export function useAgentCrdtFollower( const added = [...ids].filter((id) => !knownDocNodeIds.has(id)) const removed = [...knownDocNodeIds].filter((id) => !ids.has(id)) if (added.length > 0 || removed.length > 0) - recordDevEvent('doc_nodes_changed', { added, removed }) + docLog.debug('doc_nodes_changed', 'document node membership changed', { + added, + removed + }) knownDocNodeIds = ids } const onOpsResult: EventListener = (event) => { @@ -442,7 +449,11 @@ export function useAgentCrdtFollower( refreshPersistedDocId() } lastFrameType.value = event.type - recordDevEvent('doc_ops_result', event.detail ?? null) + docLog.debug( + 'doc_ops_result', + 'host operation result', + event.detail ?? null + ) } const onDocReset: EventListener = (event) => { const detail = @@ -475,8 +486,9 @@ export function useAgentCrdtFollower( lastFrameType.value = event.type clearStaleProbe() knownDocNodeIds = new Set() - recordDevEvent( + docLog.info( 'doc_reset', + 'document lineage reset', event instanceof CustomEvent ? (event.detail ?? null) : null ) } @@ -521,29 +533,32 @@ export function useAgentCrdtFollower( if (detail?.workflowId !== undefined) adapter.discardPending(detail.workflowId) outcomes.value = { ...outcomes.value, errored: outcomes.value.errored + 1 } - recordDevEvent( + docLog.warn( 'schema_error', + 'document schema rejected', event instanceof CustomEvent ? (event.detail ?? null) : null ) } const onGap: EventListener = (event) => { outcomes.value = { ...outcomes.value, gap: outcomes.value.gap + 1 } - recordDevEvent( + docLog.info( 'doc_gap', + 'document sequence gap; requesting catch-up', event instanceof CustomEvent ? (event.detail ?? null) : null ) } const onStale: EventListener = (event) => { outcomes.value = { ...outcomes.value, dropped: outcomes.value.dropped + 1 } - recordDevEvent( + docLog.trace( 'doc_stale', + 'stale document frame ignored', event instanceof CustomEvent ? (event.detail ?? null) : null ) } const onReconnected: EventListener = () => { connected.value = false clearStaleProbe() - recordDevEvent('reconnected', null) + docLog.info('reconnected', 'transport reconnected', null) bridge.resubscribe() } /** @@ -598,10 +613,14 @@ export function useAgentCrdtFollower( // else asks the canvas to paint the new links. graph.setDirtyCanvas(true, true) if (nodeIds.length > 0) { - recordDevEvent('agent_node_adapters_materialized', { - workflowId: docId, - nodeIds - }) + docLog.debug( + 'agent_node_adapters_materialized', + 'live node adapters materialized', + { + workflowId: docId, + nodeIds + } + ) } } // Readiness only. The other ordering -- graph ready first, target activated @@ -652,7 +671,9 @@ export function useAgentCrdtFollower( const persisted = initialBind ? readPersistedDocId() : null initialBind = false if (persisted !== null) { - recordDevEvent('rebind', { workflowId: persisted }) + docLog.info('rebind', 'restoring page-session binding', { + workflowId: persisted + }) if (boundWorkflowId !== persisted) { if (boundWorkflowId !== null) adapter.unbind(boundWorkflowId) adapter.bind(persisted, bridge.follower)