From 6d22eccadd4e2636de00f5aa43078bafc60cc3a7 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Mon, 31 Aug 2026 03:55:58 -0700 Subject: [PATCH 1/5] test(assets): cover mobile sidebar smoke on main --- .../tests/sidebar/assetsSidebarTab.spec.ts | 99 ++++++++++++++++++- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts index 5bbf99ec5e2..83f8c8808af 100644 --- a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts +++ b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts @@ -2,6 +2,7 @@ import { expect, mergeTests } from '@playwright/test' import type { Page, Response } from '@playwright/test' import { comfyPageFixture } from '@e2e/fixtures/ComfyPage' +import type { ComfyPage } from '@e2e/fixtures/ComfyPage' import { expectNoErrorUiAfterVerification } from '@e2e/fixtures/helpers/ErrorsTabHelper' import { createRouteMockJob, @@ -83,7 +84,7 @@ const multiOutputJobDetail: JobDetail = { } const previewableCountJob = createRouteMockJob({ - id: 'previewable-count-job', + id: '00000000-0000-4000-a000-000000000003', create_time: routeMockJobTimestamp - 4_000, execution_start_time: routeMockJobTimestamp - 4_000, execution_end_time: routeMockJobTimestamp, @@ -150,6 +151,84 @@ async function mockInputFiles(page: Page, files: readonly string[]) { }) } +const mobileCloudAssets = [ + 'previewable-count-a.png', + 'previewable-count-b.png' +].map((name, index) => ({ + id: `mobile-smoke-${index}`, + name, + job_id: previewableCountJob.id, + mime_type: 'image/png', + tags: ['output'], + preview_url: `/api/view?filename=${name}&type=output`, + created_at: new Date( + previewableCountJob.create_time - index * 1_000 + ).toISOString(), + updated_at: new Date( + previewableCountJob.create_time - index * 1_000 + ).toISOString() +})) + +async function verifyMobileListFilterGroupDelete(comfyPage: ComfyPage) { + const tab = comfyPage.menu.assetsTab + + await tab.open() + await tab.openSettingsMenu() + await tab.listViewOption.tap() + const firstAsset = tab.listViewItems.filter({ + hasText: 'previewable-count-a' + }) + await expect(firstAsset).toBeVisible() + + await tab.searchInput.fill('previewable-count-a') + await expect(tab.listViewItems).toHaveCount(1) + await tab.searchInput.clear() + + const groupButton = firstAsset.getByRole('button', { + name: 'See more outputs' + }) + await expect(groupButton).toBeInViewport({ ratio: 1 }) + await groupButton.tap() + await expect(groupButton).toHaveAttribute('aria-expanded', 'true') + await expect( + tab.listViewItems.filter({ hasText: 'previewable-count-b' }) + ).toBeVisible() + + await tab.openSettingsMenu() + await tab.gridLargeOption.tap() + await tab.waitForAssets() + await tab.getAssetCardByName('previewable-count-a').tap() + await expect(tab.deleteSelectedButton).toBeInViewport({ ratio: 1 }) + await tab.deleteSelectedButton.tap() + await expect(comfyPage.confirmDialog.delete).toBeInViewport({ ratio: 1 }) + await expect(comfyPage.confirmDialog.reject).toBeInViewport({ ratio: 1 }) + await comfyPage.confirmDialog.reject.tap() + await expect(comfyPage.confirmDialog.root).toBeHidden() +} + +const mobileListSmokeTest = comfyPageFixture.extend({ + page: async ({ page }, use) => { + const jobsRoutes = new JobsRouteMocker(page) + await jobsRoutes.mockJobsQueue([]) + await jobsRoutes.mockJobsHistory([previewableCountJob]) + await jobsRoutes.mockJobDetail( + previewableCountJob.id, + previewableCountJobDetail + ) + await page.route(/\/api\/assets(?:\?.*)?$/, (route) => + route.fulfill({ + json: { + assets: mobileCloudAssets, + total: mobileCloudAssets.length, + has_more: false + } + }) + ) + await mockViewFiles(page, viewFiles) + await use(page) + } +}) + function isGeneratedAssetVerificationResponse(response: Response): boolean { const url = new URL(response.url()) return ( @@ -296,7 +375,7 @@ test.describe('FE-130 assets sidebar route mocks', () => { await jobsRoutes.mockJobsHistory([previewableCountJob]) await jobsRoutes.mockJobDetail( - 'previewable-count-job', + previewableCountJob.id, previewableCountJobDetail ) @@ -339,6 +418,22 @@ test.describe('FE-130 assets sidebar route mocks', () => { }) }) +mobileListSmokeTest.describe('FE-130 assets sidebar route mocks', () => { + mobileListSmokeTest( + '@mobile list, filter, group, and delete controls remain usable', + async ({ comfyPage }) => { + await verifyMobileListFilterGroupDelete(comfyPage) + } + ) + + mobileListSmokeTest( + '@mobile-ios @cloud list, filter, group, and delete controls remain usable', + async ({ comfyPage }) => { + await verifyMobileListFilterGroupDelete(comfyPage) + } + ) +}) + bulkInsertionTest.describe( 'Assets sidebar - bulk insert as nodes', { tag: ['@vue-nodes', '@ui', '@node', '@widget'] }, From 78e01e7443a4215e716c97af0beb4d3f21f93aed Mon Sep 17 00:00:00 2001 From: bymyself Date: Mon, 31 Aug 2026 11:01:31 +0000 Subject: [PATCH 2/5] test(assets): validate mobile smoke on main From d27370e69e22aeba0bf6e76a1b31f323fb1e73de Mon Sep 17 00:00:00 2001 From: christian-byrne Date: Thu, 10 Sep 2026 15:18:45 -0700 Subject: [PATCH 3/5] test(assets): type the /api/assets mobile mock against AssetResponse Annotate the raw /api/assets mock with AssetResponse/AssetItem from src/platform/assets/schemas/assetSchema so a contract change fails typecheck instead of leaving the test passing against a fiction. Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/16366#discussion_r3912723930 --- .../tests/sidebar/assetsSidebarTab.spec.ts | 53 ++++++++++--------- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts index 83f8c8808af..6021e97f985 100644 --- a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts +++ b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts @@ -13,6 +13,10 @@ import { import { TestIds } from '@e2e/fixtures/selectors' import { mockViewFiles } from '@e2e/fixtures/utils/viewFileMocks' import { PropertiesPanelHelper } from '@e2e/tests/propertiesPanel/PropertiesPanelHelper' +import type { + AssetItem, + AssetResponse +} from '@/platform/assets/schemas/assetSchema' import type { JobDetail, RawJobListItem @@ -151,23 +155,30 @@ async function mockInputFiles(page: Page, files: readonly string[]) { }) } -const mobileCloudAssets = [ - 'previewable-count-a.png', - 'previewable-count-b.png' -].map((name, index) => ({ - id: `mobile-smoke-${index}`, - name, - job_id: previewableCountJob.id, - mime_type: 'image/png', - tags: ['output'], - preview_url: `/api/view?filename=${name}&type=output`, - created_at: new Date( - previewableCountJob.create_time - index * 1_000 - ).toISOString(), - updated_at: new Date( - previewableCountJob.create_time - index * 1_000 - ).toISOString() -})) +const mobileAssetNames = ['previewable-count-a.png', 'previewable-count-b.png'] + +const mobileAssets = mobileAssetNames.map( + (name, index): AssetItem => ({ + id: `00000000-0000-4000-b000-00000000000${index}`, + name, + job_id: previewableCountJob.id, + mime_type: 'image/png', + tags: ['output'], + preview_url: `/api/view?filename=${name}&type=output`, + created_at: new Date( + previewableCountJob.create_time - index * 1_000 + ).toISOString(), + updated_at: new Date( + previewableCountJob.create_time - index * 1_000 + ).toISOString() + }) +) + +const mobileAssetsResponse: AssetResponse = { + assets: mobileAssets, + total: mobileAssets.length, + has_more: false +} async function verifyMobileListFilterGroupDelete(comfyPage: ComfyPage) { const tab = comfyPage.menu.assetsTab @@ -216,13 +227,7 @@ const mobileListSmokeTest = comfyPageFixture.extend({ previewableCountJobDetail ) await page.route(/\/api\/assets(?:\?.*)?$/, (route) => - route.fulfill({ - json: { - assets: mobileCloudAssets, - total: mobileCloudAssets.length, - has_more: false - } - }) + route.fulfill({ json: mobileAssetsResponse }) ) await mockViewFiles(page, viewFiles) await use(page) From 02218edf93061dd9f7ec3d301b95b6856a2bbea9 Mon Sep 17 00:00:00 2001 From: christian-byrne Date: Thu, 10 Sep 2026 15:20:45 -0700 Subject: [PATCH 4/5] test(assets): move the mobile smoke routine onto AssetsSidebarTab browser_tests/README.md requires reusable interaction routines and locator wiring to live in a page object, not as free-standing functions in a spec. The list/filter/group/delete sequence becomes AssetsSidebarTab.expectTouchControlsUsable, with the list-item and "See more outputs" locators alongside the tab's other locators. Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/16366#discussion_r3912723939 --- .../fixtures/components/SidebarTab.ts | 56 +++++++++++++++++++ .../tests/sidebar/assetsSidebarTab.spec.ts | 47 +++------------- 2 files changed, 65 insertions(+), 38 deletions(-) diff --git a/browser_tests/fixtures/components/SidebarTab.ts b/browser_tests/fixtures/components/SidebarTab.ts index 61524be3e25..f56dc650c4c 100644 --- a/browser_tests/fixtures/components/SidebarTab.ts +++ b/browser_tests/fixtures/components/SidebarTab.ts @@ -2,6 +2,7 @@ import type { Locator, Page } from '@playwright/test' import { expect } from '@playwright/test' import type { WorkspaceStore } from '@e2e/types/globals' +import { ConfirmDialog } from '@e2e/fixtures/components/ConfirmDialog' import { TestIds } from '@e2e/fixtures/selectors' export class SidebarTab { @@ -340,8 +341,12 @@ export class AssetsSidebarTab extends SidebarTab { // --- Loading --- public readonly skeletonLoaders: Locator + // --- Delete confirmation --- + public readonly deleteConfirmDialog: ConfirmDialog + constructor(public override readonly page: Page) { super(page, 'assets') + this.deleteConfirmDialog = new ConfirmDialog(page) this.generatedTab = page.getByRole('tab', { name: 'Generated' }) this.importedTab = page.getByRole('tab', { name: 'Imported' }) this.emptyStateMessage = page.getByText( @@ -422,6 +427,57 @@ export class AssetsSidebarTab extends SidebarTab { return this.assetCards.filter({ hasText: name }) } + getListViewItemByName(name: string) { + return this.listViewItems.filter({ hasText: name }) + } + + getSeeMoreOutputsButton(name: string) { + return this.getListViewItemByName(name).getByRole('button', { + name: 'See more outputs' + }) + } + + /** + * Touch-driven pass over list view, search, output grouping and delete + * confirmation, asserting every control the sequence touches stays fully + * inside the viewport on a phone-sized screen. + */ + async expectTouchControlsUsable({ + assetName, + groupedAssetName + }: { + assetName: string + groupedAssetName: string + }) { + await this.open() + await this.openSettingsMenu() + await this.listViewOption.tap() + + const listItem = this.getListViewItemByName(assetName) + await expect(listItem).toBeVisible() + + await this.searchInput.fill(assetName) + await expect(this.listViewItems).toHaveCount(1) + await this.searchInput.clear() + + const groupButton = this.getSeeMoreOutputsButton(assetName) + await expect(groupButton).toBeInViewport({ ratio: 1 }) + await groupButton.tap() + await expect(groupButton).toHaveAttribute('aria-expanded', 'true') + await expect(this.getListViewItemByName(groupedAssetName)).toBeVisible() + + await this.openSettingsMenu() + await this.gridLargeOption.tap() + await this.waitForAssets() + await this.getAssetCardByName(assetName).tap() + await expect(this.deleteSelectedButton).toBeInViewport({ ratio: 1 }) + await this.deleteSelectedButton.tap() + await expect(this.deleteConfirmDialog.delete).toBeInViewport({ ratio: 1 }) + await expect(this.deleteConfirmDialog.reject).toBeInViewport({ ratio: 1 }) + await this.deleteConfirmDialog.reject.tap() + await expect(this.deleteConfirmDialog.root).toBeHidden() + } + async getFirstGridItemWidth() { return await this.gridItems.first().evaluate((element) => { return element.getBoundingClientRect().width diff --git a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts index 6021e97f985..e3288f2ebc0 100644 --- a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts +++ b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts @@ -2,7 +2,6 @@ import { expect, mergeTests } from '@playwright/test' import type { Page, Response } from '@playwright/test' import { comfyPageFixture } from '@e2e/fixtures/ComfyPage' -import type { ComfyPage } from '@e2e/fixtures/ComfyPage' import { expectNoErrorUiAfterVerification } from '@e2e/fixtures/helpers/ErrorsTabHelper' import { createRouteMockJob, @@ -180,41 +179,9 @@ const mobileAssetsResponse: AssetResponse = { has_more: false } -async function verifyMobileListFilterGroupDelete(comfyPage: ComfyPage) { - const tab = comfyPage.menu.assetsTab - - await tab.open() - await tab.openSettingsMenu() - await tab.listViewOption.tap() - const firstAsset = tab.listViewItems.filter({ - hasText: 'previewable-count-a' - }) - await expect(firstAsset).toBeVisible() - - await tab.searchInput.fill('previewable-count-a') - await expect(tab.listViewItems).toHaveCount(1) - await tab.searchInput.clear() - - const groupButton = firstAsset.getByRole('button', { - name: 'See more outputs' - }) - await expect(groupButton).toBeInViewport({ ratio: 1 }) - await groupButton.tap() - await expect(groupButton).toHaveAttribute('aria-expanded', 'true') - await expect( - tab.listViewItems.filter({ hasText: 'previewable-count-b' }) - ).toBeVisible() - - await tab.openSettingsMenu() - await tab.gridLargeOption.tap() - await tab.waitForAssets() - await tab.getAssetCardByName('previewable-count-a').tap() - await expect(tab.deleteSelectedButton).toBeInViewport({ ratio: 1 }) - await tab.deleteSelectedButton.tap() - await expect(comfyPage.confirmDialog.delete).toBeInViewport({ ratio: 1 }) - await expect(comfyPage.confirmDialog.reject).toBeInViewport({ ratio: 1 }) - await comfyPage.confirmDialog.reject.tap() - await expect(comfyPage.confirmDialog.root).toBeHidden() +const mobileTouchControlNames = { + assetName: 'previewable-count-a', + groupedAssetName: 'previewable-count-b' } const mobileListSmokeTest = comfyPageFixture.extend({ @@ -427,14 +394,18 @@ mobileListSmokeTest.describe('FE-130 assets sidebar route mocks', () => { mobileListSmokeTest( '@mobile list, filter, group, and delete controls remain usable', async ({ comfyPage }) => { - await verifyMobileListFilterGroupDelete(comfyPage) + await comfyPage.menu.assetsTab.expectTouchControlsUsable( + mobileTouchControlNames + ) } ) mobileListSmokeTest( '@mobile-ios @cloud list, filter, group, and delete controls remain usable', async ({ comfyPage }) => { - await verifyMobileListFilterGroupDelete(comfyPage) + await comfyPage.menu.assetsTab.expectTouchControlsUsable( + mobileTouchControlNames + ) } ) }) From 9bea836243e8fadc63a5174ee52e07f487bebf77 Mon Sep 17 00:00:00 2001 From: christian-byrne Date: Thu, 10 Sep 2026 15:21:38 -0700 Subject: [PATCH 5/5] test(assets): drop the unreachable @cloud tag from the iOS smoke test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The cloud project sets grepInvert /@oss|@mobile-ios/, so a title tagged both @mobile-ios and @cloud is selected by mobile-safari only and never by cloud — the tag advertised coverage no project ran. mobile-safari already downloads the frontend-dist-cloud artifact, so @mobile-ios on its own is the combined Cloud + iOS run. Addresses review feedback: https://github.com/Comfy-Org/ComfyUI_frontend/pull/16366#discussion_r3927088523 --- browser_tests/tests/sidebar/assetsSidebarTab.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts index e3288f2ebc0..12426972c75 100644 --- a/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts +++ b/browser_tests/tests/sidebar/assetsSidebarTab.spec.ts @@ -401,7 +401,7 @@ mobileListSmokeTest.describe('FE-130 assets sidebar route mocks', () => { ) mobileListSmokeTest( - '@mobile-ios @cloud list, filter, group, and delete controls remain usable', + '@mobile-ios list, filter, group, and delete controls remain usable', async ({ comfyPage }) => { await comfyPage.menu.assetsTab.expectTouchControlsUsable( mobileTouchControlNames