From 9ad7996ac1289a665be239274e85378a4b4d4316 Mon Sep 17 00:00:00 2001 From: bymyself Date: Mon, 31 Aug 2026 02:56:36 +0000 Subject: [PATCH 01/19] feat(agent): salvage panel effects and target navigation --- src/extensions/core/agentPanel.ts | 5 +- src/stores/workflowTabActivityStore.ts | 9 +- .../extensions/agent/AgentPanelRoot.vue | 4 +- src/workbench/extensions/agent/agentPanel.css | 29 +---- .../extensions/agent/agentPanelStyles.test.ts | 43 +++++++ src/workbench/extensions/agent/agentTheme.css | 27 +++++ .../components/agent/message/AgentMessage.vue | 1 + .../agent/message/TabLinkCard.test.ts | 43 +++++++ .../components/agent/message/TabLinkCard.vue | 14 ++- .../agent/useAgentTargetNavigation.ts | 34 ++++++ .../agent/useCanvasSelection.test.ts | 17 +++ .../composables/agent/useCanvasSelection.ts | 78 ++++++++----- .../agent/schemas/agentApiSchema.test.ts | 10 +- .../agent/schemas/agentApiSchema.ts | 1 + .../agent/agentEventTransport.test.ts | 19 +++- .../services/agent/agentEventTransport.ts | 1 + .../agent/services/agent/agentMessageParts.ts | 1 + .../agent/targetAwareAgentNavigation.test.ts | 107 ++++++++++++++++++ .../agent/targetAwareAgentNavigation.ts | 92 +++++++++++++++ .../agent/workflowTabActivityTracker.test.ts | 39 ++++++- .../agent/workflowTabActivityTracker.ts | 39 +++++-- 21 files changed, 532 insertions(+), 81 deletions(-) create mode 100644 src/workbench/extensions/agent/agentPanelStyles.test.ts create mode 100644 src/workbench/extensions/agent/composables/agent/useAgentTargetNavigation.ts create mode 100644 src/workbench/extensions/agent/services/agent/targetAwareAgentNavigation.test.ts create mode 100644 src/workbench/extensions/agent/services/agent/targetAwareAgentNavigation.ts diff --git a/src/extensions/core/agentPanel.ts b/src/extensions/core/agentPanel.ts index ccfe6c53275..ecf7cfefb9f 100644 --- a/src/extensions/core/agentPanel.ts +++ b/src/extensions/core/agentPanel.ts @@ -1,3 +1,5 @@ +import { storeToRefs } from 'pinia' + import { registerWorkflowTabActivityTracker } from '@/workbench/extensions/agent/services/agent/workflowTabActivityTracker' import { useAgentPanelStore } from '@/workbench/extensions/agent/stores/agent/agentPanelStore' import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore' @@ -54,7 +56,8 @@ export function registerAgentPanelExtension(): void { notifyMintPortsAfterGraphConfigure() }, setup() { - registerWorkflowTabActivityTracker() + const { enabled } = storeToRefs(useAgentPanelStore()) + registerWorkflowTabActivityTracker(enabled) return setupFlagGate() } }) diff --git a/src/stores/workflowTabActivityStore.ts b/src/stores/workflowTabActivityStore.ts index 440a376f95a..7c4ecb199d5 100644 --- a/src/stores/workflowTabActivityStore.ts +++ b/src/stores/workflowTabActivityStore.ts @@ -37,6 +37,12 @@ export const useWorkflowTabActivityStore = defineStore( if (!open.has(path)) unseenModifiedPaths.value.delete(path) } + function clearAgentActivity(): void { + editingTabPath.value = null + creatingTab.value = false + unseenModifiedPaths.value.clear() + } + return { editingTabPath, creatingTab, @@ -45,7 +51,8 @@ export const useWorkflowTabActivityStore = defineStore( setCreating, markModified, markSeen, - pruneClosed + pruneClosed, + clearAgentActivity } } ) diff --git a/src/workbench/extensions/agent/AgentPanelRoot.vue b/src/workbench/extensions/agent/AgentPanelRoot.vue index a776b176f34..5be588fbffc 100644 --- a/src/workbench/extensions/agent/AgentPanelRoot.vue +++ b/src/workbench/extensions/agent/AgentPanelRoot.vue @@ -104,7 +104,8 @@ const workflowStore = useWorkflowStore() const workflowService = useWorkflowService() const bindingStore = useAgentWorkflowTabBindingStore() const agentPanelStore = useAgentPanelStore() -const { dismissedSelectionSignature } = storeToRefs(agentPanelStore) +const { dismissedSelectionSignature, enabled: agentEnabled } = + storeToRefs(agentPanelStore) const agentNodeSelectionStore = useAgentNodeSelectionStore() const tabActivity = useWorkflowTabActivityStore() const CREATING_TAB_MIN_DURATION_MS = 500 @@ -188,6 +189,7 @@ const { replace: replaceSelectionTags } = useCanvasSelection({ selection: selectedNodes, + enabled: agentEnabled, isLive: () => agentPanelStore.isOpen, isTracking: () => agentNodeSelectionStore.isActive, isPaused: () => agentNodeSelectionStore.isLoadingWorkflow, diff --git a/src/workbench/extensions/agent/agentPanel.css b/src/workbench/extensions/agent/agentPanel.css index 595a9556647..f287bf1320f 100644 --- a/src/workbench/extensions/agent/agentPanel.css +++ b/src/workbench/extensions/agent/agentPanel.css @@ -1,30 +1,3 @@ -@keyframes agent-collapsible-down { - from { - height: 0; - } - to { - height: var(--reka-collapsible-content-height); - } -} - -@keyframes agent-collapsible-up { - from { - height: var(--reka-collapsible-content-height); - } - to { - height: 0; - } -} - -@keyframes agent-shimmer { - from { - background-position: 150% center; - } - to { - background-position: -50% center; - } -} - .agent-shimmer-text { background: linear-gradient( 90deg, @@ -38,7 +11,7 @@ animation: agent-shimmer 1.8s linear infinite; } -.disable-animations .agent-shimmer-text { +.disable-animations #agent-panel-root .agent-shimmer-text { animation: none; color: var(--color-muted-foreground); -webkit-text-fill-color: currentcolor; diff --git a/src/workbench/extensions/agent/agentPanelStyles.test.ts b/src/workbench/extensions/agent/agentPanelStyles.test.ts new file mode 100644 index 00000000000..68fc7c1ec98 --- /dev/null +++ b/src/workbench/extensions/agent/agentPanelStyles.test.ts @@ -0,0 +1,43 @@ +import { readFileSync } from 'node:fs' +import { resolve } from 'node:path' + +import { describe, expect, it } from 'vitest' + +const themeCss = readFileSync( + resolve('src/workbench/extensions/agent/agentTheme.css'), + 'utf8' +) +const panelCss = readFileSync( + resolve('src/workbench/extensions/agent/agentPanel.css'), + 'utf8' +) +const loadedAgentCss = `${themeCss}\n${panelCss}` + +describe('agent panel styles', () => { + it('defines every referenced agent animation in the always-loaded theme', () => { + const animationNames = [ + ...loadedAgentCss.matchAll( + /(?:animation:\s*|--animate-agent-[\w-]+:\s*)(agent-[\w-]+)/g + ) + ].map((match) => match[1]) + + for (const name of new Set(animationNames)) { + expect(themeCss).toContain(`@keyframes ${name}`) + } + }) + + it('keeps selectors scoped to the agent root or agent namespace', () => { + const selectors = panelCss + .split('\n') + .map((line) => line.trimEnd()) + .filter((line) => /^[^\s@].*\{$/.test(line)) + + for (const selector of selectors) { + expect( + selector.includes('#agent-panel-root') || + selector.startsWith(':where(.agent-scope') || + selector.startsWith('.agent-') + ).toBe(true) + } + }) +}) diff --git a/src/workbench/extensions/agent/agentTheme.css b/src/workbench/extensions/agent/agentTheme.css index 6f2cd1b71e9..db1cbec18d7 100644 --- a/src/workbench/extensions/agent/agentTheme.css +++ b/src/workbench/extensions/agent/agentTheme.css @@ -22,3 +22,30 @@ --animate-agent-collapsible-down: agent-collapsible-down 200ms ease-out; --animate-agent-collapsible-up: agent-collapsible-up 200ms ease-out; } + +@keyframes agent-collapsible-down { + from { + height: 0; + } + to { + height: var(--reka-collapsible-content-height); + } +} + +@keyframes agent-collapsible-up { + from { + height: var(--reka-collapsible-content-height); + } + to { + height: 0; + } +} + +@keyframes agent-shimmer { + from { + background-position: 150% center; + } + to { + background-position: -50% center; + } +} diff --git a/src/workbench/extensions/agent/components/agent/message/AgentMessage.vue b/src/workbench/extensions/agent/components/agent/message/AgentMessage.vue index 5455745b55f..f44a2f8d565 100644 --- a/src/workbench/extensions/agent/components/agent/message/AgentMessage.vue +++ b/src/workbench/extensions/agent/components/agent/message/AgentMessage.vue @@ -82,6 +82,7 @@ const hasTools = computed(() => v-for="(link, linkIndex) in group.parts" :key="linkIndex" :workflow-id="link.workflowId" + :locator-id="link.locatorId" :name="link.name" /> diff --git a/src/workbench/extensions/agent/components/agent/message/TabLinkCard.test.ts b/src/workbench/extensions/agent/components/agent/message/TabLinkCard.test.ts index f74c0caebf6..445232f30eb 100644 --- a/src/workbench/extensions/agent/components/agent/message/TabLinkCard.test.ts +++ b/src/workbench/extensions/agent/components/agent/message/TabLinkCard.test.ts @@ -18,9 +18,14 @@ const mocks = vi.hoisted(() => ({ api: new EventTarget(), activeWorkflow: undefined as FakeTab | undefined, openWorkflow: vi.fn(), + navigate: vi.fn(), openWorkflows: [] as unknown[] })) +vi.mock('../../../composables/agent/useAgentTargetNavigation', () => ({ + useAgentTargetNavigation: () => ({ navigate: mocks.navigate }) +})) + vi.mock('@/scripts/api', () => ({ api: mocks.api })) vi.mock('@/platform/workflow/core/services/workflowService', () => ({ @@ -40,6 +45,8 @@ vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({ const { useAgentWorkflowTabBindingStore } = await import('../../../stores/agent/agentWorkflowTabBindingStore') +const { useAgentPanelStore } = + await import('../../../stores/agent/agentPanelStore') function mount(workflowId: string, name?: string) { return render(TabLinkCard, { @@ -57,8 +64,10 @@ describe('TabLinkCard', () => { localStorage.clear() setActivePinia(createPinia()) mocks.openWorkflow.mockClear() + mocks.navigate.mockClear() mocks.activeWorkflow = undefined openTabs() + useAgentPanelStore().enabled = true }) it('uses the backend display name and focuses the bound tab on click', async () => { @@ -182,4 +191,38 @@ describe('TabLinkCard', () => { expect(screen.queryByRole('button')).not.toBeInTheDocument() }) + + it('renders no reference and performs no action while the flag is off', () => { + const tab = { path: 'flows/portrait.json', filename: 'portrait' } + openTabs(tab) + useAgentWorkflowTabBindingStore().bind('wf-1', tab.path) + useAgentPanelStore().enabled = false + + mount('wf-1', 'Portrait upscale') + + expect(screen.queryByRole('button')).not.toBeInTheDocument() + expect(mocks.openWorkflow).not.toHaveBeenCalled() + }) + + it('navigates an explicit node reference through its target workflow', async () => { + const tab = { path: 'flows/portrait.json', filename: 'portrait' } + openTabs(tab) + useAgentWorkflowTabBindingStore().bind('wf-1', tab.path) + + render(TabLinkCard, { + props: { + workflowId: 'wf-1', + locatorId: 'root-a:42', + name: 'Portrait upscale' + }, + global: { plugins: [i18n] } + }) + await userEvent.click(screen.getByRole('button')) + + expect(mocks.navigate).toHaveBeenCalledWith({ + workflowId: 'wf-1', + locatorId: 'root-a:42' + }) + expect(mocks.openWorkflow).not.toHaveBeenCalled() + }) }) diff --git a/src/workbench/extensions/agent/components/agent/message/TabLinkCard.vue b/src/workbench/extensions/agent/components/agent/message/TabLinkCard.vue index 9c85b75ce28..24aa5e2afef 100644 --- a/src/workbench/extensions/agent/components/agent/message/TabLinkCard.vue +++ b/src/workbench/extensions/agent/components/agent/message/TabLinkCard.vue @@ -1,16 +1,20 @@