From e5fa12d2b19e142738771441b3f543d76527f6e2 Mon Sep 17 00:00:00 2001 From: jaeone lee <89377375+jaeone94@users.noreply.github.com> Date: Fri, 28 Aug 2026 09:41:47 +0000 Subject: [PATCH] fix: clarify missing core node version warning (#16166) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before 스크린샷 2026-08-28 오후 1 30 32 After 스크린샷 2026-08-28 오후 1 30 42 --- .../rightSidePanel/errors/MissingNodeCard.test.ts | 12 +++++++----- .../rightSidePanel/errors/MissingNodeCard.vue | 4 ++-- src/locales/en/main.json | 4 ++-- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/components/rightSidePanel/errors/MissingNodeCard.test.ts b/src/components/rightSidePanel/errors/MissingNodeCard.test.ts index 1f6fbdc0c3f..f685e4f31be 100644 --- a/src/components/rightSidePanel/errors/MissingNodeCard.test.ts +++ b/src/components/rightSidePanel/errors/MissingNodeCard.test.ts @@ -95,10 +95,10 @@ const i18n = createI18n({ } }, loadWorkflowWarning: { - outdatedVersion: - 'Some nodes require a newer version of ComfyUI (current: {version}).', - outdatedVersionGeneric: - 'Some nodes require a newer version of ComfyUI.', + newerVersionRequired: + 'Some nodes require a newer version of ComfyUI (current: {version}). Please update to use all nodes.', + newerVersionRequiredGeneric: + 'Some nodes require a newer version of ComfyUI. Please update to use all nodes.', coreNodesFromVersion: 'Requires ComfyUI {version}:', unknownVersion: 'unknown' } @@ -311,7 +311,9 @@ describe('MissingNodeCard', () => { } renderCard() expect( - screen.getByText('Some nodes require a newer version of ComfyUI.') + screen.getByText( + 'Some nodes require a newer version of ComfyUI. Please update to use all nodes.' + ) ).toBeInTheDocument() }) diff --git a/src/components/rightSidePanel/errors/MissingNodeCard.vue b/src/components/rightSidePanel/errors/MissingNodeCard.vue index c6fc9af2160..2fefe38f8be 100644 --- a/src/components/rightSidePanel/errors/MissingNodeCard.vue +++ b/src/components/rightSidePanel/errors/MissingNodeCard.vue @@ -14,10 +14,10 @@

{{ currentComfyUIVersion - ? t('loadWorkflowWarning.outdatedVersion', { + ? t('loadWorkflowWarning.newerVersionRequired', { version: currentComfyUIVersion }) - : t('loadWorkflowWarning.outdatedVersionGeneric') + : t('loadWorkflowWarning.newerVersionRequiredGeneric') }}