From ada08c6b58f9bc3b5d7fcc0875c6a1c258322681 Mon Sep 17 00:00:00 2001 From: bymyself Date: Sun, 23 Aug 2026 07:02:03 +0000 Subject: [PATCH] fix(nodeDataStore): log console.error on id collision to match linkStore/rerouteStore Silent rejection made genuine identity violations indistinguishable from ordinary id collisions at the call site, causing the re-mint loop in LGraph.ts to silently rename nodes without any console signal. Co-Authored-By: Claude Sonnet 4.6 --- src/stores/nodeDataStore.test.ts | 10 +++++++++- src/stores/nodeDataStore.ts | 7 ++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/stores/nodeDataStore.test.ts b/src/stores/nodeDataStore.test.ts index dc813a668a1..f60087893d0 100644 --- a/src/stores/nodeDataStore.test.ts +++ b/src/stores/nodeDataStore.test.ts @@ -1,6 +1,6 @@ import { createTestingPinia } from '@pinia/testing' import { setActivePinia } from 'pinia' -import { assert, beforeEach, describe, expect, it } from 'vitest' +import { assert, beforeEach, describe, expect, it, vi } from 'vitest' import { computed } from 'vue' import { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph' @@ -66,28 +66,36 @@ describe('useNodeDataStore', () => { const store = useNodeDataStore() const first = node(1) const duplicate = node(1, 'sub-1') + const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) const registered = store.registerNode(graphScope(rootA, rootA), first) const rejected = store.registerNode(graphScope(rootA, 'sub-1'), duplicate) expect(registered?.id).toBe(first.id) expect(rejected).toBeUndefined() + expect(errorSpy).toHaveBeenCalledOnce() + expect(errorSpy.mock.calls[0][0]).toMatch(/belongs to graph/) expect(duplicate.graphId).toBe('sub-1') expect(store.getGraphNodesFor(rootA, rootA)).toEqual([registered]) expect(store.getGraphNodesFor(rootA, 'sub-1')).toEqual([]) + errorSpy.mockRestore() }) it('rejects the registered node identity from a sibling owner', () => { const store = useNodeDataStore() const registered = node(1) store.registerNode(graphScope(rootA, rootA), registered) + const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {}) expect( store.registerNode(graphScope(rootA, 'sub-1'), registered) ).toBeUndefined() + expect(errorSpy).toHaveBeenCalledOnce() + expect(errorSpy.mock.calls[0][0]).toMatch(/belongs to graph/) expect(registered.graphId).toBe(rootA) expect(store.getGraphNodesFor(rootA, rootA)).toEqual([registered]) expect(store.getGraphNodesFor(rootA, 'sub-1')).toEqual([]) + errorSpy.mockRestore() }) it('only deletes the registered identity from its owning graph', () => { diff --git a/src/stores/nodeDataStore.ts b/src/stores/nodeDataStore.ts index 9e80a33a5d4..0ed5f46eaa3 100644 --- a/src/stores/nodeDataStore.ts +++ b/src/stores/nodeDataStore.ts @@ -53,7 +53,12 @@ export const useNodeDataStore = defineStore('nodeData', () => { incumbent.graphId === graphScope.owningGraphId ) return incumbent - if (incumbent) return undefined + if (incumbent) { + console.error( + `Node ${state.id} belongs to graph ${incumbent.graphId}; graph ${graphScope.owningGraphId} cannot overwrite it.` + ) + return undefined + } const bucket = existingBucket ?? rootBucket(graphScope.rootGraphId) const registered: NodeState = reactive( Object.assign(state, { graphId: graphScope.owningGraphId })