From 87bb8691a1dc26d236abbf0c2b1177ca9703f5d1 Mon Sep 17 00:00:00 2001 From: Christian Byrne Date: Tue, 18 Aug 2026 15:49:40 -0700 Subject: [PATCH] ci(binary-size): stop re-triggering on label changes `ci-binary-size-validation.yaml` subscribes to the `labeled` and `unlabeled` pull_request event types while using a concurrency group with `cancel-in-progress: true`. Any label write therefore starts a second run on the identical commit and cancels the one already in flight. A label change cannot alter a bundle's size, so there is nothing for the job to re-evaluate. The `allow-large-binaries` bypass is still read from `github.event.pull_request.labels.*.name` and is re-evaluated on the next `synchronize`. Measured over 819 runs (2026-08-16 -> 08-18): 164 cancelled (20.0%), and 163 of those 164 (99.4%) were superseded by a later run on the *same* head SHA, median 2s apart -- not by a push. --- .github/workflows/ci-binary-size-validation.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-binary-size-validation.yaml b/.github/workflows/ci-binary-size-validation.yaml index cd4b1c8c629..ece656079ec 100644 --- a/.github/workflows/ci-binary-size-validation.yaml +++ b/.github/workflows/ci-binary-size-validation.yaml @@ -4,7 +4,7 @@ name: 'CI: Binary Size Validation' on: pull_request: - types: [opened, synchronize, reopened, labeled, unlabeled] + types: [opened, synchronize, reopened] merge_group: types: [checks_requested]