From dd2020a911c81ad55443b8810fe88af1799c9f64 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 9 Aug 2026 02:31:39 +0000 Subject: [PATCH 1/2] fix: fall through to interior widget value for null host widgets_values A null entry in a subgraph host's widgets_values meant "no host override, use the interior widget's value" pre-1.47. After the ADR-0009 widget-store refactor, null was instead written straight into the promoted widget's store entry, so it read back as undefined and legacy workflows (including files following the documented #13601 recovery workaround) opened with dead promoted widgets. Treat null as a no-op write in both places it can reach the store: the positional widgets_values restore path and the promoted widget's value/callback bridge (the latter is also hit by LGraphNode's generic per-widget widgets_values assignment). This restores the pre-1.47 fallthrough semantics without changing behavior for any non-null value. Fixes #14488 --- .../litegraph/src/subgraph/SubgraphNode.ts | 5 +++- .../subgraph/SubgraphWidgetPromotion.test.ts | 27 +++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/src/lib/litegraph/src/subgraph/SubgraphNode.ts b/src/lib/litegraph/src/subgraph/SubgraphNode.ts index 3b9efa1b4fc..25f2c984e99 100644 --- a/src/lib/litegraph/src/subgraph/SubgraphNode.ts +++ b/src/lib/litegraph/src/subgraph/SubgraphNode.ts @@ -294,6 +294,7 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph { return isWidgetValue(value) ? value : undefined }, set value(next) { + if (next === null) return store.setValue(id, next) }, // Canvas edits operate on a transient concrete widget (toConcreteWidget), @@ -301,6 +302,7 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph { // its own local state and then calls this callback, which is the only // bridge back to the store. callback(next) { + if (next === null) return store.setValue(id, next) } } @@ -498,7 +500,8 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph { const value = quarantineValuesByInputName.get(input.name) ?? widgetValues?.[valueIndex] - if (value !== undefined) { + // `null` means "no host override" — keep the interior widget's value. + if (value !== undefined && value !== null) { useWidgetValueStore().setValue(input.widgetId, value) } valueIndex += 1 diff --git a/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts b/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts index 2ee08421246..18e658725e3 100644 --- a/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts +++ b/src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts @@ -1133,6 +1133,33 @@ describe('SubgraphWidgetPromotion', () => { 'second host value' ]) }) + + it('falls through to the interior widget value when a legacy host entry is null', () => { + const subgraph = createTestSubgraph() + buildSources(subgraph, NUMBER_PAIR) + + const host = createTestSubgraphNode(subgraph, { id: 101 }) + const serialized = host.serialize() + + const widgetStore = useWidgetValueStore() + widgetStore.clearGraph(host.rootGraph.id) + const reloaded = createTestSubgraphNode(subgraph, { id: 101 }) + reloaded.configure({ + ...serialized, + widgets_values: fromAny([null, null]) + }) + + expect( + widgetStore.getWidget( + widgetId(reloaded.rootGraph.id, reloaded.id, 'first') + )?.value + ).toBe(1) + expect( + widgetStore.getWidget( + widgetId(reloaded.rootGraph.id, reloaded.id, 'second') + )?.value + ).toBe(2) + }) }) describe('proxyWidgets is no longer re-emitted', () => { From bb55c707b86330dfcb06e971546f7362b50ace06 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 9 Aug 2026 02:50:40 +0000 Subject: [PATCH 2/2] fix: drop retired team_workspaces_enabled from e2e workspace fixture RemoteConfig no longer has this field after #14613 retired the team workspace rollout flag, which broke typecheck:browser in CI. --- browser_tests/fixtures/data/workspaceAuthFixtures.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/browser_tests/fixtures/data/workspaceAuthFixtures.ts b/browser_tests/fixtures/data/workspaceAuthFixtures.ts index 3b5c2abe72a..9f96ee229d0 100644 --- a/browser_tests/fixtures/data/workspaceAuthFixtures.ts +++ b/browser_tests/fixtures/data/workspaceAuthFixtures.ts @@ -2,9 +2,7 @@ import type { RemoteConfig } from '@/platform/remoteConfig/types' import type { WorkspaceWithRole } from '@/platform/workspace/api/workspaceApi' import type { WorkspaceTokenResponse } from '@/platform/workspace/stores/workspaceAuthStore' -export const mockWorkspacesRemoteConfig: RemoteConfig = { - team_workspaces_enabled: true -} +export const mockWorkspacesRemoteConfig: RemoteConfig = {} export const mockPersonalWorkspace: WorkspaceWithRole = { id: 'ws-personal',