From 3cc5ad9d72786a7293fdf186ef030c15df633544 Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Tue, 4 Aug 2026 11:47:07 +0900 Subject: [PATCH 1/7] test: add failing coverage for promoted advanced widgets --- .../tests/subgraph/subgraphPromotion.spec.ts | 49 +++++++++++++++ .../composables/useProcessedWidgets.test.ts | 61 +++++++++++++++++++ 2 files changed, 110 insertions(+) diff --git a/browser_tests/tests/subgraph/subgraphPromotion.spec.ts b/browser_tests/tests/subgraph/subgraphPromotion.spec.ts index b7ebc8fea3d..74230749ba7 100644 --- a/browser_tests/tests/subgraph/subgraphPromotion.spec.ts +++ b/browser_tests/tests/subgraph/subgraphPromotion.spec.ts @@ -94,6 +94,55 @@ test.describe( 'Promoted Widget Visibility in Vue Mode', { tag: ['@vue-nodes'] }, () => { + test( + 'Promoted advanced widget remains visible when global advanced widgets are disabled', + { tag: ['@node'] }, + async ({ comfyPage }) => { + await comfyPage.settings.setSetting( + 'Comfy.Node.AlwaysShowAdvancedWidgets', + false + ) + const modelSamplingNode = await comfyPage.nodeOps.addNode( + 'ModelSamplingFlux', + {}, + { x: 500, y: 200 } + ) + await comfyPage.nextFrame() + await expect( + comfyPage.vueNodes.getNodeLocator(String(modelSamplingNode.id)) + ).toBeVisible() + + await modelSamplingNode.click('title') + const subgraphNode = await modelSamplingNode.convertToSubgraph() + const subgraphNodeId = String(subgraphNode.id) + + await comfyPage.vueNodes.enterSubgraph(subgraphNodeId) + const interiorNode = + comfyPage.vueNodes.getNodeByTitle('ModelSamplingFlux') + await expect(interiorNode).toBeVisible() + await interiorNode + .getByText('Show advanced inputs', { exact: true }) + .click() + await expect( + interiorNode.getByLabel('max_shift', { exact: true }) + ).toBeVisible() + await comfyPage.subgraph.promoteWidget(interiorNode, 'max_shift') + await comfyPage.subgraph.exitViaBreadcrumb() + + await expectPromotedWidgetNamesToContain( + comfyPage, + subgraphNodeId, + 'max_shift' + ) + + await expect( + comfyPage.vueNodes + .getNodeLocator(subgraphNodeId) + .getByLabel('max_shift', { exact: true }) + ).toBeVisible() + } + ) + test('Promoted text widget renders and enters the subgraph in Vue mode', async ({ comfyPage }) => { diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index 9658abe7ad8..08efa0390d7 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -9,14 +9,22 @@ import { toNodeId } from '@/types/nodeId' import type * as GraphTraversalUtil from '@/utils/graphTraversalUtil' import type { SafeWidgetData } from '@/composables/graph/useGraphNodeManager' +import { extractVueNodeData } from '@/composables/graph/useGraphNodeManager' +import { promoteValueWidgetViaSubgraphInput } from '@/core/graph/subgraph/promotionUtils' import { computeProcessedWidgets, getWidgetIdentity, hasWidgetError, isWidgetVisible } from '@/renderer/extensions/vueNodes/composables/useProcessedWidgets' +import { LGraphNode } from '@/lib/litegraph/src/litegraph' +import { + createTestSubgraph, + createTestSubgraphNode +} from '@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers' import { useExecutionErrorStore } from '@/stores/executionErrorStore' import { useMissingModelStore } from '@/platform/missingModel/missingModelStore' +import { app } from '@/scripts/app' import { useWidgetValueStore } from '@/stores/widgetValueStore' import { createNodeExecutionId, @@ -310,6 +318,59 @@ const noopUi = { handleNodeRightClick: () => {} } +describe('computeProcessedWidgets visibility', () => { + beforeEach(() => { + setActivePinia(createTestingPinia({ stubActions: false })) + }) + + it('keeps a promoted advanced widget visible when advanced widgets are hidden', () => { + const subgraph = createTestSubgraph() + const subgraphNode = createTestSubgraphNode(subgraph) + subgraph.rootGraph.add(subgraphNode) + + const interiorNode = new LGraphNode('ModelSamplingFlux') + const interiorInput = interiorNode.addInput('max_shift', 'FLOAT') + const interiorWidget = interiorNode.addWidget( + 'number', + 'max_shift', + 1, + () => {}, + { advanced: true } + ) + interiorInput.widget = { name: interiorWidget.name } + subgraph.add(interiorNode) + + const promotion = promoteValueWidgetViaSubgraphInput( + subgraphNode, + interiorNode, + interiorWidget + ) + expect(promotion.ok).toBe(true) + + const rootGraphSpy = vi + .spyOn(app, 'rootGraph', 'get') + .mockReturnValue(subgraph.rootGraph) + try { + const processedWidgets = computeProcessedWidgets({ + nodeData: extractVueNodeData(subgraphNode), + graphId: subgraph.rootGraph.id, + showAdvanced: false, + isGraphReady: false, + rootGraph: null, + ui: noopUi + }) + const promotedWidget = processedWidgets.find( + (widget) => widget.name === 'max_shift' + ) + + expect(promotedWidget).toBeDefined() + expect(promotedWidget?.visible).toBe(true) + } finally { + rootGraphSpy.mockRestore() + } + }) +}) + describe('computeProcessedWidgets borderStyle', () => { beforeEach(() => { setActivePinia(createTestingPinia({ stubActions: false })) From 736f2d8b3200a89eb689b9c7b9eceb08961813f9 Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Tue, 4 Aug 2026 12:49:52 +0900 Subject: [PATCH 2/7] fix: show promoted advanced widgets on subgraph nodes --- .../extensions/vueNodes/composables/useProcessedWidgets.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts index e7e5549d590..00ab523ccc0 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts @@ -210,11 +210,11 @@ function getWidgetNodeLocatorId( export function isWidgetVisible( options: IWidgetOptions, showAdvanced: boolean, - linked = false + ignoreAdvanced = false ): boolean { const hidden = options.hidden ?? false const advanced = options.advanced ?? false - return !hidden && (!advanced || showAdvanced || linked) + return !hidden && (!advanced || showAdvanced || ignoreAdvanced) } export function computeProcessedWidgets({ @@ -268,10 +268,11 @@ export function computeProcessedWidgets({ ...(widget.options ?? {}), ...(widgetState?.options ?? {}) } + const isPromotedWidget = widget.sourceWidgetName !== undefined const visible = isWidgetVisible( mergedOptions, showAdvanced, - widget.slotMetadata?.linked + widget.slotMetadata?.linked || isPromotedWidget ) if (!identity.dedupeIdentity) { uniqueWidgets.push({ From 0c9529e999c83c19e0e112d6afe5f0a907d07d7e Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Tue, 4 Aug 2026 14:16:34 +0900 Subject: [PATCH 3/7] fix: identify promoted widgets at the host boundary --- src/composables/graph/useGraphNodeManager.ts | 2 ++ .../vueNodes/composables/useProcessedWidgets.test.ts | 12 ++++++++++-- .../vueNodes/composables/useProcessedWidgets.ts | 3 +-- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/composables/graph/useGraphNodeManager.ts b/src/composables/graph/useGraphNodeManager.ts index 60e41bbed8e..d0ae72cbb82 100644 --- a/src/composables/graph/useGraphNodeManager.ts +++ b/src/composables/graph/useGraphNodeManager.ts @@ -48,6 +48,7 @@ export interface WidgetSlotMetadata { linked: boolean originNodeId?: NodeId originOutputName?: string + promoted: boolean type: string } @@ -352,6 +353,7 @@ function buildSlotMetadata( linked: input.link != null, originNodeId, originOutputName, + promoted: input.widgetId !== undefined, type: String(input.type) } if (input.name) metadata.set(input.name, slotInfo) diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index 08efa0390d7..319996f9d19 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -323,7 +323,7 @@ describe('computeProcessedWidgets visibility', () => { setActivePinia(createTestingPinia({ stubActions: false })) }) - it('keeps a promoted advanced widget visible when advanced widgets are hidden', () => { + it('keeps a promoted advanced widget visible without source metadata', () => { const subgraph = createTestSubgraph() const subgraphNode = createTestSubgraphNode(subgraph) subgraph.rootGraph.add(subgraphNode) @@ -351,8 +351,16 @@ describe('computeProcessedWidgets visibility', () => { .spyOn(app, 'rootGraph', 'get') .mockReturnValue(subgraph.rootGraph) try { + const nodeData = extractVueNodeData(subgraphNode) const processedWidgets = computeProcessedWidgets({ - nodeData: extractVueNodeData(subgraphNode), + nodeData: { + ...nodeData, + widgets: nodeData.widgets?.map((widget) => ({ + ...widget, + sourceExecutionId: undefined, + sourceWidgetName: undefined + })) + }, graphId: subgraph.rootGraph.id, showAdvanced: false, isGraphReady: false, diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts index 00ab523ccc0..48b303f0a74 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.ts @@ -268,11 +268,10 @@ export function computeProcessedWidgets({ ...(widget.options ?? {}), ...(widgetState?.options ?? {}) } - const isPromotedWidget = widget.sourceWidgetName !== undefined const visible = isWidgetVisible( mergedOptions, showAdvanced, - widget.slotMetadata?.linked || isPromotedWidget + widget.slotMetadata?.linked || widget.slotMetadata?.promoted ) if (!identity.dedupeIdentity) { uniqueWidgets.push({ From 60f98bda246239b9835ef111dd00b2ff00634cd9 Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Fri, 7 Aug 2026 22:00:29 +0900 Subject: [PATCH 4/7] fix: address promoted widget review feedback - keep selected advanced widgets visible in app mode - pin promoted slot metadata at its producer boundary - simplify and clarify promoted visibility coverage --- .../builder/AppModeWidgetList.test.ts | 154 ++++++++++++++++++ src/components/builder/AppModeWidgetList.vue | 1 + .../graph/useGraphNodeManager.test.ts | 4 +- .../composables/useProcessedWidgets.test.ts | 78 ++------- 4 files changed, 176 insertions(+), 61 deletions(-) create mode 100644 src/components/builder/AppModeWidgetList.test.ts diff --git a/src/components/builder/AppModeWidgetList.test.ts b/src/components/builder/AppModeWidgetList.test.ts new file mode 100644 index 00000000000..2c9c15c895b --- /dev/null +++ b/src/components/builder/AppModeWidgetList.test.ts @@ -0,0 +1,154 @@ +import { createTestingPinia } from '@pinia/testing' +import { render, screen } from '@testing-library/vue' +import { fromAny } from '@total-typescript/shoehorn' +import { setActivePinia } from 'pinia' +import { createI18n } from 'vue-i18n' +import { beforeEach, describe, expect, it, vi } from 'vitest' + +import type { VueNodeData } from '@/composables/graph/useGraphNodeManager' +import type { LGraphNode } from '@/lib/litegraph/src/LGraphNode' +import { LGraphEventMode } from '@/lib/litegraph/src/types/globalEnums' +import type { IBaseWidget } from '@/lib/litegraph/src/types/widgets' +import { toNodeId } from '@/types/nodeId' +import type { WidgetId } from '@/types/widgetId' + +import AppModeWidgetList from './AppModeWidgetList.vue' + +const mocks = vi.hoisted(() => ({ + extractVueNodeData: vi.fn(), + resolvedInputs: { value: [] as unknown[] } +})) + +vi.mock('@/components/builder/useResolvedSelectedInputs', () => ({ + useResolvedSelectedInputs: () => mocks.resolvedInputs +})) + +vi.mock('@/composables/graph/useGraphNodeManager', () => ({ + extractVueNodeData: mocks.extractVueNodeData +})) + +vi.mock('@/composables/maskeditor/useMaskEditor', () => ({ + useMaskEditor: () => ({ openMaskEditor: vi.fn() }) +})) + +vi.mock('@/renderer/core/canvas/canvasStore', () => ({ + useCanvasStore: () => ({ + canvas: { graph: { rootGraph: { id: 'graph-test' } } } + }) +})) + +vi.mock( + '@/renderer/extensions/vueNodes/composables/useNodeEventHandlers', + () => ({ + useNodeEventHandlers: () => ({ handleNodeRightClick: vi.fn() }) + }) +) + +vi.mock('@/renderer/extensions/vueNodes/composables/useNodeTooltips', () => ({ + useNodeTooltips: () => ({ + createTooltipConfig: () => ({}), + getWidgetTooltip: () => '' + }) +})) + +vi.mock( + '@/renderer/extensions/vueNodes/widgets/registry/widgetRegistry', + () => ({ + getComponent: () => ({ + props: ['widget'], + template: '
' + }), + shouldExpand: () => false, + shouldRenderAsVue: () => true + }) +) + +vi.mock('@/scripts/app', () => ({ + app: { + isGraphReady: false, + rootGraph: { id: 'graph-test' } + } +})) + +const i18n = createI18n({ + legacy: false, + locale: 'en', + messages: { + en: { + g: { remove: 'Remove', rename: 'Rename' } + } + } +}) + +describe('AppModeWidgetList', () => { + beforeEach(() => { + const widgetId = 'graph-test:1:max_shift' as WidgetId + const widget = fromAny({ + label: 'Max shift', + name: 'max_shift', + widgetId + }) + const node = fromAny({ + id: toNodeId(1), + mode: LGraphEventMode.ALWAYS, + title: 'Subgraph', + type: 'SubgraphNode' + }) + const nodeData: VueNodeData = { + executing: false, + id: toNodeId(1), + inputs: [], + mode: LGraphEventMode.ALWAYS, + outputs: [], + selected: false, + title: 'Subgraph', + type: 'SubgraphNode', + widgets: [ + { + name: 'max_shift', + options: { advanced: true }, + slotMetadata: { + index: 0, + linked: false, + promoted: true, + type: 'FLOAT' + }, + type: 'number', + widgetId + } + ] + } + + mocks.resolvedInputs.value = [ + { + displayName: 'max_shift', + node, + status: 'resolved', + widget, + widgetId + } + ] + mocks.extractVueNodeData.mockReturnValue(nodeData) + }) + + it('renders a selected promoted advanced widget', () => { + const pinia = createTestingPinia({ stubActions: false }) + setActivePinia(pinia) + + render(AppModeWidgetList, { + global: { + directives: { tooltip: { mounted: () => {} } }, + plugins: [pinia, i18n], + stubs: { + Button: { template: '' }, + DropZone: { template: '
' }, + InputSlot: true, + Popover: { template: '
' }, + WidgetDescription: true + } + } + }) + + expect(screen.getByTestId('advanced-widget-control')).toBeVisible() + }) +}) diff --git a/src/components/builder/AppModeWidgetList.vue b/src/components/builder/AppModeWidgetList.vue index 61de44ba4e0..26d905e69ec 100644 --- a/src/components/builder/AppModeWidgetList.vue +++ b/src/components/builder/AppModeWidgetList.vue @@ -87,6 +87,7 @@ const mappedSelections = computed((): WidgetEntry[] => { description: config?.description, nodeData: { ...fullNodeData, + showAdvanced: true, widgets: [matchingWidget] }, action: { widget, node } diff --git a/src/composables/graph/useGraphNodeManager.test.ts b/src/composables/graph/useGraphNodeManager.test.ts index 742f99f0f2e..d50f8a7bf64 100644 --- a/src/composables/graph/useGraphNodeManager.test.ts +++ b/src/composables/graph/useGraphNodeManager.test.ts @@ -112,7 +112,7 @@ describe('Widget slotMetadata reactivity on link disconnect', () => { return { graph, node, upstream, linkId: link.id } } - it('sets slotMetadata.linked to true when input has a link', () => { + it('identifies a linked regular widget input as unpromoted', () => { const { graph, node } = createWidgetInputGraph() const { vueNodeData } = useGraphNodeManager(graph) @@ -121,6 +121,7 @@ describe('Widget slotMetadata reactivity on link disconnect', () => { expect(widgetData?.slotMetadata).toBeDefined() expect(widgetData?.slotMetadata?.linked).toBe(true) + expect(widgetData?.slotMetadata?.promoted).toBe(false) }) it('updates slotMetadata.linked to false after link disconnect event', async () => { @@ -236,6 +237,7 @@ describe('Widget slotMetadata reactivity on link disconnect', () => { expect(widgetData).toBeDefined() expect(widgetData?.sourceWidgetName).toBe('prompt') expect(widgetData?.slotMetadata).toBeDefined() + expect(widgetData?.slotMetadata?.promoted).toBe(true) }) it('clears stale slotMetadata when input no longer matches widget', async () => { diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index 75284f1a12c..2e2440e55da 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -4,15 +4,9 @@ import { setActivePinia } from 'pinia' import { fromAny } from '@total-typescript/shoehorn' import { beforeEach, describe, expect, it, vi } from 'vitest' -import { LGraphNode } from '@/lib/litegraph/src/litegraph' import type { LGraph } from '@/lib/litegraph/src/litegraph' -import { - createTestSubgraph, - createTestSubgraphNode -} from '@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers' import { useMissingMediaStore } from '@/platform/missingMedia/missingMediaStore' import { useMissingModelStore } from '@/platform/missingModel/missingModelStore' -import { app } from '@/scripts/app' import { useExecutionErrorStore } from '@/stores/executionErrorStore' import { useWidgetValueStore } from '@/stores/widgetValueStore' import { @@ -24,8 +18,6 @@ import { widgetId } from '@/types/widgetId' import type * as GraphTraversalUtil from '@/utils/graphTraversalUtil' import type { SafeWidgetData } from '@/composables/graph/useGraphNodeManager' -import { extractVueNodeData } from '@/composables/graph/useGraphNodeManager' -import { promoteValueWidgetViaSubgraphInput } from '@/core/graph/subgraph/promotionUtils' import { computeProcessedWidgets, getWidgetIdentity, @@ -173,11 +165,11 @@ describe('isWidgetVisible', () => { expect(isWidgetVisible({ advanced: true }, true)).toBe(true) }) - it('keeps advanced widgets visible when linked and showAdvanced is false', () => { + it('keeps advanced widgets visible when advanced filtering is ignored', () => { expect(isWidgetVisible({ advanced: true }, false, true)).toBe(true) }) - it('keeps hidden widgets hidden when linked', () => { + it('keeps hidden widgets hidden when advanced filtering is ignored', () => { expect(isWidgetVisible({ hidden: true }, false, true)).toBe(false) }) }) @@ -422,58 +414,24 @@ describe('computeProcessedWidgets visibility', () => { }) it('keeps a promoted advanced widget visible without source metadata', () => { - const subgraph = createTestSubgraph() - const subgraphNode = createTestSubgraphNode(subgraph) - subgraph.rootGraph.add(subgraphNode) - - const interiorNode = new LGraphNode('ModelSamplingFlux') - const interiorInput = interiorNode.addInput('max_shift', 'FLOAT') - const interiorWidget = interiorNode.addWidget( - 'number', - 'max_shift', - 1, - () => {}, - { advanced: true } - ) - interiorInput.widget = { name: interiorWidget.name } - subgraph.add(interiorNode) + const widget = createMockWidget({ + name: 'max_shift', + type: 'number', + options: { advanced: true }, + slotMetadata: { + index: 0, + linked: false, + promoted: true, + type: 'FLOAT' + }, + sourceExecutionId: undefined, + sourceWidgetName: undefined + }) - const promotion = promoteValueWidgetViaSubgraphInput( - subgraphNode, - interiorNode, - interiorWidget - ) - expect(promotion.ok).toBe(true) - - const rootGraphSpy = vi - .spyOn(app, 'rootGraph', 'get') - .mockReturnValue(subgraph.rootGraph) - try { - const nodeData = extractVueNodeData(subgraphNode) - const processedWidgets = computeProcessedWidgets({ - nodeData: { - ...nodeData, - widgets: nodeData.widgets?.map((widget) => ({ - ...widget, - sourceExecutionId: undefined, - sourceWidgetName: undefined - })) - }, - graphId: subgraph.rootGraph.id, - showAdvanced: false, - isGraphReady: false, - rootGraph: null, - ui: noopUi - }) - const promotedWidget = processedWidgets.find( - (widget) => widget.name === 'max_shift' - ) + const promotedWidget = processWidgets([widget])[0] - expect(promotedWidget).toBeDefined() - expect(promotedWidget?.visible).toBe(true) - } finally { - rootGraphSpy.mockRestore() - } + expect(promotedWidget).toBeDefined() + expect(promotedWidget?.visible).toBe(true) }) }) From a5af157ff4d00c1b3dae47181ae295c626d5f657 Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Sun, 9 Aug 2026 16:18:37 +0900 Subject: [PATCH 5/7] fix: address follow-up review feedback --- src/components/builder/AppModeWidgetList.vue | 9 ++++++--- src/lib/litegraph/src/interfaces.ts | 1 + .../vueNodes/composables/useProcessedWidgets.test.ts | 3 +++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/components/builder/AppModeWidgetList.vue b/src/components/builder/AppModeWidgetList.vue index 26d905e69ec..914a519c142 100644 --- a/src/components/builder/AppModeWidgetList.vue +++ b/src/components/builder/AppModeWidgetList.vue @@ -77,8 +77,11 @@ const mappedSelections = computed((): WidgetEntry[] => { }) if (!matchingWidget) return [] - matchingWidget.slotMetadata = undefined - matchingWidget.nodeId = node.id + const projectedWidget = { + ...matchingWidget, + slotMetadata: undefined, + nodeId: node.id + } return [ { @@ -88,7 +91,7 @@ const mappedSelections = computed((): WidgetEntry[] => { nodeData: { ...fullNodeData, showAdvanced: true, - widgets: [matchingWidget] + widgets: [projectedWidget] }, action: { widget, node } } diff --git a/src/lib/litegraph/src/interfaces.ts b/src/lib/litegraph/src/interfaces.ts index 54be0fc9b13..26e0fcd4193 100644 --- a/src/lib/litegraph/src/interfaces.ts +++ b/src/lib/litegraph/src/interfaces.ts @@ -365,6 +365,7 @@ export interface IWidgetLocator { export interface INodeInputSlot extends INodeSlot { link: LinkId | null widget?: IWidgetLocator + /** Host-owned promoted widget identity for a subgraph input (ADR 0009). */ widgetId?: WidgetId alwaysVisible?: boolean diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index 2e2440e55da..6c570e09867 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -432,6 +432,9 @@ describe('computeProcessedWidgets visibility', () => { expect(promotedWidget).toBeDefined() expect(promotedWidget?.visible).toBe(true) + expect(promotedWidget?.simplified.borderStyle).toBe( + 'ring ring-component-node-widget-advanced' + ) }) }) From a5301d517bc4d1751f742182669fd2479d520a2f Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Sun, 9 Aug 2026 16:35:32 +0900 Subject: [PATCH 6/7] test: avoid coupling advanced ring coverage to classes --- .../vueNodes/composables/useProcessedWidgets.test.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index 6c570e09867..d94686e3415 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -432,9 +432,7 @@ describe('computeProcessedWidgets visibility', () => { expect(promotedWidget).toBeDefined() expect(promotedWidget?.visible).toBe(true) - expect(promotedWidget?.simplified.borderStyle).toBe( - 'ring ring-component-node-widget-advanced' - ) + expect(promotedWidget?.simplified.borderStyle).toBeDefined() }) }) From 65bef7542a49b55f41556e46a8c9fa40f2fae72a Mon Sep 17 00:00:00 2001 From: jaeone94 <89377375+jaeone94@users.noreply.github.com> Date: Mon, 17 Aug 2026 13:08:19 +0900 Subject: [PATCH 7/7] test: align widget test with shared Pinia setup --- .../vueNodes/composables/useProcessedWidgets.test.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts index d94686e3415..771d5cda45f 100644 --- a/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts +++ b/src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts @@ -409,10 +409,6 @@ describe('computeProcessedWidgets missing media', () => { }) describe('computeProcessedWidgets visibility', () => { - beforeEach(() => { - setActivePinia(createTestingPinia({ stubActions: false })) - }) - it('keeps a promoted advanced widget visible without source metadata', () => { const widget = createMockWidget({ name: 'max_shift',