From 4b1fc35e0c3789c717e1c0e837b79f2718e0add9 Mon Sep 17 00:00:00 2001 From: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Date: Sun, 2 Aug 2026 13:21:43 +0000 Subject: [PATCH 1/4] fix: flush workflow drafts before page unload Amp-Thread-ID: https://ampcode.com/threads/T-019fc29a-b52b-747c-8d2c-1b994ea9ea65 Co-authored-by: Amp --- .../useWorkflowPersistenceV2.test.ts | 25 +++++++++++++++++++ .../composables/useWorkflowPersistenceV2.ts | 9 ++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts index afe06e7b97f..f77744b958e 100644 --- a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts +++ b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts @@ -622,6 +622,31 @@ describe('useWorkflowPersistenceV2', () => { }) }) + it('flushes a pending workflow edit when the page is unloaded', async () => { + const workflowStore = useWorkflowStore() + const workflow = await workflowStore.createTemporary('Draft.json').load() + workflowStore.activeWorkflow = workflow + mountWorkflowPersistence() + await nextTick() + + mocks.state.currentGraph = { + nodes: [], + extra: { marker: 'final-edit' } + } + mocks.state.graphChangedHandler?.() + + const payloadKey = StorageKeys.draftPayload(workflow.path, 'personal') + expect(localStorage.getItem(payloadKey)).toBeNull() + + window.dispatchEvent(new PageTransitionEvent('pagehide')) + + const payload = JSON.parse(localStorage.getItem(payloadKey)!) + expect(JSON.parse(payload.data)).toEqual({ + nodes: [], + extra: { marker: 'final-edit' } + }) + }) + it('flushes the final source-workspace edit before blocking transition writes', async () => { const sourceWorkspaceId = 'workspace-a' const destinationWorkspaceId = 'workspace-b' diff --git a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts index 5b7661ad692..b1dbba9a5f2 100644 --- a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts +++ b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts @@ -134,9 +134,15 @@ export function useWorkflowPersistenceV2() { // Debounced version for graphChanged events const debouncedPersist = debounce(persistCurrentWorkflow, PERSIST_DEBOUNCE_MS) - const unregisterPersistenceFlush = registerWorkflowPersistenceFlush(() => + + function flushPendingPersistence() { debouncedPersist.flush() + } + + const unregisterPersistenceFlush = registerWorkflowPersistenceFlush( + flushPendingPersistence ) + window.addEventListener('pagehide', flushPendingPersistence) const loadPreviousWorkflowFromStorage = async () => { const sessionPath = tabState.getActivePath() @@ -259,6 +265,7 @@ export function useWorkflowPersistenceV2() { // Clean up event listener when component unmounts tryOnScopeDispose(() => { api.removeEventListener('graphChanged', debouncedPersist) + window.removeEventListener('pagehide', flushPendingPersistence) unregisterPersistenceFlush() debouncedPersist.cancel() }) From ec653121cf660c81afaf6b4b4b1145ea150ead70 Mon Sep 17 00:00:00 2001 From: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Date: Sun, 2 Aug 2026 13:28:32 +0000 Subject: [PATCH 2/4] test: cover workflow persistence disposal Amp-Thread-ID: https://ampcode.com/threads/T-019fc29a-b52b-747c-8d2c-1b994ea9ea65 Co-authored-by: Amp --- .../useWorkflowPersistenceV2.test.ts | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts index f77744b958e..340929f294c 100644 --- a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts +++ b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts @@ -647,6 +647,28 @@ describe('useWorkflowPersistenceV2', () => { }) }) + it('does not flush a pending workflow edit after disposal', async () => { + const workflowStore = useWorkflowStore() + const workflow = await workflowStore.createTemporary('Draft.json').load() + workflowStore.activeWorkflow = workflow + mountWorkflowPersistence() + + mocks.state.currentGraph = { nodes: [] } + mocks.state.graphChangedHandler?.() + + const mounted = mountedApps.pop() + if (!mounted) throw new Error('Failed to find mounted persistence app') + mounted.app.unmount() + mounted.container.remove() + + window.dispatchEvent(new PageTransitionEvent('pagehide')) + await vi.runAllTimersAsync() + + expect( + localStorage.getItem(StorageKeys.draftPayload(workflow.path, 'personal')) + ).toBeNull() + }) + it('flushes the final source-workspace edit before blocking transition writes', async () => { const sourceWorkspaceId = 'workspace-a' const destinationWorkspaceId = 'workspace-b' From 2d22f41bb60cecd4b120391ac859cd9997ed39f3 Mon Sep 17 00:00:00 2001 From: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Date: Sun, 2 Aug 2026 14:08:23 +0000 Subject: [PATCH 3/4] test: require pending persistence edit Amp-Thread-ID: https://ampcode.com/threads/T-019fc29a-b52b-747c-8d2c-1b994ea9ea65 Co-authored-by: Amp --- .../composables/useWorkflowPersistenceV2.test.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts index 340929f294c..c071b4c9bcc 100644 --- a/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts +++ b/src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts @@ -654,7 +654,11 @@ describe('useWorkflowPersistenceV2', () => { mountWorkflowPersistence() mocks.state.currentGraph = { nodes: [] } - mocks.state.graphChangedHandler?.() + const graphChangedHandler = mocks.state.graphChangedHandler + if (!graphChangedHandler) { + throw new Error('Graph change handler was not registered') + } + graphChangedHandler() const mounted = mountedApps.pop() if (!mounted) throw new Error('Failed to find mounted persistence app') From 0e63fcee13ef79b4ab813085811fa5acfa3462a0 Mon Sep 17 00:00:00 2001 From: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Date: Sun, 2 Aug 2026 14:14:15 +0000 Subject: [PATCH 4/4] test: cover immediate workflow refresh Amp-Thread-ID: https://ampcode.com/threads/T-019fc29a-b52b-747c-8d2c-1b994ea9ea65 Co-authored-by: Amp --- .../tests/workflowPersistence.spec.ts | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/browser_tests/tests/workflowPersistence.spec.ts b/browser_tests/tests/workflowPersistence.spec.ts index ee2e3f42c46..8439d95a9a8 100644 --- a/browser_tests/tests/workflowPersistence.spec.ts +++ b/browser_tests/tests/workflowPersistence.spec.ts @@ -534,6 +534,42 @@ test.describe('Workflow Persistence', () => { await expect(comfyPage.toast.toastErrors).toHaveCount(0) }) + test('Flushes a pending draft edit before an immediate reload', async ({ + comfyPage + }) => { + test.info().annotations.push({ + type: 'regression', + description: + 'FE-1484 — refreshing inside the persistence debounce window lost the latest workflow edit' + }) + + await comfyPage.settings.setSetting('Comfy.Workflow.Persist', true) + await comfyPage.workflow.loadWorkflow('nodes/single_ksampler') + await fitToViewInstant(comfyPage) + + const firstNode = await getRequiredFirstNodeRef( + comfyPage, + 'First node should be available after loading single_ksampler' + ) + await firstNode.centerOnNode() + + const baselineSaveStartedAt = Date.now() + await firstNode.toggleCollapse() + await expect.poll(() => firstNode.isCollapsed()).toBe(true) + await comfyPage.workflow.waitForDraftIndexUpdatedSince( + baselineSaveStartedAt + ) + + await firstNode.toggleCollapse() + await comfyPage.workflow.reloadAndWaitForApp() + + const restoredNode = await getRequiredFirstNodeRef( + comfyPage, + 'First node should be restored after the immediate reload' + ) + await expect.poll(() => restoredNode.isCollapsed()).toBe(false) + }) + test('Closing an inactive tab with save preserves its own content', async ({ comfyPage }) => {