From a7eb1f38dbf3b99aebfd07fed33d3fe5af207c01 Mon Sep 17 00:00:00 2001 From: Mariana Martinho Date: Tue, 10 Nov 2026 19:38:09 +0100 Subject: [PATCH 1/6] feat(ui): card groups for the build About tab Each group of facts sits in its own card with its title inside, and values line up in a column next to their labels instead of hugging the right edge, as in the New UI proposal. Co-Authored-By: Claude Opus 5.5 --- .../views/comfyUISettings/StatusFactPanel.vue | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/renderer/src/views/comfyUISettings/StatusFactPanel.vue b/src/renderer/src/views/comfyUISettings/StatusFactPanel.vue index 44f6fd01c..9571907c0 100644 --- a/src/renderer/src/views/comfyUISettings/StatusFactPanel.vue +++ b/src/renderer/src/views/comfyUISettings/StatusFactPanel.vue @@ -320,8 +320,8 @@ const groups = computed(() => { diff --git a/src/renderer/src/panel/BuildDetailsView.test.ts b/src/renderer/src/panel/BuildDetailsView.test.ts index 4a04c6c47..f5b8c7243 100644 --- a/src/renderer/src/panel/BuildDetailsView.test.ts +++ b/src/renderer/src/panel/BuildDetailsView.test.ts @@ -9,7 +9,7 @@ import type { Installation } from '../types/ipc' vi.mock('../components/settings/ComfyUISettingsContent.vue', () => ({ default: { name: 'ComfyUISettingsContent', - props: ['installation', 'globalSettingsSnapshot', 'pageActionsTarget'], + props: ['installation', 'globalSettingsSnapshot', 'pageActionsTarget', 'pageTitleTarget'], emits: [ 'show-progress', 'navigate-list', @@ -18,7 +18,8 @@ vi.mock('../components/settings/ComfyUISettingsContent.vue', () => ({ 'primary-action', 'open-new-window' ], - template: '
' + template: + '
{{ installation.name }}
' } })) @@ -51,7 +52,8 @@ beforeEach(() => { async function mountDetails(installation: Installation = INSTALL) { const wrapper = mount(BuildDetailsView, { - props: { installation } + props: { installation }, + attachTo: document.body }) await flushPromises() return { wrapper, content: wrapper.findComponent({ name: 'ComfyUISettingsContent' }) } @@ -79,12 +81,13 @@ describe('BuildDetailsView', () => { expect(wrapper.get('.build-details-status').text()).toBe('Running') }) - it('hands the settings body its build, shared storage and action slot', async () => { + it('hands the settings body its build, shared storage, title and action slots', async () => { const { content } = await mountDetails() expect(content.props('installation')).toEqual(INSTALL) expect(content.props('globalSettingsSnapshot')).toEqual(SNAPSHOT) expect(content.props('pageActionsTarget')).toBe('#build-details-actions') + expect(content.props('pageTitleTarget')).toBe('#build-details-title') }) it('launches the build from the primary action', async () => { diff --git a/src/renderer/src/panel/BuildDetailsView.vue b/src/renderer/src/panel/BuildDetailsView.vue index 05cc4efcd..a2bf3e690 100644 --- a/src/renderer/src/panel/BuildDetailsView.vue +++ b/src/renderer/src/panel/BuildDetailsView.vue @@ -11,6 +11,7 @@ import { useSessionStore } from '../stores/sessionStore' import type { Installation, ShowProgressOpts } from '../types/ipc' const ACTIONS_ID = 'build-details-actions' +const TITLE_ID = 'build-details-title' const { installation } = defineProps<{ installation: Installation @@ -91,10 +92,9 @@ onUnmounted(() => unsubscribeSettings?.())

- {{ installation.name }} -

+ :id="TITLE_ID" + class="m-0 flex min-w-0 text-[30px]/[1.15] font-semibold tracking-[-0.02em] text-foreground" + />