From 9699caca3446750a26c69c1fd82980af6e9476b7 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Sat, 10 Oct 2026 19:19:28 -0400 Subject: [PATCH] FE-3367 feat(telemetry): mirror Desktop SSO sign-in to Datadog --- src/shared/datadogMirroredEvents.test.ts | 10 ++++++++++ src/shared/datadogMirroredEvents.ts | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/src/shared/datadogMirroredEvents.test.ts b/src/shared/datadogMirroredEvents.test.ts index 65d72eca4..5eb934e8c 100644 --- a/src/shared/datadogMirroredEvents.test.ts +++ b/src/shared/datadogMirroredEvents.test.ts @@ -26,6 +26,16 @@ describe('isDatadogMirroredEvent', () => { expect(isDatadogMirroredEvent('comfy.desktop.install.dispatched')).toBe(false) }) + // The SSO dashboards and monitors live in Datadog, so the hosted-view sign-in + // mirrors every stage; the Firebase bridge's sign_in_started stays PostHog-only. + it.each([ + ['comfy.desktop.auth.host_sign_in', true], + ['comfy.desktop.auth.sign_in_failed', true], + ['comfy.desktop.auth.sign_in_started', false] + ])('mirrors %s: %s', (name, mirrored) => { + expect(isDatadogMirroredEvent(name)).toBe(mirrored) + }) + it('returns false for unknown event names', () => { expect(isDatadogMirroredEvent('comfy.desktop.not.a.real.event')).toBe(false) }) diff --git a/src/shared/datadogMirroredEvents.ts b/src/shared/datadogMirroredEvents.ts index 21bff25af..9701023da 100644 --- a/src/shared/datadogMirroredEvents.ts +++ b/src/shared/datadogMirroredEvents.ts @@ -82,6 +82,11 @@ export const DATADOG_MIRRORED_EVENT_NAMES: ReadonlySet = new Set([ // Sign-in failures — alert if a provider's auth bridge breaks (OAuth // config drift, IdP outage, loopback-port contention). 'comfy.desktop.auth.sign_in_failed', + // Hosted-view SSO sign-in, one event per stage (requested / completed / + // failed). Mirrored whole, like install.phase: the SSO dashboards and + // monitors live in Datadog and need requested/completed as the denominator; + // monitors filter on `stage:failed` and group by `reason` / `http_status`. + 'comfy.desktop.auth.host_sign_in', // SDK-level volume guards — Datadog should alert if either fires // because the call site is misbehaving (loop, missing dedup, etc.) // and the SDK had to step in. One emit per process per event-name.