Fix mixed-case folder prefixes in CLI tab completion

Found this while walking through the CLI code a lil bit. Matching ignores
case but sorting did not, so a + Tab with Alpha, Azure and alps returned
Alp and dropped a valid choice. Sort using the same lowercase comparison
and add two regressions for mixed-case directory names.

Author: Aaron-Savron

cli/src/__tests__/path-completion.test.ts

@@ -122,6 +122,26 @@ describe('getPathCompletion', () => {
     })
   })
 
+  describe('mixed-case common prefixes', () => {
+    test('does not extend past a directory between the sorted endpoints', () => {
+      for (const name of ['Alpha', 'Azure', 'alps']) {
+        mkdirSync(path.join(tempDir, name))
+      }
+
+      expect(getPathCompletion(path.join(tempDir, 'a'))).toBeNull()
+    })
+
+    test('extends only to the prefix shared by every mixed-case match', () => {
+      for (const name of ['ProjectAlpha', 'ProjectBeta', 'projectAlps']) {
+        mkdirSync(path.join(tempDir, name))
+      }
+
+      expect(getPathCompletion(path.join(tempDir, 'pro'))).toBe(
+        path.join(tempDir, 'Project'),
+      )
+    })
+  })
+
   describe('hidden directories', () => {
     test('skips hidden directories by default', () => {
       mkdirSync(path.join(tempDir, '.hidden'))

cli/src/utils/path-completion.ts

@@ -80,7 +80,11 @@ export function getPathCompletion(inputPath: string): string | null {
     }
 
     // Multiple matches - find common prefix
-    const sortedMatches = matches.sort()
+    const sortedMatches = matches.sort((a, b) => {
+      const lowerA = a.toLowerCase()
+      const lowerB = b.toLowerCase()
+      return lowerA < lowerB ? -1 : lowerA > lowerB ? 1 : 0
+    })
     const first = sortedMatches[0].toLowerCase()
     const last = sortedMatches[sortedMatches.length - 1].toLowerCase()
     let commonLength = partial.length