Skip to content

Commit 3bdbdca

Browse files
fix: satisfy shellcheck in setup preview scripts
Amp-Thread-ID: https://ampcode.com/threads/T-01a17775-d386-7387-88ab-c14a99ed558e Co-authored-by: Amp <amp@ampcode.com>
1 parent 9f6cc29 commit 3bdbdca

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎scripts/action/resolve-preview-prs.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ line="$(grep -oE '<!-- codeboarding:preview [0-9, ]+ -->' <<< "$body" | head -n
3030

3131
skip() { echo "::notice::Not previewing #$1: $2"; }
3232
seen=" "
33-
for pr in $(grep -oE '[0-9]+' <<< "${line#*preview}"); do
33+
while IFS= read -r pr; do
3434
[ "$count" -lt "$max" ] || { skip "$pr" "at most $max pull requests are previewed."; continue; }
3535
[ "$pr" != "$PR_NUMBER" ] || continue
3636
case "$seen" in *" $pr "*) continue ;; esac
@@ -53,5 +53,5 @@ for pr in $(grep -oE '[0-9]+' <<< "${line#*preview}"); do
5353
--arg title "$(jq -r '.title // ""' <<< "$json")" \
5454
'{pr_number: $pr, head_sha: $head_sha, merge_base_sha: $merge_base, title: $title}' > "$out/$count.json"
5555
prs="${prs:+$prs,}$pr"
56-
done
56+
done < <(grep -oE '[0-9]+' <<< "${line#*preview}")
5757
finish

‎scripts/action/review-preview-pr.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ n="$1"
1717
dir="${RUNNER_TEMP:?}/codeboarding-preview"
1818
entry="$dir/$n.json"
1919
[ -f "$entry" ] || exit 0
20+
: "${REPOSITORY:?}"
2021
IFS=$'\t' read -r pr head_sha pr_merge_base < <(jq -r '[.pr_number, .head_sha, .merge_base_sha] | @tsv' "$entry")
2122
title="$(jq -r '.title' "$entry")"
2223
base="$REVIEW_BASE_SHA"

0 commit comments

Comments
 (0)