From 825610ef9668f1152fb96a2fae394bf5f250304f Mon Sep 17 00:00:00 2001
From: ravimahatonp <motkishuruti@gmail.com>
Date: Thu, 1 Oct 2026 14:48:04 +0545
Subject: [PATCH] fix: add cross-validation for
 questions/user_answers/correct_answers list lengths

---
 src/routes/feedback.py            |  16 ++++-
 tests/test_feedback_validation.py | 106 ++++++++++++++++++++++++++++++
 2 files changed, 121 insertions(+), 1 deletion(-)
 create mode 100644 tests/test_feedback_validation.py

diff --git a/src/routes/feedback.py b/src/routes/feedback.py
index 7869f14..ada0adf 100644
--- a/src/routes/feedback.py
+++ b/src/routes/feedback.py
@@ -3,7 +3,7 @@
 import logging
 
 from fastapi import APIRouter, HTTPException
-from pydantic import BaseModel, Field
+from pydantic import BaseModel, Field, model_validator
 
 from src.models.quiz import QuizQuestion
 from src.services.feedback_engine import get_feedback_engine
@@ -23,6 +23,20 @@ class GenerateFeedbackRequest(BaseModel):
     score: float | None = Field(default=None, description="Score percentage (0-100)")
     topic: str = Field(default="", description="Quiz topic for context")
 
+    @model_validator(mode="after")
+    def validate_list_lengths(self) -> "GenerateFeedbackRequest":
+        """Ensure questions, user_answers, and correct_answers have the same length."""
+        n_questions = len(self.questions)
+        n_user = len(self.user_answers)
+        n_correct = len(self.correct_answers)
+        if not (n_questions == n_user == n_correct):
+            raise ValueError(
+                f"List length mismatch: questions={n_questions}, "
+                f"user_answers={n_user}, correct_answers={n_correct}. "
+                f"All three lists must have the same length."
+            )
+        return self
+
 
 class FeedbackResponse(BaseModel):
     """Response body for feedback endpoint."""
diff --git a/tests/test_feedback_validation.py b/tests/test_feedback_validation.py
new file mode 100644
index 0000000..4ad3476
--- /dev/null
+++ b/tests/test_feedback_validation.py
@@ -0,0 +1,106 @@
+"""Tests for feedback request list-length validation."""
+
+import pytest
+from pydantic import ValidationError
+
+from src.routes.feedback import GenerateFeedbackRequest
+
+
+def _make_question(prompt: str = "What is 1+1?") -> dict:
+    """Return a minimal QuizQuestion dict."""
+    return {
+        "prompt": prompt,
+        "options": ["1", "2", "3", "4"],
+        "correct_index": 1,
+        "explanation": "Basic arithmetic.",
+    }
+
+
+class TestFeedbackRequestListLengthValidation:
+    """Validate that mismatched list lengths are rejected."""
+
+    def test_matching_lengths_accepted(self):
+        """Equal-length lists should pass validation."""
+        req = GenerateFeedbackRequest(
+            quiz_id="q1",
+            questions=[_make_question(), _make_question()],
+            user_answers=[0, 1],
+            correct_answers=[1, 1],
+        )
+        assert len(req.questions) == 2
+        assert len(req.user_answers) == 2
+        assert len(req.correct_answers) == 2
+
+    def test_user_answers_shorter_rejected(self):
+        """Fewer user_answers than questions must raise."""
+        with pytest.raises(ValidationError, match="List length mismatch"):
+            GenerateFeedbackRequest(
+                quiz_id="q2",
+                questions=[_make_question(), _make_question(), _make_question()],
+                user_answers=[0],
+                correct_answers=[1, 1, 1],
+            )
+
+    def test_correct_answers_shorter_rejected(self):
+        """Fewer correct_answers than questions must raise."""
+        with pytest.raises(ValidationError, match="List length mismatch"):
+            GenerateFeedbackRequest(
+                quiz_id="q3",
+                questions=[_make_question(), _make_question()],
+                user_answers=[0, 1],
+                correct_answers=[1],
+            )
+
+    def test_extra_user_answers_rejected(self):
+        """More user_answers than questions must raise."""
+        with pytest.raises(ValidationError, match="List length mismatch"):
+            GenerateFeedbackRequest(
+                quiz_id="q4",
+                questions=[_make_question()],
+                user_answers=[0, 1, 2],
+                correct_answers=[1],
+            )
+
+    def test_all_three_different_lengths_rejected(self):
+        """All three lists with different lengths must raise."""
+        with pytest.raises(ValidationError, match="List length mismatch"):
+            GenerateFeedbackRequest(
+                quiz_id="q5",
+                questions=[_make_question()],
+                user_answers=[0, 1],
+                correct_answers=[1, 1, 1],
+            )
+
+    def test_empty_lists_accepted(self):
+        """Three empty lists have matching length (0) and should pass."""
+        req = GenerateFeedbackRequest(
+            quiz_id="q6",
+            questions=[],
+            user_answers=[],
+            correct_answers=[],
+        )
+        assert len(req.questions) == 0
+
+    def test_single_question_matching_accepted(self):
+        """Single-element lists should pass validation."""
+        req = GenerateFeedbackRequest(
+            quiz_id="q7",
+            questions=[_make_question()],
+            user_answers=[1],
+            correct_answers=[1],
+        )
+        assert len(req.questions) == 1
+
+    def test_error_message_includes_lengths(self):
+        """Rejection message should report actual lengths for debugging."""
+        with pytest.raises(ValidationError) as exc_info:
+            GenerateFeedbackRequest(
+                quiz_id="q8",
+                questions=[_make_question(), _make_question()],
+                user_answers=[0],
+                correct_answers=[1, 1],
+            )
+        error_text = str(exc_info.value)
+        assert "questions=2" in error_text
+        assert "user_answers=1" in error_text
+        assert "correct_answers=2" in error_text