From f9501b60c4781db90902fda88849cf4f30f82bb9 Mon Sep 17 00:00:00 2001 From: Cameron Bryers <12287346+Cambis@users.noreply.github.com> Date: Mon, 3 Aug 2026 08:53:44 +1200 Subject: [PATCH 1/2] :rotating_light: chore: address linting issue --- .changeset/silent-ghosts-raise.md | 5 +++++ ecs.php | 2 ++ .../ConfigurationResolver/Source/Extension/BarExtension.php | 2 +- .../Source/Extension/FooExtension.php | 2 +- .../Reflection/ClassReflectionExtension/Source/Model/Foo.php | 1 - .../Source/Extension/FooExtension.php | 2 +- .../Source/Extension/FooExtension.php | 2 +- 7 files changed, 11 insertions(+), 5 deletions(-) create mode 100644 .changeset/silent-ghosts-raise.md diff --git a/.changeset/silent-ghosts-raise.md b/.changeset/silent-ghosts-raise.md new file mode 100644 index 0000000..c7dee72 --- /dev/null +++ b/.changeset/silent-ghosts-raise.md @@ -0,0 +1,5 @@ +--- +"@cambis/silverstan": patch +--- + +Update coding standard diff --git a/ecs.php b/ecs.php index 126c692..d01d270 100644 --- a/ecs.php +++ b/ecs.php @@ -6,6 +6,7 @@ use PhpCsFixer\Fixer\Operator\NewWithParenthesesFixer; use PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer; use SlevomatCodingStandard\Sniffs\Namespaces\ReferenceUsedNamesOnlySniff; +use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer; use Symplify\EasyCodingStandard\Config\ECSConfig; return ECSConfig::configure() @@ -48,4 +49,5 @@ __DIR__ . '/stubs/Page.php', __DIR__ . '/stubs/PageController.php', ], + MethodChainingNewlineFixer::class, ]); diff --git a/tests/ConfigurationResolver/Source/Extension/BarExtension.php b/tests/ConfigurationResolver/Source/Extension/BarExtension.php index 6968f57..e72f17f 100644 --- a/tests/ConfigurationResolver/Source/Extension/BarExtension.php +++ b/tests/ConfigurationResolver/Source/Extension/BarExtension.php @@ -7,7 +7,7 @@ use SilverStripe\Dev\TestOnly; /** - * @extends Extension<(Bar & static)> + * @extends Extension<(Bar&static)> */ final class BarExtension extends Extension implements TestOnly { diff --git a/tests/Reflection/ClassReflectionExtension/Source/Extension/FooExtension.php b/tests/Reflection/ClassReflectionExtension/Source/Extension/FooExtension.php index c672988..1449a7c 100644 --- a/tests/Reflection/ClassReflectionExtension/Source/Extension/FooExtension.php +++ b/tests/Reflection/ClassReflectionExtension/Source/Extension/FooExtension.php @@ -7,7 +7,7 @@ use SilverStripe\Dev\TestOnly; /** - * @extends Extension<(Foo & static)> + * @extends Extension<(Foo&static)> */ final class FooExtension extends Extension implements TestOnly { diff --git a/tests/Reflection/ClassReflectionExtension/Source/Model/Foo.php b/tests/Reflection/ClassReflectionExtension/Source/Model/Foo.php index 5397f11..121b80d 100644 --- a/tests/Reflection/ClassReflectionExtension/Source/Model/Foo.php +++ b/tests/Reflection/ClassReflectionExtension/Source/Model/Foo.php @@ -13,7 +13,6 @@ * @method Foo TypehintedHasOne() * @method HasManyList TypehintedHasMany() */ - class Foo extends DataObject implements TestOnly { /** diff --git a/tests/Type/DynamicReturnTypeExtension/Source/Extension/FooExtension.php b/tests/Type/DynamicReturnTypeExtension/Source/Extension/FooExtension.php index ec07322..8eef1c8 100644 --- a/tests/Type/DynamicReturnTypeExtension/Source/Extension/FooExtension.php +++ b/tests/Type/DynamicReturnTypeExtension/Source/Extension/FooExtension.php @@ -7,7 +7,7 @@ use SilverStripe\Dev\TestOnly; /** - * @extends Extension<(Foo & static)> + * @extends Extension<(Foo&static)> */ final class FooExtension extends Extension implements TestOnly { diff --git a/tests/Type/TypeSpecifyingExtension/Source/Extension/FooExtension.php b/tests/Type/TypeSpecifyingExtension/Source/Extension/FooExtension.php index 1d86cdd..a3525f2 100644 --- a/tests/Type/TypeSpecifyingExtension/Source/Extension/FooExtension.php +++ b/tests/Type/TypeSpecifyingExtension/Source/Extension/FooExtension.php @@ -7,7 +7,7 @@ use SilverStripe\Dev\TestOnly; /** - * @extends Extension<(Foo & static)> + * @extends Extension<(Foo&static)> */ final class FooExtension extends Extension implements TestOnly { From c28e21d12991b130c03e3aa5576a197846ec4d5b Mon Sep 17 00:00:00 2001 From: Cameron Bryers <12287346+Cambis@users.noreply.github.com> Date: Mon, 3 Aug 2026 08:58:39 +1200 Subject: [PATCH 2/2] :rotating_light: chore: silence new phpstan error --- src/TypeResolver/TypeResolver.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TypeResolver/TypeResolver.php b/src/TypeResolver/TypeResolver.php index 8fa3429..84b535c 100644 --- a/src/TypeResolver/TypeResolver.php +++ b/src/TypeResolver/TypeResolver.php @@ -194,7 +194,7 @@ public function resolveDependencyFieldType(array|bool|int|string $fieldType): Ty return new StringType(); } - if ($this->reflectionProvider->hasClass($name)) { + if ($this->reflectionProvider->hasClass($name)) { // @phpstan-ignore if.alwaysTrue $name = $this->configurationResolver->resolveClassName($name); }