Repository navigation
Replies: 1 comment 1 reply
|
Thanks, this is well scoped. Two useful facts first: The open question I would like your view on is the holiday source, because it decides the shape of the whole feature. Both options you mention are outbound network calls. Calnode's rule is that a stock instance needs no external services to run, and slot generation is on the critical path for every page load, so a holiday lookup that can hang or time out means a booking calendar that can hang or time out. Someone running this air-gapped should not get a site that half works. So which do you picture:
My preference is (1) or (2), and I would want to know which before building. If it is a bundled dataset, which one, and what is its licence? Subdivision coverage matters more than it sounds: Germany needs the Länder, Spain the autonomous communities, and a country-level table will confidently mark the wrong days off. If it is fetched, which source and endpoint, and what should happen for an instance with no egress? The other bits I agree with: only holiday names are public data, and the out-of-office label should be off unless the host turns it on. Your If you end up wanting to build it rather than just test, say so and we can cut it down to a first slice. Testing on your setup is valuable either way. |
Uh oh!
There was an error while loading. Please reload this page.
Problem
day_offoverride for every public holiday, every year, by hand.Proposal
holiday_countrysetting (ISO 3166-1). Resolve the dates on the server (Nager.Date or Google's public holiday calendars), treat them as unavailable in slot generation, and let the host opt out of individual holidays. Cal.com has an equivalent per-user holiday setting.spanis one ofsingle | start | middle | end, derived from the override'sgroup_id. The booking page can then show an icon and a tooltip for a holiday, and draw an out-of-office range as one span with a start and an end marker.showNotePublicly).Current workaround
I'm doing this today with
head_htmlinjection plus a cron job that syncs holidays from Nager.Date intoavailability-overridesand generates a date → icon map. It works, but it's fragile:data-ds, so the script has to work out the date from the localized#month-label;Happy to test.
All reactions