Skip to content

Commit cbcb642

Browse files
committed
Merge branch '1109-directory'
2 parents 379b7fc + d0d0c3d commit cbcb642

2 files changed

Lines changed: 28 additions & 1 deletion

File tree

lib/server/static-server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ module.exports = function createServer (bs, scripts) {
2626
* Add directory Middleware if given in server.directory
2727
*/
2828
.update("middleware", function (mw) {
29-
if (!server.has("directory")) {
29+
if (!server.get("directory")) {
3030
return mw;
3131
}
3232

test/specs/e2e/server/e2e.server.dirs.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,30 @@ describe("E2E server test with base dir array option + directory", function () {
150150
});
151151
});
152152
});
153+
154+
describe("E2E server test with base dir array = false", function () {
155+
156+
it("should ignore the directory option if a falsey value was given", function (done) {
157+
browserSync.reset();
158+
159+
var config = {
160+
server: {
161+
baseDir: ["test", "app"],
162+
directory: false
163+
},
164+
logLevel: "silent",
165+
open: false
166+
};
167+
168+
browserSync.init(config, function (err, bs) {
169+
request(bs.server)
170+
.get("/")
171+
.set("accept", "text/html")
172+
.expect(200)
173+
.end(function (err, res) {
174+
assert.notInclude(res.text, "listing directory /");
175+
done();
176+
});
177+
});
178+
});
179+
});

0 commit comments

Comments
 (0)