fix(socket-clients): limit reconnection attempts

Add `socketIoClientConfig` to socket option with `reconnectionAttempts: 50` as the default
closes #835

Author: shakyShane

lib/connect-utils.js

@@ -53,8 +53,19 @@ var connectUtils = {
         var template      = fs.readFileSync(config.templates.connector, "utf-8");
         var url           = connectUtils.getConnectionUrl(options);
 
+        /**
+         * ***Backwards compatibility***. While `socket.path` is technically a
+         * socketIoClientConfig property, it's been documented previously
+         * as a top-level option, so must stay.
+         */
+        var clientConfig  = socket
+            .get("socketIoClientConfig")
+            .merge({
+                path: socket.get("path")
+            });
+
         template = template
-            .replace("%path%", socket.get("path"))
+            .replace("%config%", JSON.stringify(clientConfig.toJS()))
             .replace("%url%",  url);
 
         return template;

lib/default-config.js

@@ -415,9 +415,12 @@ module.exports = {
      */
     socket: {
         socketIoOptions: {
-            log: false,
+            log: false
         },
-        path: "/browser-sync/socket.io",
+        socketIoClientConfig: {
+            reconnectionAttempts: 50
+        },
+        path: "/browser-sync/shane",
         clientPath: "/browser-sync",
         namespace: "/browser-sync",
         clients: {

lib/templates/connector.tmpl

@@ -2,5 +2,5 @@ window.___browserSync___ = {};
 ___browserSync___.io = window.io;
 window.io = window.___browserSync___oldSocketIo;
 window.___browserSync___oldSocketIo=undefined;
-___browserSync___.socketConfig = {}; ___browserSync___.socketConfig.path = '%path%';
-___browserSync___.socket = ___browserSync___.io(%url%, ___browserSync___.socketConfig);
+___browserSync___.socketConfig = %config%;
+___browserSync___.socket = ___browserSync___.io(%url%, ___browserSync___.socketConfig);