Skip to content

Commit 728c777

Browse files
committed
use base app for snippet only use-case
1 parent cfa07d8 commit 728c777

5 files changed

Lines changed: 9 additions & 14 deletions

File tree

lib/hooks.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = {
1616
var js = snippetUtils.getClientJs(data.port, data.options);
1717

1818
return hooks.reduce(function (joined, hook) {
19-
return joined += hook;
19+
return joined + hook;
2020
}, js);
2121
},
2222
/**

lib/logger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ module.exports.callbacks = {
157157
logger.unprefixed("info",
158158
messages.scriptTags(bs.options)
159159
);
160-
160+
161161
logUrls(bs.options.get("urls").filter(function (value, key) {
162162
return key.slice(0, 2) === "ui";
163163
}).toJS());

lib/server/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ module.exports.plugin = function (bs, scripts) {
1010
var proxy = bs.options.get("proxy");
1111
var type = bs.options.get("mode");
1212

13-
var bsServer = createServer(bs, scripts);
13+
var bsServer = createServer(bs, scripts);
1414

1515
if (type === "server" || type === "snippet") {
1616
debug("Static Server running ({magenta:%s}) ...", bs.options.get("scheme"));
@@ -43,9 +43,9 @@ module.exports.plugin = function (bs, scripts) {
4343
*/
4444
function createServer (bs, clientScripts) {
4545

46-
var proxy = bs.options.get("proxy");
47-
var server = bs.options.get("server");
48-
46+
var proxy = bs.options.get("proxy");
47+
var server = bs.options.get("server");
48+
4949
if (!proxy && !server) {
5050
return require("./snippet-server")(bs, clientScripts);
5151
}

lib/server/snippet-server.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"use strict";
22

33
var connect = require("connect");
4-
var utils = require("./utils");
4+
var serverUtils = require("./utils.js");
55

66
/**
77
* Create a server for the snippet
@@ -11,10 +11,6 @@ var utils = require("./utils");
1111
*/
1212
module.exports = function createSnippetServer (bs, scripts) {
1313

14-
var app = connect();
15-
16-
app.use(bs.options.getIn(["scriptPaths", "versioned"]), scripts)
17-
.use(bs.options.getIn(["scriptPaths", "path"]), scripts);
18-
19-
return utils.getServer(app, bs.options);
14+
var app = serverUtils.getBaseApp(bs, bs.options, scripts);
15+
return serverUtils.getServer(app, bs.options);
2016
};

lib/server/static-server.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ module.exports = function createServer (bs, scripts) {
1616

1717
var options = bs.options;
1818
var server = options.get("server");
19-
var middleware = options.get("middleware");
2019
var basedirs = utils.arrayify(server.get("baseDir"));
2120
var serveStaticOptions = server.get("serveStaticOptions").toJS(); // passed to 3rd party
2221

0 commit comments

Comments
 (0)