Skip to content

Commit 66dd19c

Browse files
committed
fix(client): CSS injection broken in older browsers due to use of Array.from - fixes #1539
1 parent 61faee1 commit 66dd19c

4 files changed

Lines changed: 18 additions & 14 deletions

File tree

client/dist/index.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8373,16 +8373,14 @@ var Reloader = /** @class */ (function () {
83738373
})());
83748374
// find all imported stylesheets
83758375
var imported = [];
8376-
for (var _i = 0, _a = Array.from(this.document.getElementsByTagName('style')); _i < _a.length; _i++) {
8377-
var style = _a[_i];
8376+
[].slice.call(this.document.getElementsByTagName('style')).forEach(function (style) {
83788377
if (style.sheet) {
8379-
this.collectImportedStylesheets(style, style.sheet, imported);
8378+
_this.collectImportedStylesheets(style, style.sheet, imported);
83808379
}
8381-
}
8382-
for (var _b = 0, _c = Array.from(links); _b < _c.length; _b++) {
8383-
link = _c[_b];
8384-
this.collectImportedStylesheets(link, link.sheet, imported);
8385-
}
8380+
});
8381+
links.forEach(function (link) {
8382+
_this.collectImportedStylesheets(link, link.sheet, imported);
8383+
});
83868384
// handle prefixfree
83878385
if (this.window.StyleFix && this.document.querySelectorAll) {
83888386
[].slice.call(this.document.querySelectorAll('style[data-href]')).forEach(function (style) {

client/dist/index.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/vendor/Reloader.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,14 +265,16 @@ export class Reloader {
265265

266266
// find all imported stylesheets
267267
const imported = [];
268-
for (var style of Array.from(this.document.getElementsByTagName('style'))) {
268+
269+
[].slice.call(this.document.getElementsByTagName('style')).forEach((style) => {
269270
if (style.sheet) {
270271
this.collectImportedStylesheets(style, style.sheet, imported);
271272
}
272-
}
273-
for (link of Array.from(links)) {
273+
});
274+
275+
links.forEach(link => {
274276
this.collectImportedStylesheets(link, link.sheet, imported);
275-
}
277+
});
276278

277279
// handle prefixfree
278280
if (this.window.StyleFix && this.document.querySelectorAll) {

yarn.lock

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1926,7 +1926,11 @@ immutable@3.8.0:
19261926
version "3.8.0"
19271927
resolved "https://registry.yarnpkg.com/immutable/-/immutable-3.8.0.tgz#5175514f70cb2a8218b58183d33747134a81c697"
19281928

1929-
immutable@3.8.1, immutable@^3.7.4, immutable@^3.7.6:
1929+
immutable@3.8.2:
1930+
version "3.8.2"
1931+
resolved "https://registry.yarnpkg.com/immutable/-/immutable-3.8.2.tgz#c2439951455bb39913daf281376f1530e104adf3"
1932+
1933+
immutable@^3.7.4, immutable@^3.7.6:
19301934
version "3.8.1"
19311935
resolved "https://registry.yarnpkg.com/immutable/-/immutable-3.8.1.tgz#200807f11ab0f72710ea485542de088075f68cd2"
19321936

0 commit comments

Comments
 (0)