fix(rewrites): also rewrite protocol-relative URLs - fixes #991

Author: shakyShane

lib/server/proxy-utils.js

@@ -13,7 +13,8 @@ module.exports.rewriteLinks = function (userServer) {
     }
 
     return {
-        match: new RegExp("https?:\\\\/\\\\/" + string + "|https?://" + string + "(\/)?|('|\")(https?://|/|\\.)?" + string + "(\/)?(.*?)(?=[ ,'\"\\s])", "g"),
+        match: new RegExp("https?:\\\\/\\\\/" + string + "|('|\")\\\/\\\/" + string + "|https?://" + string + "(\/)?|('|\")(https?://|/|\\.)?" + string + "(\/)?(.*?)(?=[ ,'\"\\s])", "g"),
+        //match: new RegExp("https?:\\\\/\\\\/" + string + "|https?://" + string + "(\/)?|('|\")(https?://|/|\\.)?" + string + "(\/)?(.*?)(?=[ ,'\"\\s])", "g"),
         //match: new RegExp("https?:\\\\?/\\\\?/" + string + "(\/)?|('|\")(https?://|\\\\?/|\\.)?" + string + "(\/)?(.*?)(?=[ ,'\"\\s])", "g"),
         //match: new RegExp('https?://' + string + '(\/)?|(\'|")(https?://|/|\\.)?' + string + '(\/)?(.*?)(?=[ ,\'"\\s])', 'g'),
         //match: new RegExp("https?:\\\\/\\\\/" + string, "g"),

test/specs/resp-mod/rewrite-links.js

@@ -167,6 +167,14 @@ describe("Rewriting Domains", function() {
             var actual   = input.replace(rewrite.match, bound);
             assert.equal(actual, input);
         });
+        it("should use the regex to replace links that have protocol relative URLS", function() {
+            var input = '<script type="text/javascript" src="//test.dev/file.js">';
+            var expected = '<script type="text/javascript" src="//' + proxyUrl + '/file.js">';
+            var rewrite  = utils.rewriteLinks({hostname: "test.dev"}, proxyUrl);
+            var bound    = rewrite.fn.bind(null, {headers: {host: proxyUrl}}, {});
+            var actual   = input.replace(rewrite.match, bound);
+            assert.equal(actual, expected);
+        });
         it("should not replace when host + subdomain ", function() {
             var input = '<a href="http://assets.cdn.example.com:1234/foo">Link 1</a>';
             var rewrite  = utils.rewriteLinks({hostname: "example.com", port: 1234}, proxyUrl);