Commit c57bb85
committed
fix(report): stop declaring screens seven tests cannot draw
The report's own gate was failing:
screenshot audit FAILED -- declared screens with no capture:
test_msg_ethereum_getaddress::test_ethereum_getaddress
test_msg_ripple_get_address::test_ripple_get_address
test_msg_ethereum_clear_signing::test_valid_metadata_returns_verified
test_msg_solana_getaddress::test_solana_get_address
test_msg_tron_getaddress::test_tron_get_address
test_msg_ton_getaddress::test_ton_get_address
test_msg_zcash_orchard::test_fvk_reference_vectors
None of them is a missing capture. Each entry declared a screen the test can
never produce:
- the five *getaddress* tests return the address ON THE WIRE. The drawn
address is the *show_address* sibling, which is separately catalogued and
does capture it (S3b, T3b, N2b, B4).
- test_valid_metadata_returns_verified asserts the VERIFIED classification
before anything is rendered.
- test_fvk_reference_vectors is reference-vector arithmetic compared in
memory.
So the declarations were wrong, not the runs. Emptied, and each carries a line
saying why it is empty and where the screen actually lives -- an empty list is
already meaningful in this catalog ("refusal paths draw nothing, and their
evidence is the Failure on the wire plus the ABSENCE of a ButtonRequest"), so
it must read as intent rather than omission.
This matters beyond tidiness. The audit is a release gate, and a gate that
fails for a reason nobody can fix gets ignored -- and an ignored gate is the
one that misses the real defect later. It now passes:
screenshot audit: every declared screen was captured1 parent ef34f35 commit c57bb85
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1057 | 1057 | | |
1058 | 1058 | | |
1059 | 1059 | | |
1060 | | - | |
| 1060 | + | |
1061 | 1061 | | |
1062 | 1062 | | |
1063 | 1063 | | |
| |||
1193 | 1193 | | |
1194 | 1194 | | |
1195 | 1195 | | |
1196 | | - | |
| 1196 | + | |
1197 | 1197 | | |
1198 | 1198 | | |
1199 | 1199 | | |
| |||
1421 | 1421 | | |
1422 | 1422 | | |
1423 | 1423 | | |
1424 | | - | |
1425 | | - | |
| 1424 | + | |
| 1425 | + | |
1426 | 1426 | | |
1427 | 1427 | | |
1428 | 1428 | | |
| |||
1864 | 1864 | | |
1865 | 1865 | | |
1866 | 1866 | | |
1867 | | - | |
| 1867 | + | |
1868 | 1868 | | |
1869 | 1869 | | |
1870 | 1870 | | |
| |||
1992 | 1992 | | |
1993 | 1993 | | |
1994 | 1994 | | |
1995 | | - | |
| 1995 | + | |
1996 | 1996 | | |
1997 | 1997 | | |
1998 | 1998 | | |
| |||
2016 | 2016 | | |
2017 | 2017 | | |
2018 | 2018 | | |
2019 | | - | |
| 2019 | + | |
2020 | 2020 | | |
2021 | 2021 | | |
2022 | 2022 | | |
| |||
2081 | 2081 | | |
2082 | 2082 | | |
2083 | 2083 | | |
2084 | | - | |
| 2084 | + | |
2085 | 2085 | | |
2086 | 2086 | | |
2087 | 2087 | | |
| |||
0 commit comments