Skip to content

Commit a388dde

Browse files
committed
test(ci): gate post-RC18 signing hardening accurately
1 parent d404ea9 commit a388dde

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

tests/test_msg_mayachain_signtx.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ class TestMsgMayaChainSignTx(common.KeepKeyTest):
5858

5959
def test_ack_rejects_send_and_deposit_together(self):
6060
"""An unused deposit submessage must not suppress the signed tx memo."""
61-
self.requires_firmware("7.15.0")
61+
# The exactly-one-message check was added after RC18 as part of the
62+
# 7.16 alpha security backport (firmware 71e6c1d942).
63+
self.requires_firmware("7.16.0")
6264
self.requires_fullFeature()
6365
self.setup_mnemonic_nopin_nopassphrase()
6466

tests/test_msg_zcash_sign_pczt_device.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ def test_ironwood_rejects_a_non_empty_orchard_bundle(self):
337337
verification is [s]G = R + [H(R||rk||M)]rk and rk and M are shared. The
338338
Orchard bundle's valueBalance never enters the device's fee check.
339339
"""
340+
self.requires_firmware(self.IRONWOOD_FIRMWARE)
340341
actions = [note_action(CMX_IRONWOOD)]
341342
kwargs = sign_kwargs(actions, ironwood=True)
342343
# Anything but the ZIP-229 v6 empty-bundle digest must be refused.

tests/test_multisig.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,9 @@ def test_oversized_signature_is_rejected(self):
255255
The declared max_size is a decoder bound, never a runtime one. This
256256
asserts the device applies the real one.
257257
"""
258+
# The 72-byte runtime bound was backported after RC18 in the 7.16
259+
# alpha security line (firmware 40da090620).
260+
self.requires_firmware("7.16.0")
258261
self.setup_mnemonic_nopin_nopassphrase()
259262

260263
node = ckd_public.deserialize('xpub661MyMwAqRbcF1zGijBb2K6x9YiJPh58xpcCeLvTxMX6spkY3PcpJ4ABcCyWfskq5DDxM3e6Ez5ePCqG5bnPUXR4wL8TZWyoDaUdiWW7bKy')

0 commit comments

Comments
 (0)