Commit 178fefd
committed
fix(report): the console summary counted the wrong skips
render() computes the catalog's own skip count, then the scope paragraph
rebound the same name to the run-wide census:
skipped = sum(... for t in s[5] if _lookup(...) == 'skip') # catalog
...
skipped = JUNIT_CENSUS['skipped'] # whole run
so the line CI operators actually read --
N sections, 374 tests (323 passed, 0 failed, 3 skipped, 48 pending)
printed the whole run's skips inside a breakdown of the catalog. The four
numbers did not add up to the total, and the error ran in the alarming
direction: it inflates skips, which reads as "lots of this was not exercised"
against a catalog where only three entries were actually gated.
Use the census value inline where the paragraph needs it and leave `skipped`
meaning one thing.
Added the assertion that would have caught it, since the breakdown is only
ever right when it reconciles:
assert passed + failed + skipped + missing == total
Now: 374 tests (323 passed, 0 failed, 3 skipped, 48 pending) -> 374.1 parent 1dacea4 commit 178fefd
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2845 | 2845 | | |
2846 | 2846 | | |
2847 | 2847 | | |
2848 | | - | |
2849 | 2848 | | |
2850 | 2849 | | |
2851 | 2850 | | |
2852 | 2851 | | |
2853 | 2852 | | |
2854 | | - | |
| 2853 | + | |
2855 | 2854 | | |
2856 | 2855 | | |
2857 | 2856 | | |
| |||
2994 | 2993 | | |
2995 | 2994 | | |
2996 | 2995 | | |
| 2996 | + | |
| 2997 | + | |
| 2998 | + | |
2997 | 2999 | | |
2998 | 3000 | | |
2999 | 3001 | | |
| |||
0 commit comments