Skip to content

consolidated Python harness reintroduces mandatory Uniswap skips #606

Description

@BitHighlander

Summary

The consolidated Python harness reintroduced an emulator-wide setUp() skip for all three Uniswap V2 liquidity signing vectors. This regresses the prior explicit fix in BitHighlander/python-keepkey#32 (811520e8 / merge 9f3b1767) that removed those skips after they exposed and verified a real firmware recipient-confirmation defect.

At the same time, the 7.16 report catalog:

A clean 7.16 Docker run therefore reports all three as skipped-but-required after 675 other tests pass.

Impact

Required remediation

  • Remove the emulator-wide skip again.
  • Run all three vectors against the exact companion firmware and verify their fixed signatures.
  • Replace the pending catalog text with the actual verified behavior and retain their confirmation frames.
  • Keep the module mandatory for full 7.16 builds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions