Subdirectories not deleted during `sync-glob --watch` on Windows 10 / Linux

[KeithGillette]

When running:

sync-glob --watch 'source/*' destination
or:
sync-glob --watch 'source/**/*' destination

directories and files are copied and updated (recursively) from source to destination, but the watch does not delete subdirectories deleted in source during the watch.

With:

• sync-glob 1.3.6
• npm 3.10.10
• Node 6.9.5
• Windows_NT 10.0.14393

[KeithGillette]

Thanks for the fast patching, @AndyOGo! Your release 1.3.7 did fix issue #41, so files are now correctly deleted, but in my test it still does not detect (empty) subdirectory deletion on Windows 10.

[AndyOGo]

@KeithGillette
Thanks for your quick feedback.
I will investigate this issue. From your data it seems have a missing test case too.

[AndyOGo]

I just run the following test on my Mac
Note: all sub directories here are not empty.

node bin/sync-glob.js --watch 'test/**/*' tmp/

Initial Copy

DELETE tmp
COPY test/mock/bar to tmp/bar
COPY test/mock/foo to tmp/foo
COPY test/mock/@org to tmp/@org
COPY test/mock/a.txt to tmp/a.txt
COPY test/mock/b.txt to tmp/b.txt
COPY test/mock/transform.js to tmp/transform.js
COPY test/mock/bar/c.txt to tmp/bar/c.txt
COPY test/mock/foo/b.txt to tmp/foo/b.txt
COPY test/mock/foo/d.txt to tmp/foo/d.txt
COPY test/mock/@org/d.txt to tmp/@org/d.txt
COPY test/mock/@org/b.txt to tmp/@org/b.txt
COPY test/mock/@org/a.txt to tmp/@org/a.txt
WATCHING test/mock/**/*

Deleting test/mock/ sub directory

DELETE tmp/mock/@org/a.txt
DELETE tmp/mock/@org/b.txt
DELETE tmp/mock/@org/d.txt
DELETE tmp/mock/@org
DELETE tmp/mock/bar/c.txt
DELETE tmp/mock/bar
DELETE tmp/mock/foo/b.txt
DELETE tmp/mock/foo/d.txt
DELETE tmp/mock/foo
DELETE tmp/mock/b.txt
DELETE tmp/mock/a.txt
DELETE tmp/mock/transform.js
DELETE tmp/mock

Deleting test/mock/@org/ sub sub directory

DELETE tmp/mock/@org/b.txt
DELETE tmp/mock/@org/a.txt
DELETE tmp/mock/@org/d.txt
DELETE tmp/mock/@org

[AndyOGo]

So double I just created an empty sub directory and run following test:

node bin/sync-glob.js --watch 'test/**/*' tmp/

DELETE tmp
COPY test/lib to tmp/lib
COPY test/mock to tmp/mock
COPY test/mock/@org to tmp/mock/@org
COPY test/mock/bar to tmp/mock/bar
COPY test/mock/empty to tmp/mock/empty
COPY test/mock/foo to tmp/mock/foo
COPY test/copy.spec.js to tmp/copy.spec.js
COPY test/helpers.js to tmp/helpers.js
COPY test/lib/is-glob.spec.js to tmp/lib/is-glob.spec.js
COPY test/lib/resolve-target.spec.js to tmp/lib/resolve-target.spec.js
COPY test/lib/sources-bases.spec.js to tmp/lib/sources-bases.spec.js
COPY test/lib/trim-quotes.spec.js to tmp/lib/trim-quotes.spec.js
COPY test/mock/@org/a.txt to tmp/mock/@org/a.txt
COPY test/mock/@org/b.txt to tmp/mock/@org/b.txt
COPY test/mock/@org/d.txt to tmp/mock/@org/d.txt
COPY test/mock/a.txt to tmp/mock/a.txt
COPY test/mock/b.txt to tmp/mock/b.txt
COPY test/mock/bar/c.txt to tmp/mock/bar/c.txt
COPY test/mock/foo/b.txt to tmp/mock/foo/b.txt
COPY test/mock/foo/d.txt to tmp/mock/foo/d.txt
COPY test/mock/transform.js to tmp/mock/transform.js
COPY test/sync.spec.js to tmp/sync.spec.js
COPY test/transform.spec.js to tmp/transform.spec.js
WATCHING test/**/*

Delete test/mock/empty by running rmdir test/mock/empty

DELETE tmp/mock/empty

@KeithGillette
Seems all okay on OSX.
May I asked you if you get any errors? Or could you post your logs please?
Unfortunately I don't have a Windows 10 machine available 😞
And please use the --verbose option.

[AndyOGo]

@KeithGillette
I quickly googled if chokidar has a deletion issue.
And indeed it describes exactly your problem with following error:

Error: watch null EPERM

• Still open: Deleting an empty directory triggers error instead of unlinkDir paulmillr/chokidar#566
• Already closed, but related:
  Windows: Cannot delete watched folder with not-empty subfolder paulmillr/chokidar#422
  Windows 7, Chokidar exits with error when remove a directory paulmillr/chokidar#88

[AndyOGo]

@KeithGillette
Can you confirm that you have an permission error?

[KeithGillette]

Hi @AndyOGo. I get absolutely no errors in the console even with the --verbose flag. The deleted empty directories are simply ignored by node-glob-sync altogether: no console output appears at the time of deletion. The only time a directory is deleted is when it contains a file.

[AndyOGo]

@KeithGillette Okay, what a bummer. Thank you for instant feedback.
The point is, I do use chokidar for file watching and paulmillr/chokidar#566 describes exactly your bug with deletion of empty directories.
Unfortunately I can't reproduce this as long as I don't have a Windows 10 machine available.

[KeithGillette]

Bummer, indeed. My current needs don't actually require globbing functionality, so I have fallen back to node-sync-files which does not suffer from this issue. However, that leads me to believe that the problem may not be related to the open chokidar issue, as node-sync-files also has that as a dependency.

[AndyOGo]

Sure, use the tool which satisfies your needs best.

Hmh, interesting. But I don't think so because node-sync-files is using an outdated chokidar version ^1.0.0-rc3 and node-sync-glob is using a more up-to-date version ^1.6.1 of chokidar.

I will keep an eye on this and try to get access to a windows 10 box, so that I can prove what is going on exactly.

[KeithGillette]

Thanks again, @AndyOGo. While we can get by with a straight directory sync now, I foresee use cases for globbing in my project in the future, so I hope you are able to resolve the issue. If it would be helpful in testing, I can get you access to a virtualized Windows 10 environment on Azure.