Initialize and call service in page_controller

Create a @service variable that is containing the initialized services. After that the service will be called. The service can fire an Alchemy::PageNotFound error that is interesting the current user is not allowed to see the page. The service also gets the parameters that maybe contain also wildcard_url parameter.

Author: kulturbande

app/controllers/alchemy/pages_controller.rb

@@ -130,6 +130,16 @@ def load_page
         urlname: params[:urlname],
         language_code: params[:locale] || Current.language.code
       )
+
+      if @page&.has_service?
+        begin
+          @service = @page.definition.service.new(@page, params: params)
+          @service.call
+        rescue Alchemy::PageNotFound
+          page_not_found!
+        end
+      end
+
       Current.page = @page
     end
 

lib/alchemy/errors.rb

@@ -85,4 +85,7 @@ def message
       "Unknown Version! Please use one of #{Alchemy::EagerLoading::PAGE_VERSIONS.join(", ")}"
     end
   end
+
+  # Raised by page definition services to trigger a 404 response.
+  class PageNotFound < StandardError; end
 end

spec/controllers/alchemy/pages_controller_spec.rb

@@ -257,5 +257,30 @@ module Alchemy
         end
       end
     end
+
+    describe "Page definition service" do
+      let(:page_with_service) { create(:alchemy_page, :public, page_layout: :with_service) }
+
+      context "when the page definition has a service" do
+        it "calls the service" do
+          expect_any_instance_of(DummyPageService).to receive(:call)
+          get :show, params: {urlname: page_with_service.urlname}
+        end
+
+        it "assigns the service instance to @service" do
+          get :show, params: {urlname: page_with_service.urlname}
+          expect(assigns(:service)).to be_a(DummyPageService)
+        end
+      end
+
+      context "when the service raises Alchemy::PageNotFound" do
+        it "renders a 404" do
+          expect_any_instance_of(DummyPageService).to receive(:call).and_raise(Alchemy::PageNotFound)
+          expect {
+            get :show, params: {urlname: page_with_service.urlname}
+          }.to raise_error(ActionController::RoutingError)
+        end
+      end
+    end
   end
 end