Repository navigation
Commit ae17bb7
committed
Commit the chunker positive-control diagnostic (CodeRabbit review, PR #1144)
CodeRabbit correctly flagged: the mechanism-null conclusion for
semantic_chunker relied on a diagnostic that was run once as a throwaway
script and deleted, never entering git — a later reader could reproduce
the KILL but not the evidence for calling it a mechanism null rather than
a harness bug.
Fixed by adding the control as a 4th, committed arm in
chunker_falsifier.rs itself: the module's own adversarial synthetic-
corners shape (centroids 0-4 vs 250-254) against the same real table,
reported at every threshold. Re-ran after landing — reproduces the same
zero. Updated the plan (§4c), EPIPHANIES, and STATUS_BOARD to point at
the committed control instead of the deleted one.
The ratio-ambiguity and public-signature findings from the same review
were already addressed on the current head (the earlier ratio-fix commit
already states both directions; from_engine_state has zero in-tree
callers, verified by repo-wide grep, and the crate is workspace-excluded
so no external consumer exists to break) — replied on those threads
rather than re-editing settled text.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PFnYKqw6d7TTiB9cT8eFdK1 parent 4e19d1d commit ae17bb7
4 files changed
Lines changed: 55 additions & 9 deletions
File tree
- .claude
- board
- plans
- crates/thinking-engine/examples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
297 | 301 | | |
298 | 302 | | |
299 | 303 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
31 | 45 | | |
32 | 46 | | |
33 | 47 | | |
| |||
244 | 258 | | |
245 | 259 | | |
246 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
247 | 289 | | |
0 commit comments