Skip to content

Commit 44292cb

Browse files
committed
CI: add --features cycle-driver to the supervisor step (30 unrun falsifiers)
`cycle-driver` is a SEPARATE feature that `supervisor` does not imply, so the supervisor step -- despite being this crate's own step -- never compiled `cycle_driver`, the three `probe_ignition*` / `d_ign_b_lenses` test binaries, or any of #879's loop-closure contract. Measured on this tree, not inferred: --features supervisor 13 tests --features supervisor,cycle-driver 43 tests, 0 failed The 30 in the gap include `probe_ignition_64k_start_at_full_population` -- the 65,536-owner / 17-sealed headline canonized as E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. It runs in 13.75 s and passes; it had simply never run anywhere but a developer machine. #891 recorded this gap and deliberately did not touch the workflow. #898 closed the identical shape for callcenter (`--features query`) but not this one -- same arc, same defect class, one closed and one left open. One added feature closes it, and the new invocation is a strict superset of the old, so it cannot lose coverage.
1 parent 912a41f commit 44292cb

1 file changed

Lines changed: 17 additions & 2 deletions

File tree

‎.github/workflows/rust-test.yml‎

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,23 @@ jobs:
139139
# membrane failure (E-SEMANTIC-OS-CONVERGENCE-1). Flagged by
140140
# coderabbit on #634. Cheap: contract + ractor + the shader-driver
141141
# dev-dep, no lance/datafusion.
142-
- name: Run supervisor tests (W2b real-owner probes)
143-
run: cargo test --manifest-path crates/lance-graph-supervisor/Cargo.toml --features supervisor
142+
#
143+
# `cycle-driver` ADDED 2026-08-05. It is a SEPARATE feature that
144+
# `supervisor` does not imply, so the step above — despite being the
145+
# crate's own step — never compiled `cycle_driver`, the three
146+
# `probe_ignition*` / `d_ign_b_lenses` test binaries, or any of the #879
147+
# loop-closure contract. Measured: `--features supervisor` runs 13 tests;
148+
# `--features supervisor,cycle-driver` runs 43. The 30 in the gap include
149+
# `probe_ignition_64k_start_at_full_population` — the 64k-owner /
150+
# 17-sealed headline canonized as
151+
# E-64K-1TO1-OWNERS-IS-THE-MAIN-MODEL-1. #891 recorded this gap and
152+
# deliberately did not touch the workflow; #898 closed the same shape for
153+
# callcenter but not this one. One added feature closes it.
154+
#
155+
# Verified locally before landing: 43 passed, 0 failed. Strict superset of
156+
# what this step ran before, so it cannot lose coverage.
157+
- name: Run supervisor tests (W2b real-owner probes + #879 cycle driver)
158+
run: cargo test --manifest-path crates/lance-graph-supervisor/Cargo.toml --features supervisor,cycle-driver
144159
# bgz-tensor: workspace-EXCLUDED metric-algebraic codec crate (deps the
145160
# ndarray sibling checked out above + in-repo holograph). None of the
146161
# steps above reach it, so its 207 lib tests — including the V3

0 commit comments

Comments
 (0)