rust-toolchain.toml

[toolchain]
channel = "1.99.0"
# The pinned version is the `channel` line ABOVE — deliberately not restated
# in this comment. Restating it is what made this comment wrong twice: it said
# "1.94.1" until `10f87fb6` corrected it, then said "1.95.0" after the bump to
# 1.97.1, because a bump edits `channel` and leaves the prose behind. Keep the
# rationale here and the version there; append to the log, never re-narrate.
#
# Bump log (append one line per bump):
#   1.94.0 → 1.94.1   matches sibling repos                        (f638fa27)
#   1.94.1 → 1.95.0   bevy edition-2024 MSRV + ndarray in parallel (PR #367,
#                     2026-05-13); #367 + #368 closed the lints 1.95 added
#                     (`manual_checked_ops`, `unnecessary_sort_by`, `len_zero`)
#   1.95.0 → 1.97.1   lance 9 / lancedb 0.33 / DataFusion 54 sweep (b2b08b07,
#                     2026-08-05); toolchain leg measured ALONE on the old pins
#                     first, so a toolchain failure could not be mistaken for a
#                     dependency failure —
#                     `.claude/plans/lance9-datafusion54-upgrade-probe-v1.md`
#   1.97.1 → 1.98.1   current stable (1.98.0 2026-08-20, 1.98.1 2026-09-01).
#                     Same method as the line above: the toolchain leg was
#                     measured ALONE first, on the FIXED lance-11 deps that had
#                     just gone green on 1.97.1 — so this leg's contribution is
#                     known exactly. It is ONE lint:
#                     `clippy::chunks_exact_to_as_chunks`, new in 1.98 and in
#                     the default-on STYLE group, at ten sites across four
#                     crates. Those ten landed SEPARATELY in #1194 before this
#                     bump, verified clean on BOTH 1.97.1 and 1.98.1, which is
#                     what makes this commit a one-line channel edit with
#                     nothing bundled into it.
#                     Nothing from rustc bit: measured 0 manual `impl Ord` (so
#                     the derive(PartialOrd) fast path cannot apply), 1 c_void
#                     return, 7 transmutes, 34 repr(transparent).
#   1.98.1 → 1.99.0   current stable (2026-10-01; LLVM 23). Same method:
#                     toolchain leg measured ALONE on the unchanged lance-12
#                     pins, as an error-SET diff of `clippy --workspace
#                     --all-targets --keep-going -D warnings` on 1.98.1 vs
#                     1.99.0. Exactly ONE new error: `approx_constant` now
#                     covers GOLDEN_RATIO (one site, phasor_trig_probe; the
#                     const is bit-identical and stable on both). Every other
#                     error in that run is pre-existing on 1.98.1 (main is not
#                     clippy-clean under --all-targets), so it is not this
#                     bump's. ndarray codegen witness (avx512 + avx2) and
#                     simd-masking-parity both pass under LLVM 23.
#
# Never auto-track `stable` — bump explicitly when a future version is
# reviewed and workspace clippy passes clean.
#
# rustfmt + clippy are mandatory CI components and must be present
# whenever the pinned channel is installed. Without this, `cargo fmt`
# under `actions-rust-lang/setup-rust-toolchain@v1` resolves to the
# pinned channel but rustfmt is only installed for `stable`
# (the action's default), producing:
#   error: 'cargo-fmt' is not installed for the toolchain '<pinned>-...'
# Declaring components here makes rustup install them as part of the
# toolchain itself, which is also developer-friendly: a fresh
# `rustup show` in this workspace materializes a complete CI-equivalent
# toolchain in one step.
components = ["rustfmt", "clippy"]