Add ragged all-to-all pipeline correctness coverage#4104
Draft
huytransformer wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3f6a2e5 to
c6b7a08
Compare
c6b7a08 to
03f5576
Compare
03f5576 to
e22397a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds pipeline-parallel correctness coverage for DeepSeek dropless expert parallelism, which exercises the
ragged_all_to_allpath.This also fixes the pipeline test helper so
single_pipeline_stage_classis preserved. Previously the helper constructed the requested stage class, then unconditionally replaced it withSimpleDecoderLayerToLinen, so custom layer tests did not actually run the requested layer.FIXES: b/430135480
Tests
python3 -m py_compile tests/integration/pipeline_parallelism_test.pygit diff --checkChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.