fix: Change packaging details for Sdk and Tool (#214)

* fix: Correct build/ content packing in Tool

* fix: Ignore NU5128 in Metapackage.Sdk

remove Placeholder (_._ file) logic
in favor of nuspec management and ignoring NU5128

Author: amis92

src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.targets

@@ -46,6 +46,11 @@
                 group.Add(dep);
             }
         }
+        // if not present, add empty <files/> node to prevent packing .nuspec's directory
+        if (document.Root.Element(ns + "files") == null)
+        {
+            document.Root.Add(new XElement(ns + "files"));
+        }
         document.Save(PatchedNuspecFilePath);
         ]]>
       </Code>
@@ -58,8 +63,11 @@
     <PackDependsOn>$(PackDependsOn);PackMetapackage;</PackDependsOn>
     <!-- Workaround the hardcoded ContinuePackingAfterGeneratingNuspec -->
     <GenerateNuspecDependsOn>SetContinuePackingAfterNuspecToFalse;$(GenerateNuspecDependsOn)</GenerateNuspecDependsOn>
-    <!-- Put _._ placeholder files in lib/TFM package folders -->
-    <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);PackTfmPlaceholder;</TargetsForTfmSpecificContentInPackage>
+    <!--
+      Ignore NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location.
+      Reason: It's exactly what we want (no content at all).
+    -->
+    <NoWarn>$(NoWarn);NU5128</NoWarn>
   </PropertyGroup>
 
   <!-- 
@@ -106,21 +114,6 @@
         Text="$(_CheckCgrToolReferenceExistsWarning.Trim())" />
   </Target>
 
-  <!--
-    Puts _._ placeholder file in lib/TFM package folder, per TFM.
-
-    Disable by setting SkipPackTfmPlaceholder=true
-  -->
-  <Target
-      Name="PackTfmPlaceholder"
-      Condition="'$(SkipPackTfmPlaceholder)' != 'true'">
-    <ItemGroup>
-      <TfmSpecificPackageFile
-          Include="$(MSBuildThisFileDirectory)/_._"
-          PackagePath="lib/$(TargetFramework)/" />
-    </ItemGroup>
-  </Target>
-
   <!-- Build paths used in PatchNuspecFile target -->
   <Target
       Name="PreparePathsForPatchNuspecFile"

src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/_._

@@ -9,11 +9,6 @@
     <RollForward>Major</RollForward>
     <!-- Ignore 'Missing XML comments', it's a tool. -->
     <NoWarn>$(NoWarn);CS1591</NoWarn>
-    <!--
-      NU5129 false positive - similar to https://github.com/NuGet/Home/issues/8627
-      Possible cause: generating the .props file dynamically during build.
-    -->
-    <NoWarn>$(NoWarn);NU5129</NoWarn>
     <!-- Packing -->
     <DevelopmentDependency>true</DevelopmentDependency>
     <!--
@@ -33,11 +28,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <None Include="build/**">
-      <Pack>true</Pack>
-      <PackagePath>build/</PackagePath>
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
+    <None Include="build/**" Pack="true" PackagePath="build" />
     <Compile Update="CommandLine\Strings.Designer.cs">
       <DesignTime>True</DesignTime>
       <AutoGen>True</AutoGen>