Incorporate CR feedback

Author: manne

src/.editorconfig

@@ -35,7 +35,8 @@ public Task<SyntaxList<MemberDeclarationSyntax>> GenerateAsync(TransformationCon
             var results = SyntaxFactory.List<MemberDeclarationSyntax>();
 
             MemberDeclarationSyntax copy = null;
-            if (context.ProcessingNode is ClassDeclarationSyntax applyToClass)
+            var applyToClass = context.ProcessingNode as ClassDeclarationSyntax;
+            if (applyToClass != null)
             {
                 copy = applyToClass
                     .WithIdentifier(SyntaxFactory.Identifier(applyToClass.Identifier.ValueText + this.suffix));

src/CodeGeneration.Roslyn.Tests.Generators/DuplicateWithSuffixGenerator.cs

@@ -4,7 +4,10 @@
 namespace CodeGeneration.Roslyn.Tests.Generators
 {
     using System;
+    using System.Collections.Generic;
     using System.Collections.Immutable;
+    using System.Linq;
+    using System.Text;
     using System.Threading;
     using System.Threading.Tasks;
     using CodeGeneration.Roslyn.Tests.Generators.Dependency;
@@ -33,7 +36,8 @@ public Task<SyntaxList<MemberDeclarationSyntax>> GenerateAsync(TransformationCon
             var results = SyntaxFactory.List<MemberDeclarationSyntax>();
 
             MemberDeclarationSyntax copy = null;
-            if (context.ProcessingNode is MethodDeclarationSyntax applyToClass)
+            var applyToClass = context.ProcessingNode as MethodDeclarationSyntax;
+            if (applyToClass != null)
             {
                 copy = applyToClass
                     .WithIdentifier(SyntaxFactory.Identifier(NameGenerator.Combine(applyToClass.Identifier.ValueText, this.suffix)))

src/CodeGeneration.Roslyn.Tests.Generators/ExternalDuplicateWithSuffixGenerator.cs

@@ -4,7 +4,10 @@
 namespace CodeGeneration.Roslyn.Tests.Generators
 {
     using System;
+    using System.Collections.Generic;
+    using System.Collections.Immutable;
     using System.Linq;
+    using System.Text;
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis;
@@ -25,7 +28,8 @@ public Task<SyntaxList<MemberDeclarationSyntax>> GenerateAsync(TransformationCon
             var results = SyntaxFactory.List<MemberDeclarationSyntax>();
 
             MemberDeclarationSyntax copy = null;
-            if (context.ProcessingNode is ClassDeclarationSyntax applyToClass)
+            var applyToClass = context.ProcessingNode as ClassDeclarationSyntax;
+            if (applyToClass != null)
             {
                 var properties = applyToClass.Members.OfType<PropertyDeclarationSyntax>()
                     .Select(x =>

src/CodeGeneration.Roslyn.Tests.Generators/MultiplySuffixGenerator.cs

@@ -5,7 +5,7 @@ namespace CodeGeneration.Roslyn.Tests.RunBuild
 {
     internal static class Program
     {
-        private static void Main()
+        private static void Main(string[] args)
         {
             // This app is a dummy. But when it is debugged within VS, it builds the Tests
             // allowing VS to debug into the build/code generation process.

src/CodeGeneration.Roslyn.Tests.RunBuild/Program.cs

@@ -16,9 +16,9 @@ public partial class CodeGenerationTests
     [Fact]
     public void SimpleGenerationWorks()
     {
-        _ = new CodeGenerationTests.Foo();
-        _ = new CodeGenerationTests.FooA();
-        _ = new CodeGenerationTests.FooB();
+        var foo = new CodeGenerationTests.Foo();
+        var fooA = new CodeGenerationTests.FooA();
+        var fooB = new CodeGenerationTests.FooB();
         var multiplied = new MultipliedBar();
         multiplied.ValueSuff1020();
         Assert.EndsWith(Path.Combine("src", "CodeGeneration.Roslyn.Tests"), DirectoryPathTest.Path, StringComparison.OrdinalIgnoreCase);

src/CodeGeneration.Roslyn.Tests/CodeGenerationTests.cs

@@ -13,7 +13,7 @@ public class NestedNamespacesAndTypesTests
     [Fact]
     public void NestedNamespaceTest()
     {
-        _ = new A.B.OuterType.MiddleType.NestedNSTypeA();
+        var nested = new A.B.OuterType.MiddleType.NestedNSTypeA();
     }
 }
 

src/CodeGeneration.Roslyn.Tests/NestedNamespacesAndTypesTests.cs

@@ -16,7 +16,7 @@ public partial class CodeGenerationTests
     [Fact]
     public void GenerationFromSecondFile()
     {
-        _ = new BarC();
+        var bar = new BarC();
     }
 
     [DuplicateWithSuffixByType("C")]

src/CodeGeneration.Roslyn.Tests/OtherFolder/CodeGenerationTests.cs

@@ -49,13 +49,14 @@ private bool Equals(ArgumentToken other)
 
         public override bool Equals(object obj)
         {
-            if (obj is null)
+            if (ReferenceEquals(obj, null))
                 return false;
 
             if (ReferenceEquals(obj, this))
                 return true;
 
-            return (obj is ArgumentToken other) && Equals(other);
+            var other = obj as ArgumentToken;
+            return !ReferenceEquals(other, null) && Equals(other);
         }
 
         public override int GetHashCode()

src/CodeGeneration.Roslyn.Tool/CommandLine/ArgumentToken.cs

@@ -108,7 +108,6 @@ private static async Task<int> Core(string[] args, CancellationToken cancellatio
             return 0;
         }
 
-
         private static void OnDiagnosticProgress(Diagnostic diagnostic)
         {
             Console.WriteLine(diagnostic.ToString());