The cleanMediaSource function was updated to avoid captions being deleted when the quality of video is changed

Rosari Harlan · Rosari Harlan · commit f99e4f81587b · 2023-06-07T22:54:22.000+09:00
diff --git a/src/quality/quality.js b/src/quality/quality.js
@@ -343,9 +343,10 @@ Object.assign(MediaElementPlayer.prototype, {
 		for (let i = 0; i < media.children.length; i++) {
 			let mediaNode = media.children[i];
 			if (mediaNode.tagName === 'VIDEO') {
-				while (mediaNode.firstChild) {
-					mediaNode.removeChild(mediaNode.firstChild);
-				}
+				const sourceNodes = mediaNode.querySelectorAll('source');
+				Array.from(sourceNodes).forEach((sourceNode) => {
+					mediaNode.removeChild(sourceNode);
+				});
 			}
 		}
 	},

Original file line number	Diff line number	Diff line change
`@@ -343,9 +343,10 @@ Object.assign(MediaElementPlayer.prototype, {`
`343`	`343`	`for (let i = 0; i < media.children.length; i++) {`
`344`	`344`	`let mediaNode = media.children[i];`
`345`	`345`	`if (mediaNode.tagName === 'VIDEO') {`
`346`		`- while (mediaNode.firstChild) {`
`347`		`- mediaNode.removeChild(mediaNode.firstChild);`
`348`		`- }`
	`346`	`+ const sourceNodes = mediaNode.querySelectorAll('source');`
	`347`	`+ Array.from(sourceNodes).forEach((sourceNode) => {`
	`348`	`+ mediaNode.removeChild(sourceNode);`
	`349`	`+ });`
`349`	`350`	`}`
`350`	`351`	`}`
`351`	`352`	`},`