Skip to content

Commit 79f7aae

Browse files
committed
* Removing needless removeAttribute for aria-expanded toggle
* Directly adressing qualities-selected-input instead of going through parent and getting the child input element
1 parent 3610b8d commit 79f7aae

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/quality/quality.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ Object.assign(MediaElementPlayer.prototype, {
185185

186186
function hideSelector() {
187187
mejs.Utils.addClass(qualitiesSelector, `${t.options.classPrefix}offscreen`);
188-
qualityButton.removeAttribute('aria-expanded');
189188
qualityButton.setAttribute('aria-expanded', 'false');
190189
qualityButton.focus();
191190
isHidden = true;
@@ -196,9 +195,7 @@ Object.assign(MediaElementPlayer.prototype, {
196195
qualitiesSelector.style.height = `${qualitiesSelector.querySelector('ul').offsetHeight}px`;
197196
qualitiesSelector.style.top = `${(-1 * parseFloat(qualitiesSelector.offsetHeight))}px`;
198197
qualityButton.setAttribute('aria-expanded', 'true');
199-
const selectedLabel = qualitiesSelector.querySelector('.' + t.options.classPrefix + 'qualities-selected');
200-
const selectedInput = selectedLabel.parentElement.querySelector('input');
201-
selectedInput.focus();
198+
qualitiesSelector.querySelector('.' + t.options.classPrefix + 'qualities-selected-input').focus();
202199
isHidden = false;
203200
}
204201

0 commit comments

Comments
 (0)