Skip to content

Commit 56e5365

Browse files
committed
Fixing aria-markup and keyboard accessibility/focus management for quality plugin.
* Adds aria-controls and aria-expanded status. * Rewrites EventListeners to handle showing/hiding the flyout with keyboard and mouse events. * Adding focus highlighting * Converting px to rem * Removing unnecessary CSS * Fixes for merge comments * Replacing isOffScreen by isHidden
1 parent edca96e commit 56e5365

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/quality/quality.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ Object.assign(MediaElementPlayer.prototype, {
172172
}
173173
});
174174

175-
let isOffScreen = true;
175+
let isHidden = true;
176176
const
177177
qualityContainer = player.qualitiesContainer,
178178
qualityButton = player.qualitiesContainer.querySelector(`button`),
@@ -188,7 +188,7 @@ Object.assign(MediaElementPlayer.prototype, {
188188
qualityButton.removeAttribute('aria-expanded');
189189
qualityButton.setAttribute('aria-expanded', 'false');
190190
qualityButton.focus();
191-
isOffScreen = true;
191+
isHidden = true;
192192
}
193193

194194
function showSelector() {
@@ -197,11 +197,11 @@ Object.assign(MediaElementPlayer.prototype, {
197197
qualitiesSelector.style.top = `${(-1 * parseFloat(qualitiesSelector.offsetHeight))}px`;
198198
qualityButton.setAttribute('aria-expanded', 'true');
199199
qualitiesList.focus();
200-
isOffScreen = false;
200+
isHidden = false;
201201
}
202202

203203
qualityButton.addEventListener('click', () => {
204-
if (isOffScreen === true) {
204+
if (isHidden === true) {
205205
showSelector();
206206
} else {
207207
hideSelector();

0 commit comments

Comments
 (0)