Switch from Heroku CI to GHA (heroku#1604)

* Remove unused env var

* Parallel split test

* Isolate environment modifying test

These tests mutate ENV which was fine when they ran sequentially, but when they're run with parallel split tests we get failures on CI (but not locally)

```
  1) Rails Runner failure in one task does not cause another to fail
     Failure/Error: expect(!!local_storage.success?).to eq(true)
       expected: true
            got: false
       (compared using ==)
       Diff:
       @@ -1 +1 @@
       -true
       +false
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-support-3.13.3/lib/rspec/support.rb:110:in `block in <module:Support>'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-support-3.13.3/lib/rspec/support.rb:119:in `notify_failure'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/fail_with.rb:35:in `fail_with'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/handler.rb:37:in `handle_failure'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/handler.rb:55:in `block in handle_matcher'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/handler.rb:26:in `with_matcher'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/handler.rb:47:in `handle_matcher'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/expectation_target.rb:65:in `to'
     # ./vendor/bundle/ruby/3.3.0/gems/rspec-expectations-3.13.4/lib/rspec/expectations/expectation_target.rb:101:in `to'
     # ./spec/helpers/rails_runner_spec.rb:87:in `block (3 levels) in <top (required)>'
     # ./spec/helpers/rails_runner_spec.rb:10:in `block (2 levels) in wrap_test'
     # ./spec/helpers/rails_runner_spec.rb:9:in `chdir'
     # ./spec/helpers/rails_runner_spec.rb:9:in `block in wrap_test'
     # ./vendor/ruby-3.3.8/lib/ruby/3.3.0/tmpdir.rb:99:in `mktmpdir'
     # ./spec/helpers/rails_runner_spec.rb:8:in `wrap_test'
```

In theory the disk is already isolated, so I'm assuming the problem is with environment variable modification.

* Try tests in GHA

* Fix tests not running on GHA

* Use Rails LTS creds

* Remove unused file

Author: schneems

.github/workflows/ci.yml

@@ -20,3 +20,28 @@ jobs:
         run: |
             shellcheck bin/support/bash_functions.sh bin/support/download_ruby -x &&
             shellcheck bin/compile bin/detect bin/release bin/test bin/test-compile -x
+
+  integration-test:
+      runs-on: ubuntu-24.04
+      env:
+        HATCHET_APP_LIMIT: 300
+        HATCHET_EXPENSIVE_MODE: 1
+        HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
+        HEROKU_API_USER: ${{ secrets.HEROKU_API_USER }}
+        RAILS_LTS_CREDS: ${{ secrets.RAILS_LTS_CREDS }}
+        HEROKU_DISABLE_AUTOUPDATE: 1
+        PARALLEL_SPLIT_TEST_PROCESSES: 85
+        RSPEC_RETRY_RETRY_COUNT: 1
+      steps:
+        - name: Checkout
+          uses: actions/checkout@v4
+        - name: Install Ruby and dependencies
+          uses: ruby/setup-ruby@v1
+          with:
+            bundler-cache: true
+            ruby-version: "3.3.8"
+        - name: Hatchet setup
+          run: bundle exec hatchet ci:setup
+        - name: Run Hatchet integration tests
+          # parallel_split_test runs rspec in parallel, with concurrency equal to PARALLEL_SPLIT_TEST_PROCESSES.
+          run: bundle exec parallel_split_test spec/

Gemfile

@@ -10,7 +10,7 @@ group :development, :test do
   gem "rspec-expectations"
   gem "excon"
   gem "rake"
-  gem "parallel_tests"
+  gem "parallel_split_test"
   gem 'rspec-retry'
   gem 'json'
   gem 'ci-queue'

Gemfile.lock

@@ -27,9 +27,10 @@ GEM
     logger (1.7.0)
     moneta (1.0.0)
     multi_json (1.15.0)
-    parallel (1.25.1)
-    parallel_tests (4.7.1)
-      parallel
+    parallel (1.27.0)
+    parallel_split_test (0.10.0)
+      parallel (>= 0.5.13)
+      rspec-core (>= 3.9.0)
     platform-api (3.8.0)
       heroics (~> 0.1.1)
       moneta (~> 1.0.0)
@@ -66,7 +67,7 @@ DEPENDENCIES
   excon
   heroku_hatchet
   json
-  parallel_tests
+  parallel_split_test
   rake
   redis
   rspec-core

README.md

@@ -50,12 +50,6 @@ To use this buildpack, fork it on Github.  Push up changes to your fork, then cr
 
 ### Testing
 
-The tests on this buildpack are written in Rspec to allow the use of
-`focused: true`. Parallelization of testing is provided by
-https://github.com/grosser/parallel_tests this lib spins up an arbitrary
-number of processes and running a different test file in each process,
-it does not parallelize tests within a test file. To run the tests: clone the repo, then `bundle install` then clone the test fixtures by running:
-
 ```sh
 $ bundle exec hatchet install
 ```

app.json

@@ -2,16 +2,17 @@
 
 describe "Rails Runner" do
   around(:each) do |test|
-    original_path = ENV["PATH"]
-    ENV["PATH"] = "./bin/:#{ENV['PATH']}"
-
-    Dir.mktmpdir do |tmpdir|
-      Dir.chdir(tmpdir) do
-        test.run
+    # Process and disk isolation
+    Hatchet::App.new("default_ruby").in_directory_fork do
+      original_path = ENV["PATH"]
+      ENV["PATH"] = "./bin/:#{ENV['PATH']}"
+
+      Dir.mktmpdir do |tmpdir|
+        Dir.chdir(tmpdir) do
+          test.run
+        end
       end
     end
-  ensure
-    ENV["PATH"] = original_path if original_path
   end
 
   it "config objects build propperly formatted commands" do
@@ -132,9 +133,5 @@ def to_s
     FileUtils.mkdir("bin")
     File.open("bin/rails", "w") { |f| f << executable_contents }
     File.chmod(0777, "bin/rails")
-
-    # BUILDPACK_LOG_FILE support for logging
-    FileUtils.mkdir("tmp")
-    FileUtils.touch("buildpack.log")
   end
 end

spec/helpers/rails_runner_spec.rb

@@ -19,12 +19,9 @@ def hatchet_path(path = "")
 end
 
 RSpec.configure do |config|
-  config.filter_run focused: true unless ENV['IS_RUNNING_ON_CI']
-  config.run_all_when_everything_filtered = true
   config.alias_example_to :fit, focused: true
   config.full_backtrace      = true
   config.verbose_retry       = true # show retry status in spec process
-  config.default_retry_count = 2 if ENV['IS_RUNNING_ON_CI'] # retry all tests that fail again
   config.example_status_persistence_file_path = 'spec/examples.txt'
 
   config.expect_with :rspec do |c|