Skip to content

Commit 0fa0de3

Browse files
authored
Ensure workflow uses same bundler version (heroku#1568)
* Ensure workflow uses same bundler version * Fix test
1 parent c9d002a commit 0fa0de3

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/hatchet_app_cleaner.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
uses: ruby/setup-ruby@v1
2525
with:
2626
bundler-cache: true
27-
ruby-version: "3.1"
27+
ruby-version: "3.1.6"
2828
- name: Run Hatchet destroy
2929
# Only apps older than 10 minutes are destroyed, to ensure that any
3030
# in progress CI runs are not interrupted.

spec/helpers/config_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
expect(`ruby -v`).to match(Regexp.escape(LanguagePack::RubyVersion::BOOTSTRAP_VERSION_NUMBER))
1111

12-
# bootstrap_version = Gem::Version.new(LanguagePack::RubyVersion::BOOTSTRAP_VERSION_NUMBER)
13-
# default_version = Gem::Version.new(LanguagePack::RubyVersion::DEFAULT_VERSION_NUMBER)
14-
15-
# expect(bootstrap_version).to be >= default_version
12+
ci_task = Pathname(".github").join("workflows").join("hatchet_app_cleaner.yml").read
13+
ci_task_yml = YAML.load(ci_task)
14+
task = ci_task_yml["jobs"]["hatchet-app-cleaner"]["steps"].detect {|step| step["uses"].match?(/ruby\/setup-ruby/)} or raise "Not found"
15+
expect(task["with"]["ruby-version"]).to match(LanguagePack::RubyVersion::BOOTSTRAP_VERSION_NUMBER)
1616
end
1717
end

spec/helpers/outdated_ruby_version_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
)
2020

2121
outdated.call
22-
expect(outdated.suggested_ruby_minor_version).to eq("3.1.6")
22+
expect(outdated.suggested_ruby_minor_version).to eq("3.1.7")
2323
end
2424

2525
it "handles arm 💪 architecture on heroku-24" do

0 commit comments

Comments
 (0)